FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

client: refactor classic.header.vue to composition api #97

Merged
Johann150 merged 1 commit from refactor/client/classic.header.vue into main 2022-08-31 10:06:02 +00:00
Conversation 0 Commits 1 Files changed 1 +43 -74
norm commented 2022-08-30 17:51:27 +00:00
Owner
Copy link
No description provided.
Johann150 reviewed 2022-08-30 20:41:10 +00:00
packages/client/src/ui/classic.header.vue Outdated
@ -26,3 +26,3 @@
<i class="fas fa-cog fa-fw"></i>
</MkA>
<button v-click-anime class="item _button account" @click="openAccountMenu">
<button v-if="$i" v-click-anime class="item _button account" @click="openAccountMenu">
Johann150 commented 2022-08-30 20:39:30 +00:00
Owner
Copy link

I don't think checking for $i is necessary here, since this component is intended for classic UI which is only shown for logged in users. Visitors will only see the visitor UI.

I don't think checking for `$i` is necessary here, since this component is intended for classic UI which is only shown for logged in users. Visitors will only see the visitor UI.
norm marked this conversation as resolved
packages/client/src/ui/classic.header.vue Outdated
@ -45,3 +43,3 @@
import * as os from '@/os';
import { menuDef } from '@/menu';
import { openAccountMenu } from '@/account';
import { openAccountMenu as openAccountMenu_, $i, iAmModerator } from '@/account';
Johann150 commented 2022-08-30 20:37:02 +00:00
Owner
Copy link

I think it would be nicer to rename the function thats defined here and import it with the correct name.

I think it would be nicer to rename the function thats defined here and import it with the correct name.
norm marked this conversation as resolved
norm force-pushed refactor/client/classic.header.vue from 0d8be2651e to 9a22905e85 2022-08-30 20:46:07 +00:00 Compare
Johann150 merged commit 9a22905e85 into main 2022-08-31 10:06:02 +00:00
Johann150 deleted branch refactor/client/classic.header.vue 2022-08-31 10:06:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#97
No description provided.
Delete branch "refactor/client/classic.header.vue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?