FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

client: Sort emojis by query similarity in fuzzy picker #156

Merged
norm merged 6 commits from Michcio/FoundKey-0x7f:tostis-emojosort into main 2022-09-19 14:43:13 +00:00
Conversation 2 Commits 6 Files changed 3 +3 -1
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 395e6171b0 - Show all commits

4
packages/client/src/components/emoji-picker.vue
View file

@ -151,7 +151,9 @@ function emojiSearch<Type extends foundkey.entities.CustomEmoji|UnicodeEmojiDef>
const distance = (str: string): number => rodistance(joinq, str);
const mindistance = (strs: string[]): number => Math.min(...strs.map(distance));
const distinguisher = (emoji: Type): string => 'char' in emoji ? emoji.char : emoji.id;
matches.forEach(emoji => distances[distinguisher(emoji)] = Math.min(distance(emoji.name), mindistance(aliases(emoji))));
for (const emoji of matches) {
Michcio marked this conversation as resolved Outdated
norm commented 2022-09-15 14:24:22 +00:00
Outdated
Review
Copy link

Is there a reason forEach is used instead of for (const emoji of matches)?

Is there a reason `forEach` is used instead of `for (const emoji of matches)`?
Michcio commented 2022-09-19 10:58:34 +00:00
Outdated
Review
Copy link

No, it just wasn't an error. I too prefer for (...).

No, it just wasn't an error. I too prefer `for (...)`.
👍 1
distances[distinguisher(emoji)] = Math.min(distance(emoji.name), mindistance(aliases(emoji)));
}
// sort by distance from query
matches.sort((a, b) => distances[distinguisher(a)] - distances[distinguisher(b)]);