client: Use named constants for time calculations #183

Merged

norm merged 6 commits from client-time-constants into main 2022-10-04 18:05:41 +00:00

Conversation 2 Commits 6 Files changed 10 +65 -49

norm commented 2022-10-03 21:23:13 +00:00

Contributor

Copy link

Constants were borrowed from const.ts from the backend but also
includes WEEK, MONTH, and YEAR constants as well.

Constants were borrowed from `const.ts` from the backend but also includes `WEEK`, `MONTH`, and `YEAR` constants as well.

Johann150 approved these changes 2022-10-04 08:28:10 +00:00

Johann150 left a comment

Owner

Copy link

Looks good this far.

If you want to convert everything, I also found that at least scripts/get-user-menu.ts and components/poll-editor.vue and a timeout in pages/settings/2fa.vue also exist.

Looks good this far. If you want to convert everything, I also found that at least `scripts/get-user-menu.ts` and `components/poll-editor.vue` and a timeout in `pages/settings/2fa.vue` also exist.

norm force-pushed client-time-constants from 6e1fddcd14 to 5830a983b8 2022-10-04 16:55:15 +00:00 Compare

norm force-pushed client-time-constants from 5830a983b8 to ffc4fe244d 2022-10-04 17:04:45 +00:00 Compare

norm force-pushed client-time-constants from f5a41b1fc4 to 40d3358374 2022-10-04 17:38:34 +00:00 Compare

Johann150 approved these changes 2022-10-04 17:58:13 +00:00

norm merged commit 9dddb1eb6d into main 2022-10-04 18:05:41 +00:00

norm deleted branch client-time-constants 2022-10-04 18:05:41 +00:00

norm referenced this pull request from a commit 2022-10-04 18:05:41 +00:00

client: Use named constants for time calculations (#183)

Sign in to join this conversation.

Reviewers

No reviewers

Johann150

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

FoundKeyGang/FoundKey!183

No description provided.