FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

implement separate web workers #252

Merged
toast merged 2 commits from web-worker into main 2022-12-03 13:33:24 +00:00
Conversation 1 Commits 2 Files changed 5 +4 -4
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6600f6e52e - Show all commits

8
packages/backend/src/boot/master.ts
View file

@ -141,12 +141,12 @@ async function connectDb(): Promise<void> {
async function spawnWorkers(clusterLimits: Required<Config['clusterLimits']>): Promise<void> {
const modes = ['web', 'queue'];
const total = modes.reduce((acc, mode) => acc + clusterLimits[mode], 0);
if (total > os.cpus().length) {
bootLogger.error(`configuration error: cluster limits total (${total}) must not exceed number of cores (${os.cpus().length})`);
process.exit(78);
const cpus = os.cpus().length;
for (const mode of modes.filter(mode => clusterLimits[mode] > cpus)) {
bootLogger.warn(`configuration warning: cluster limit for ${mode} exceeds number of cores (${cpus})`);
}
const total = modes.reduce((acc, mode) => acc + clusterLimits[mode], 0);
const workers = new Array(total);
workers.fill('web', 0, clusterLimits.web);
workers.fill('queue', clusterLimits.web);
toast marked this conversation as resolved
toast commented 2022-11-26 12:06:17 +00:00
Review
Copy link

This construction is a little odd and seems to me to be prone to off-by-ones.
I would write it as this:

const web = new Array(clusterLimits.web).map(() => spawnWorker('web'));
const queue = new Array(clusterLimits.queue).map(() => spawnWorker('queue'));
const all = [...web, ...queue]);
console.log(`Starting ${all.length} workers...`);
await Promise.all(all);
This construction is a little odd and seems to me to be prone to off-by-ones. I would write it as this: ```js const web = new Array(clusterLimits.web).map(() => spawnWorker('web')); const queue = new Array(clusterLimits.queue).map(() => spawnWorker('queue')); const all = [...web, ...queue]); console.log(`Starting ${all.length} workers...`); await Promise.all(all); ```
Johann150 commented 2022-11-26 12:43:35 +00:00
Review
Copy link

Your example code wouldn't work because new Array(n) generates an array with n empty slots and map basically ignores those.

Your example code wouldn't work because `new Array(n)` generates an array with `n` empty slots and `map` basically ignores those.
toast commented 2022-12-03 13:32:57 +00:00
Review
Copy link

I've thought about it a bit and it's fine.
Could be a TODO for cleanup later, but this is fine and works as expected.

I've thought about it a bit and it's fine. Could be a TODO for cleanup later, but this is fine and works as expected.