client: remove _acrylic #27

Merged

Johann150 merged 2 commits from del-acrylic into main 2022-08-12 21:25:07 +00:00

Conversation 3 Commits 2 Files changed 17 +14 -42

toast commented 2022-07-25 11:10:19 +00:00

Owner

Copy link

I might expand this branch into additional "feature" removals (like drop shadows, idk).
I do feel like a "flat" style would suit fkey more.
RFC (or just merge and I can make extra branches later).

I might expand this branch into additional "feature" removals (like drop shadows, idk). I do feel like a "flat" style would suit fkey more. RFC (or just merge and I can make extra branches later).

Johann150 commented 2022-07-25 15:46:03 +00:00

Owner

Copy link

Tooltips, the notification toast and the upload thingy are now entirely without background:

I'm also not sure if the entire acrylicPanel shouldn't be removed, it seems to be coming from themes but is also used in pages/welcome.entrance.a.vue.

Tooltips, the notification toast and the upload thingy are now entirely without background:    I'm also not sure if the entire `acrylicPanel` shouldn't be removed, it seems to be coming from themes but is also used in `pages/welcome.entrance.a.vue`.

image.png

21 KiB

image.png

12 KiB

toast commented 2022-07-25 16:02:00 +00:00

Author

Owner

Copy link

Yeah I should have marked this WIP tbh.
I'm not actually intending it to be merged yet ^^;;

Yeah I should have marked this WIP tbh. I'm not actually intending it to be merged yet ^^;;

toast changed title from client: remove _acrylic to WIP: client: remove _acrylic 2022-07-25 16:02:07 +00:00

toast commented 2022-07-25 16:02:30 +00:00

Author

Owner

Copy link

Still TODO is cleaning up extranious things and finding the transparency settings and tweaking those. Then tests.

Still TODO is cleaning up extranious things and finding the transparency settings and tweaking those. Then tests.

toast force-pushed del-acrylic from ab5273b439 to 1de3c5dede 2022-08-08 14:11:07 +00:00 Compare

toast force-pushed del-acrylic from 1de3c5dede to 2b55185bce 2022-08-11 10:26:54 +00:00 Compare

toast changed title from WIP: client: remove _acrylic to client: remove _acrylic 2022-08-11 10:27:36 +00:00

Johann150 force-pushed del-acrylic from 2b55185bce to 4b185906d4 2022-08-12 07:12:46 +00:00 Compare

Johann150 merged commit 9e6bc30a66 into main 2022-08-12 21:25:07 +00:00

Johann150 deleted branch del-acrylic 2022-08-12 21:25:07 +00:00

norm referenced this pull request from a commit 2022-08-28 14:46:46 +00:00

fix: Notificationsの型を修正 (#27)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#27

No description provided.