FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

activitypub: process Move activities and movedTo field on actors #309

Manually merged
Johann150 merged 10 commits from account-moving into main 2023-03-23 20:48:19 +00:00
Conversation 5 Commits 10 Files changed 17 +5 -2
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 27ddb2496c - Show all commits

1
locales/en-US.yml
View file

@ -1291,7 +1291,6 @@ _notification:
yourFollowRequestAccepted: "Your follow request was accepted"
youWereInvitedToGroup: "{userName} invited you to a group"
pollEnded: "Poll results have become available"
moved: "{name} has moved to a different account"
emptyPushNotificationMessage: "Push notifications have been updated"
_types:
follow: "New followers"

6
packages/client/src/components/notification.vue
View file

@ -88,7 +88,11 @@
</div>
</span>
<span v-if="notification.type === 'move'" class="text" style="opacity: 0.6;">
Johann150 marked this conversation as resolved
amybones commented 2023-03-21 22:31:58 +00:00
Review
Copy link

Something that might be worth refactoring in this PR but is otherwise fine: The CSS class text is used several times with a local override of opacity: 0.6 it might be worth factoring out a dedicated CSS class for this like dim-notification-text or even just a class that only applies the opacity. IIRC this will help a bit with rendering performance.

Something that might be worth refactoring in this PR but is otherwise fine: The CSS class `text` is used several times with a local override of `opacity: 0.6` it might be worth factoring out a dedicated CSS class for this like `dim-notification-text` or even just a class that only applies the opacity. IIRC this will help a bit with rendering performance.
Johann150 commented 2023-03-22 21:31:48 +00:00
Review
Copy link

Good idea in general, but this has nothing to do with Move activities so it should be done outside of this PR.

Good idea in general, but this has nothing to do with `Move` activities so it should be done outside of this PR.
{{ i18n.ts.moved }}
<I18n :src="i18n.ts.movedTo">
<template #handle>
<MkAcct :user="notification.moveTarget"/>
</template>
</I18n>
<div v-if="full"><MkFollowButton :user="notification.moveTarget" :full="true"/></div>
</span>
<span v-if="notification.type === 'app'" class="text">