FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

server: implement FEP-e232 style quotes #318

Manually merged
Johann150 merged 5 commits from federation-quote into main 2023-01-17 20:51:55 +00:00
Conversation 0 Commits 5 Files changed 4 +12 -17
1 changed files with 12 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 3d3ecab271 - Show all commits

29
packages/backend/src/remote/activitypub/models/tag.ts
View file

@ -29,26 +29,21 @@ export function extractQuoteUrl(tags: IObject | IObject[] | null | undefined): s
'application/ld+json; profile="https://www.w3.org/ns/activitystreams"',
'application/activity+json'
].includes(link.mediaType?.toLowerCase())
Johann150 marked this conversation as resolved
a commented 2023-01-06 00:57:12 +00:00
Review
Copy link

i'd instead do toArray(tags).filter(hasRel) because the link relation is what is doing all the semantic heavy-lifting

i'd instead do `toArray(tags).filter(hasRel)` because the link relation is what is doing all the semantic heavy-lifting
Johann150 commented 2023-01-06 06:54:09 +00:00
Review
Copy link

This part is to implement the FEP because it says that this media type is required.

This part is to implement the FEP because it says that this media type is required.
)
.filter(link =>
toArray(link.rel)
.some(rel =>
[
'https://misskey-hub.net/ns#_misskey_quote',
'http://fedibird.com/ns#quoteUri',
'https://www.w3.org/ns/activitystreams#quoteUrl',
].includes(rel)
)
);
// sort quotes with the right rel first
function hasRel(link: ILink): boolean {
link.rel != null
&&
toArray(link.rel)
.includes('https://misskey-hub.net/ns#_misskey_quote')
}
quotes.sort((a, b) => {
return hasRel(b) - hasRel(a);
});
// deduplicate by href
quotes = quotes.filter((x, i, arr) => arr.findIndex(y => x.href === y.href) === i);
if (quotes.length === 0) return null;
// Deduplicate by href.
// If there is more than one quote, we just pick the first/a random one.
// Note that links with the correct `rel` were sorted to the front above
// so they will be preferred.
return quotes[0].href;
quotes.filter((x, i, arr) => arr.findIndex(y => x.href === y.href) === i)[0].href;
}