Johann150
Johann150 pushed to main at FoundKeyGang/FoundKey 2023-06-29 19:22:19 +00:00
2f30af1812 server: fix instance actor creation
Johann150 commented on issue FoundKeyGang/FoundKey#400 2023-06-29 17:59:09 +00:00
Display names, renoted/reacted post content in notifications missing

Puniko noted in their PR that it may need a yarn cleanall before building again: FoundKeyGang/FoundKey#385 (comment)

For me it worked without it, but maybe…

Johann150 pushed to main at FoundKeyGang/FoundKey 2023-06-27 20:26:56 +00:00
2d46cf7c1e fixup! client: fix MFM overflow
Johann150 pushed to note-editing at FoundKeyGang/FoundKey 2023-06-27 20:26:48 +00:00
8ec579c894 trigger side effects after updating note
03b43411b3 refactor note creation side effects
18e1625106 server: add noteStream handling for updated notes
ac5751e2ec activitypub: handle incoming Update Note activities
65f2b18e22 add function to update a note
Compare 8 commits »
Johann150 pushed to note-editing at FoundKeyGang/FoundKey 2023-06-27 20:21:45 +00:00
900f980cc8 fixup! client: fix MFM overflow
Johann150 pushed to note-editing at FoundKeyGang/FoundKey 2023-06-27 20:05:08 +00:00
723eed294c trigger side effects after updating note
7b1620b7d0 refactor note creation side effects
b44bec5706 server: add noteStream handling for updated notes
cb991ac0df activitypub: handle incoming Update Note activities
80131b6e27 add function to update a note
Compare 16 commits »
Johann150 pushed to main at FoundKeyGang/FoundKey 2023-06-27 20:02:48 +00:00
2ea6daaf7a rename extractDbHost to extractPunyHost
Johann150 commented on issue FoundKeyGang/FoundKey#29 2023-06-27 20:00:16 +00:00
Secure fetch

solved by #399 (b600efae0dbb6d786e4defa0df173b4eee6b9283)

Johann150 closed issue FoundKeyGang/FoundKey#29 2023-06-27 20:00:16 +00:00
Secure fetch
Johann150 merged pull request FoundKeyGang/FoundKey#399 2023-06-27 19:59:29 +00:00
BREAKING: activitypub: validate fetch signatures
Johann150 pushed to main at FoundKeyGang/FoundKey 2023-06-27 19:58:58 +00:00
597de07465 server: refactor HTTP signature validation
9289b0e8ed adjust config file example
b600efae0d BREAKING: activitypub: validate fetch signatures
Compare 3 commits »
Johann150 commented on pull request FoundKeyGang/FoundKey#399 2023-06-25 18:34:40 +00:00
BREAKING: activitypub: validate fetch signatures

Do you have a suggestion for a better name (for future refactoring)?

Johann150 pushed to main at FoundKeyGang/FoundKey 2023-06-25 18:25:41 +00:00
ecca5a164e client: always forbid MFM overflow
1125a623a7 Revert "client: fix MFM overflow"
Compare 2 commits »
Johann150 pushed to main at FoundKeyGang/FoundKey 2023-06-23 20:00:43 +00:00
51a319e8ca use extractDbHost
Johann150 commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 16:49:51 +00:00
BREAKING: activitypub: validate fetch signatures

🔧 I think it would be better if this goes into the config file instead of the database. People should not have to manually edit the database to change configuration.

Johann150 commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 16:49:51 +00:00
BREAKING: activitypub: validate fetch signatures

This should be refactored together with the code from packages/backend/src/queue/processors/inbox.ts that this was copied from to work out a way that does not duplicate most of the code.

Johann150 commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 16:49:51 +00:00
BREAKING: activitypub: validate fetch signatures

Explicitly checking for something to equal true seems unnecessary, since httpSignature.verifySignature has the return type boolean.

Johann150 commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 16:49:51 +00:00
BREAKING: activitypub: validate fetch signatures
Johann150 commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 16:49:51 +00:00
BREAKING: activitypub: validate fetch signatures

This function is always used together with validateFetchSignature, and the call signature is always handleSignatureResult(ctx, await validateFetchSignature(ctx.req)). Is there a reason for them being two separate functions?

Johann150 commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 16:49:51 +00:00
BREAKING: activitypub: validate fetch signatures

It could be easier to understand if this was a middleware function that could be added to routes.