From 1db0dc30728a64cf5a9905bcc5df5af9ff3c677b Mon Sep 17 00:00:00 2001
From: William Pitcock <nenolod@dereferenced.org>
Date: Sat, 26 May 2018 11:16:05 +0000
Subject: [PATCH] tests: add tests to verify the accept request is discarded if
 no follow activity could be found

---
 test/web/activity_pub/transmogrifier_test.exs | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/test/web/activity_pub/transmogrifier_test.exs b/test/web/activity_pub/transmogrifier_test.exs
index b51e02b08..e4cff898d 100644
--- a/test/web/activity_pub/transmogrifier_test.exs
+++ b/test/web/activity_pub/transmogrifier_test.exs
@@ -394,6 +394,8 @@ test "it works for incoming accepts which were pre-accepted" do
       {:ok, follower} = User.follow(follower, followed)
       assert User.following?(follower, followed) == true
 
+      {:ok, follow_activity} = ActivityPub.follow(follower, followed)
+
       accept_data =
         File.read!("test/fixtures/mastodon-accept-activity.json")
         |> Poison.decode!()
@@ -449,6 +451,25 @@ test "it works for incoming accepts which are referenced by IRI only" do
       assert User.following?(follower, followed) == true
     end
 
+    test "it fails for incoming accepts which cannot be correlated" do
+      follower = insert(:user)
+      followed = insert(:user, %{info: %{"locked" => true}})
+
+      accept_data =
+        File.read!("test/fixtures/mastodon-accept-activity.json")
+        |> Poison.decode!()
+        |> Map.put("actor", followed.ap_id)
+
+      accept_data =
+        Map.put(accept_data, "object", Map.put(accept_data["object"], "actor", follower.ap_id))
+
+      :error = Transmogrifier.handle_incoming(accept_data)
+
+      follower = Repo.get(User, follower.id)
+
+      refute User.following?(follower, followed) == true
+    end
+
     test "it works for incoming rejects which are orphaned" do
       follower = insert(:user)
       followed = insert(:user, %{info: %{"locked" => true}})