Remove LDAP mail attribute as a requirement for registering an account

lib/pleroma/web/auth/ldap_authenticator.ex

@@ -105,13 +105,10 @@ defp register_user(connection, base, uid, name, password) do
            {:base, to_charlist(base)},
            {:filter, :eldap.equalityMatch(to_charlist(uid), to_charlist(name))},
            {:scope, :eldap.wholeSubtree()},
-           {:attributes, ['mail', 'email']},
            {:timeout, @search_timeout}
          ]) do
-      {:ok, {:eldap_search_result, [{:eldap_entry, _, attributes}], _}} ->
-        with {_, [mail]} <- List.keyfind(attributes, 'mail', 0) do
+      {:ok, {:eldap_search_result, [{:eldap_entry, _, _}], _}} ->
         params = %{
-            email: :erlang.list_to_binary(mail),
           name: name,
           nickname: name,
           password: password,
@@ -124,11 +121,6 @@ defp register_user(connection, base, uid, name, password) do
           {:ok, user} -> user
           error -> error
         end
-        else
-          _ ->
-            Logger.error("Could not find LDAP attribute mail: #{inspect(attributes)}")
-            {:error, :ldap_registration_missing_attributes}
-        end
 
       error ->
         error

test/web/oauth/ldap_authorization_test.exs

@@ -72,9 +72,7 @@ test "creates a new user after successful LDAP authorization" do
          equalityMatch: fn _type, _value -> :ok end,
          wholeSubtree: fn -> :ok end,
          search: fn _connection, _options ->
-           {:ok,
-            {:eldap_search_result, [{:eldap_entry, '', [{'mail', [to_charlist(user.email)]}]}],
-             []}}
+           {:ok, {:eldap_search_result, [{:eldap_entry, '', []}], []}}
          end,
          close: fn _connection ->
            send(self(), :close_connection)