Add behaviours to TwitterCard, remove some dumb stuff in Formatter.truncate

lib/pleroma/formatter.ex

@@ -184,21 +184,12 @@ def finalize({subs, text}) do
     end)
   end
 
-  def truncate(text, opts \\ []) do
+  def truncate(text, max_length \\ 200, omission \\ "...") do
-    max_length = opts[:max_length] || 200
+    if String.length(text) < max_length do
-    omission = opts[:omission] || "..."
+      text
-
+    else
-    cond do
+      length_with_omission = max_length - String.length(omission)
-      not String.valid?(text) ->
+      String.slice(text, 0, length_with_omission) <> omission
-        text
-
-      String.length(text) < max_length ->
-        text
-
-      true ->
-        length_with_omission = max_length - String.length(omission)
-
-        "#{String.slice(text, 0, length_with_omission)}#{omission}"
     end
   end
 end

lib/pleroma/web/metadata/opengraph.ex

@@ -19,7 +19,8 @@ def build_tags(%{activity: activity, user: user}) do
         {:meta, [property: "og:url", content: activity.data["id"]], []},
         {:meta, [property: "og:description", content: truncated_content], []}
       ] ++
-        if attachments == [] or Enum.any?(activity.data["object"]["tag"], fn tag -> tag == "nsfw" end) do
+        if attachments == [] or
+             Enum.any?(activity.data["object"]["tag"], fn tag -> tag == "nsfw" end) do
           [
             {:meta, [property: "og:image", content: attachment_url(User.avatar_url(user))], []},
             {:meta, [property: "og:image:width", content: 120], []},

lib/pleroma/web/metadata/twitter_card.ex

@@ -1,4 +1,9 @@
 defmodule Pleroma.Web.Metadata.Providers.TwitterCard do
+  alias Pleroma.Web.Metadata.Providers.Provider
+
+  @behaviour Provider
+
+  @impl Provider
   def build_tags(%{activity: activity}) do
     if Enum.any?(activity.data["object"]["tag"], fn tag -> tag == "nsfw" end) or
          activity.data["object"]["attachment"] == [] do
@@ -20,6 +25,7 @@ def build_tags(%{activity: activity}) do
     end
   end
 
+  @impl Provider
   def build_tags(_) do
     [{:meta, [property: "twitter:card", content: "summary"], []}]
   end