From 2e07477398a2b0e2a1cc9302c421cbf0d5a33dc1 Mon Sep 17 00:00:00 2001
From: Johann150 <johann.galle@protonmail.com>
Date: Sun, 2 Oct 2022 15:52:39 +0200
Subject: [PATCH 1/2] client: discard drafts that are just the default state

Changelog: Changed
---
 packages/client/src/components/post-form.vue | 65 +++++++++++++++-----
 1 file changed, 50 insertions(+), 15 deletions(-)

diff --git a/packages/client/src/components/post-form.vue b/packages/client/src/components/post-form.vue
index 3340f22ae..8821641f6 100644
--- a/packages/client/src/components/post-form.vue
+++ b/packages/client/src/components/post-form.vue
@@ -121,9 +121,9 @@ const cwInputEl = $ref<HTMLInputElement | null>(null);
 const hashtagsInputEl = $ref<HTMLInputElement | null>(null);
 const visibilityButton = $ref<HTMLElement | null>(null);
 
-let posting = $ref(false);
-let text = $ref(props.initialText ?? '');
-let files = $ref(props.initialFiles ?? []);
+let posting: boolean = $ref(false);
+let text: string = $ref(props.initialText ?? '');
+let files: foundkey.entities.DriveFile[] = $ref(props.initialFiles ?? []);
 let poll = $ref<{
 	choices: string[];
 	multiple: boolean;
@@ -502,21 +502,56 @@ function onDrop(ev): void {
 	//#endregion
 }
 
+// Save a copy of the initial data to detect whether it has been changed.
+// Cloning the data to make sure there are no remaining references.
+const initialDraftData = JSON.parse(JSON.stringify({
+	text,
+	useCw,
+	cw,
+	visibility,
+	localOnly,
+	files,
+	poll,
+}));
+
 function saveDraft() {
 	const draftData = JSON.parse(localStorage.getItem('drafts') || '{}');
 
-	draftData[draftKey] = {
-		updatedAt: new Date(),
-		data: {
-			text,
-			useCw,
-			cw,
-			visibility,
-			localOnly,
-			files,
-			poll,
-		},
-	};
+	if (
+		initialDraftData.text === text
+		&& initialDraftData.useCw === useCw
+		// don't compare cw for equality if it is disabled, since it won't be sent
+		&& (!useCw || initialDraftData.cw === cw)
+		&& initialDraftData.visibility === visibility
+		&& initialDraftData.localOnly === localOnly
+		&& initialDraftData.files.each((file, i) => file.id === files[i].id)
+		&& (
+			(initialDraftData.poll == null && poll == null)
+			|| (
+				initialDraftData.poll.choices.each((choice, i) => choice === choices[i])
+				&& initialDraftData.poll.multiple === poll.multiple
+				&& initialDraftData.poll.expiresAt === poll.expiresAt
+				&& initialDraftData.poll.expiredAfter === poll.expiredAfter
+			)
+		)
+	) {
+		// This is the same as the initial draft data, no need to save it.
+		// If it was saved before, delete it.
+		delete draftData[draftKey];
+	} else {
+		draftData[draftKey] = {
+			updatedAt: new Date(),
+			data: {
+				text,
+				useCw,
+				cw,
+				visibility,
+				localOnly,
+				files,
+				poll,
+			},
+		};
+	}
 
 	localStorage.setItem('drafts', JSON.stringify(draftData));
 }

From def1e6396c6b6b8e70ccf5b8155a55a13af85ac9 Mon Sep 17 00:00:00 2001
From: Johann150 <johann.galle@protonmail.com>
Date: Sun, 2 Oct 2022 16:13:37 +0200
Subject: [PATCH 2/2] fixup: simplify check because there is never an initial
 poll

---
 packages/client/src/components/post-form.vue | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/packages/client/src/components/post-form.vue b/packages/client/src/components/post-form.vue
index 8821641f6..8f1b78211 100644
--- a/packages/client/src/components/post-form.vue
+++ b/packages/client/src/components/post-form.vue
@@ -511,7 +511,6 @@ const initialDraftData = JSON.parse(JSON.stringify({
 	visibility,
 	localOnly,
 	files,
-	poll,
 }));
 
 function saveDraft() {
@@ -525,15 +524,8 @@ function saveDraft() {
 		&& initialDraftData.visibility === visibility
 		&& initialDraftData.localOnly === localOnly
 		&& initialDraftData.files.each((file, i) => file.id === files[i].id)
-		&& (
-			(initialDraftData.poll == null && poll == null)
-			|| (
-				initialDraftData.poll.choices.each((choice, i) => choice === choices[i])
-				&& initialDraftData.poll.multiple === poll.multiple
-				&& initialDraftData.poll.expiresAt === poll.expiresAt
-				&& initialDraftData.poll.expiredAfter === poll.expiredAfter
-			)
-		)
+		// initial state is always poll == null
+		&& poll == null
 	) {
 		// This is the same as the initial draft data, no need to save it.
 		// If it was saved before, delete it.