From ccc8bf0289dc67d3b45dd84cb0def2733af9f95d Mon Sep 17 00:00:00 2001 From: Johann150 Date: Tue, 13 Dec 2022 23:09:20 +0100 Subject: [PATCH] chore: fix more miscellaneous lints --- packages/backend/src/db/postgre.ts | 14 +++++++------- packages/backend/src/queue/initialize.ts | 2 +- .../src/remote/activitypub/kernel/create/note.ts | 2 +- .../backend/src/server/api/endpoints/auth/deny.ts | 2 +- .../src/server/api/endpoints/notes/replies.ts | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/backend/src/db/postgre.ts b/packages/backend/src/db/postgre.ts index c7a2a9b6c..90b123ae8 100644 --- a/packages/backend/src/db/postgre.ts +++ b/packages/backend/src/db/postgre.ts @@ -78,33 +78,33 @@ import { redisClient } from './redis.js'; const sqlLogger = dbLogger.createSubLogger('sql', 'gray', false); class MyCustomLogger implements Logger { - private highlight(sql: string) { + private highlight(sql: string): string { return highlight.highlight(sql, { language: 'sql', ignoreIllegals: true, }); } - public logQuery(query: string, parameters?: any[]) { + public logQuery(query: string): void { sqlLogger.info(this.highlight(query).substring(0, 100)); } - public logQueryError(error: string, query: string, parameters?: any[]) { + public logQueryError(error: string, query: string): void { sqlLogger.error(this.highlight(query)); } - public logQuerySlow(time: number, query: string, parameters?: any[]) { + public logQuerySlow(time: number, query: string): void { sqlLogger.warn(this.highlight(query)); } - public logSchemaBuild(message: string) { + public logSchemaBuild(message: string): void { sqlLogger.info(message); } - public log(message: string) { + public log(message: string): void { sqlLogger.info(message); } - public logMigration(message: string) { + public logMigration(message: string): void { sqlLogger.info(message); } } diff --git a/packages/backend/src/queue/initialize.ts b/packages/backend/src/queue/initialize.ts index 709466e05..d866ef61b 100644 --- a/packages/backend/src/queue/initialize.ts +++ b/packages/backend/src/queue/initialize.ts @@ -20,7 +20,7 @@ export function initialize(name: string, limitPerSec = -1): Bull.Queue { } // ref. https://github.com/misskey-dev/misskey/pull/7635#issue-971097019 -function apBackoff(attemptsMade: number, err: Error) { +function apBackoff(attemptsMade: number /*, err: Error */): number { const baseDelay = MINUTE; const maxBackoff = 8 * HOUR; let backoff = (Math.pow(2, attemptsMade) - 1) * baseDelay; diff --git a/packages/backend/src/remote/activitypub/kernel/create/note.ts b/packages/backend/src/remote/activitypub/kernel/create/note.ts index 1e3207ccd..0b71566ba 100644 --- a/packages/backend/src/remote/activitypub/kernel/create/note.ts +++ b/packages/backend/src/remote/activitypub/kernel/create/note.ts @@ -9,7 +9,7 @@ import { getApId, IObject, ICreate } from '@/remote/activitypub/type.js'; /** * 投稿作成アクティビティを捌きます */ -export default async function(resolver: Resolver, actor: CacheableRemoteUser, note: IObject, silent = false, activity?: ICreate): Promise { +export default async function(resolver: Resolver, actor: CacheableRemoteUser, note: IObject, silent = false): Promise { const uri = getApId(note); if (typeof note === 'object') { diff --git a/packages/backend/src/server/api/endpoints/auth/deny.ts b/packages/backend/src/server/api/endpoints/auth/deny.ts index ca1a585c7..b3bb4ab8c 100644 --- a/packages/backend/src/server/api/endpoints/auth/deny.ts +++ b/packages/backend/src/server/api/endpoints/auth/deny.ts @@ -32,7 +32,7 @@ export default define(meta, paramDef, async (ps, user) => { token: ps.token, }); - if (result.affected == 0) { + if (result.affected === 0) { throw new ApiError(meta.errors.noSuchSession); } }); diff --git a/packages/backend/src/server/api/endpoints/notes/replies.ts b/packages/backend/src/server/api/endpoints/notes/replies.ts index 96a656ec6..4980f1410 100644 --- a/packages/backend/src/server/api/endpoints/notes/replies.ts +++ b/packages/backend/src/server/api/endpoints/notes/replies.ts @@ -37,7 +37,7 @@ export const paramDef = { // eslint-disable-next-line import/no-default-export export default define(meta, paramDef, async (ps, user) => { - const note = await getNote(ps.noteId, user).catch(err => { + await getNote(ps.noteId, user).catch(err => { if (err.id === '9725d0ce-ba28-4dde-95a7-2cbb2c15de24') throw new ApiError('NO_SUCH_NOTE'); throw err; });