Merge branch 'test-cases-mox-setup' into 'develop'

Mox mode setup tweak; refactoring

See merge request pleroma/pleroma!3263
This commit is contained in:
lain 2021-01-21 09:03:26 +00:00
commit ba40af054c
4 changed files with 19 additions and 39 deletions

View file

@ -19,7 +19,6 @@ defmodule Pleroma.Gun.ConnectionPoolTest do
:ok :ok
end end
setup :set_mox_from_context
setup :gun_mock setup :gun_mock
test "gives the same connection to 2 concurrent requests" do test "gives the same connection to 2 concurrent requests" do

View file

@ -30,19 +30,5 @@ defmodule Pleroma.Web.ChannelCase do
end end
end end
setup tags do setup tags, do: Pleroma.DataCase.setup_multi_process_mode(tags)
:ok = Ecto.Adapters.SQL.Sandbox.checkout(Pleroma.Repo)
if tags[:async] do
Mox.stub_with(Pleroma.CachexMock, Pleroma.NullCache)
Mox.set_mox_private()
else
Ecto.Adapters.SQL.Sandbox.mode(Pleroma.Repo, {:shared, self()})
Mox.stub_with(Pleroma.CachexMock, Pleroma.CachexProxy)
Mox.set_mox_global()
Pleroma.DataCase.clear_cachex()
end
:ok
end
end end

View file

@ -19,6 +19,8 @@ defmodule Pleroma.Web.ConnCase do
use ExUnit.CaseTemplate use ExUnit.CaseTemplate
alias Pleroma.DataCase
using do using do
quote do quote do
# Import conveniences for testing with connections # Import conveniences for testing with connections
@ -116,27 +118,9 @@ defmodule Pleroma.Web.ConnCase do
end end
setup tags do setup tags do
:ok = Ecto.Adapters.SQL.Sandbox.checkout(Pleroma.Repo) DataCase.setup_multi_process_mode(tags)
DataCase.setup_streamer(tags)
if tags[:async] do DataCase.stub_pipeline()
Mox.stub_with(Pleroma.CachexMock, Pleroma.NullCache)
Mox.set_mox_private()
else
Ecto.Adapters.SQL.Sandbox.mode(Pleroma.Repo, {:shared, self()})
Mox.stub_with(Pleroma.CachexMock, Pleroma.CachexProxy)
Mox.set_mox_global()
Pleroma.DataCase.clear_cachex()
end
if tags[:needs_streamer] do
start_supervised(%{
id: Pleroma.Web.Streamer.registry(),
start:
{Registry, :start_link, [[keys: :duplicate, name: Pleroma.Web.Streamer.registry()]]}
})
end
Pleroma.DataCase.stub_pipeline()
Mox.verify_on_exit!() Mox.verify_on_exit!()

View file

@ -64,7 +64,7 @@ defmodule Pleroma.DataCase do
end) end)
end end
setup tags do def setup_multi_process_mode(tags) do
:ok = Ecto.Adapters.SQL.Sandbox.checkout(Pleroma.Repo) :ok = Ecto.Adapters.SQL.Sandbox.checkout(Pleroma.Repo)
if tags[:async] do if tags[:async] do
@ -72,11 +72,16 @@ defmodule Pleroma.DataCase do
Mox.set_mox_private() Mox.set_mox_private()
else else
Ecto.Adapters.SQL.Sandbox.mode(Pleroma.Repo, {:shared, self()}) Ecto.Adapters.SQL.Sandbox.mode(Pleroma.Repo, {:shared, self()})
Mox.stub_with(Pleroma.CachexMock, Pleroma.CachexProxy)
Mox.set_mox_global() Mox.set_mox_global()
Mox.stub_with(Pleroma.CachexMock, Pleroma.CachexProxy)
clear_cachex() clear_cachex()
end end
:ok
end
def setup_streamer(tags) do
if tags[:needs_streamer] do if tags[:needs_streamer] do
start_supervised(%{ start_supervised(%{
id: Pleroma.Web.Streamer.registry(), id: Pleroma.Web.Streamer.registry(),
@ -85,6 +90,12 @@ defmodule Pleroma.DataCase do
}) })
end end
:ok
end
setup tags do
setup_multi_process_mode(tags)
setup_streamer(tags)
stub_pipeline() stub_pipeline()
Mox.verify_on_exit!() Mox.verify_on_exit!()