Update translation files

Updated by "Squash Git commits" hook in Weblate.

Translation: Pleroma fe/Akkoma Backend (Static pages)
Translate-URL: http://translate.akkoma.dev/projects/akkoma/akkoma-backend-static-pages/

.gitattributes

@@ -1,4 +1,11 @@
 *.ex diff=elixir
 *.exs diff=elixir
 
-*.css diff=css
+# Most of js/css files included in the repo are minified bundles,
+#   and we don't want to search/diff those as text files.
+*.js binary
+*.js.map binary
+*.css binary
+
+priv/static/instance/static.css diff=css
+priv/static/static-fe/static-fe.css diff=css

.gitea/issue_template/bug.yml

@@ -1,8 +1,6 @@
 name: "Bug report"
 about: "Something isn't working as expected"
 title: "[bug] "
-labels:
-- bug
 body:
   - type: markdown
     attributes:

.gitea/issue_template/feat.yml

@@ -1,9 +1,6 @@
 name: "Feature request"
 about: "I'd like something to be added to Akkoma"
 title: "[feat] "
-labels:
-- "feature request"
-
 body:
   - type: markdown
     attributes:

.gitignore

@@ -76,4 +76,3 @@ docs/site
 
 # docker stuff
 docker-db
-*.iml

CHANGELOG.md

@@ -6,41 +6,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
-### Added
-- Prometheus metrics exporting from `/api/v1/akkoma/metrics`
-- Ability to alter http pool size
-- Translation of statuses via ArgosTranslate
-- Argon2 password hashing
-- Ability to "verify" links in profile fields via rel=me
-- Mix tasks to dump/load config to/from json for bulk editing
-- Followed hashtag list at /api/v1/followed\_tags, API parity with mastodon
-
-### Removed
-- Non-finch HTTP adapters
-- Legacy redirect from /api/pleroma/admin to /api/v1/pleroma/admin
-- Legacy redirects from /api/pleroma to /api/v1/pleroma
-- :crypt dependency
-
-### Changed
-- Return HTTP error 413 when uploading an avatar or banner that's above the configured upload limit instead of a 500.
-- Non-admin users now cannot register `admin` scope tokens (not security-critical, they didn't work before, but you _could_ create them)
-  - Admin scopes will be dropped on create
-- Rich media will now backoff for 20 minutes after a failure
-- Quote posts are now considered as part of the same thread as the post they are quoting
-- Simplified HTTP signature processing
-- Rich media will now hard-exit after 5 seconds, to prevent timeline hangs
-- HTTP Content Security Policy is now far more strict to prevent any potential XSS/CSS leakages
-
-### Fixed 
-- /api/v1/accounts/lookup will now respect restrict\_unauthenticated
-- Unknown atoms in the config DB will no longer crash akkoma on boot
-
-### Upgrade notes
-- Ensure `config :tesla, :adapter` is either unset, or set to `{Tesla.Adapter.Finch, name: MyFinch}` in your .exs config
-- Pleroma-FE will need to be updated to handle the new /api/v1/pleroma endpoints for  custom emoji
-
-## 2022.12
-
 ## Added
 - Config: HTTP timeout options, :pool\_timeout and :receive\_timeout
 - Added statistic gathering about instances which do/don't have signed fetches when they request from us

Dockerfile

@@ -1,7 +1,6 @@
 FROM hexpm/elixir:1.13.4-erlang-24.3.4.5-alpine-3.15.6
 
 ENV MIX_ENV=prod
-ENV ERL_EPMD_ADDRESS=127.0.0.1
 
 ARG HOME=/opt/akkoma
 

config/config.exs

@@ -163,6 +163,11 @@
   format: "$metadata[$level] $message",
   metadata: [:request_id]
 
+config :quack,
+  level: :warn,
+  meta: [:all],
+  webhook_url: "https://hooks.slack.com/services/YOUR-KEY-HERE"
+
 config :mime, :types, %{
   "application/xml" => ["xml"],
   "application/xrd+xml" => ["xrd+xml"],
@@ -179,7 +184,6 @@
   receive_timeout: :timer.seconds(15),
   proxy_url: nil,
   user_agent: :default,
-  pool_size: 50,
   adapter: []
 
 config :pleroma, :instance,
@@ -260,8 +264,7 @@
   profile_directory: true,
   privileged_staff: false,
   local_bubble: [],
-  max_frontend_settings_json_chars: 100_000,
+  max_frontend_settings_json_chars: 100_000
-  export_prometheus_metrics: true
 
 config :pleroma, :welcome,
   direct_message: [
@@ -426,7 +429,7 @@
     Pleroma.Web.RichMedia.Parsers.TwitterCard,
     Pleroma.Web.RichMedia.Parsers.OEmbed
   ],
-  failure_backoff: :timer.minutes(20),
+  failure_backoff: 60_000,
   ttl_setters: [Pleroma.Web.RichMedia.Parser.TTL.AwsSignedUrl]
 
 config :pleroma, :media_proxy,
@@ -652,10 +655,6 @@
 
 config :pleroma, Pleroma.Emails.Mailer, adapter: Swoosh.Adapters.Sendmail, enabled: false
 
-config :swoosh,
-  api_client: Swoosh.ApiClient.Finch,
-  finch_name: MyFinch
-
 config :pleroma, Pleroma.Emails.UserEmail,
   logo: nil,
   styling: %{
@@ -783,6 +782,14 @@
         "https://akkoma-updates.s3-website.fr-par.scw.cloud/frontend/${ref}/admin-fe.zip",
       "ref" => "stable"
     },
+    "soapbox-fe" => %{
+      "name" => "soapbox-fe",
+      "git" => "https://gitlab.com/soapbox-pub/soapbox",
+      "build_url" =>
+        "https://gitlab.com/soapbox-pub/soapbox/-/jobs/artifacts/${ref}/download?job=build-production",
+      "ref" => "v2.0.0",
+      "build_dir" => "static"
+    },
     # For developers - enables a swagger frontend to view the openapi spec
     "swagger-ui" => %{
       "name" => "swagger-ui",
@@ -882,11 +889,6 @@
   url: "http://127.0.0.1:5000",
   api_key: nil
 
-config :pleroma, :argos_translate,
-  command_argos_translate: "argos-translate",
-  command_argospm: "argospm",
-  strip_html: true
-
 # Import environment specific config. This must remain at the bottom
 # of this file so it overrides the configuration defined above.
 import_config "#{Mix.env()}.exs"

config/description.exs

@@ -964,11 +964,6 @@
         type: {:list, :string},
         description:
           "List of instances that make up your local bubble (closely-related instances). Used to populate the 'bubble' timeline (domain only)."
-      },
-      %{
-        key: :export_prometheus_metrics,
-        type: :boolean,
-        description: "Enable prometheus metrics (at /api/v1/akkoma/metrics)"
       }
     ]
   },
@@ -1123,6 +1118,45 @@
       }
     ]
   },
+  %{
+    group: :quack,
+    type: :group,
+    label: "Quack Logger",
+    description: "Quack-related settings",
+    children: [
+      %{
+        key: :level,
+        type: {:dropdown, :atom},
+        description: "Log level",
+        suggestions: [:debug, :info, :warn, :error]
+      },
+      %{
+        key: :meta,
+        type: {:list, :atom},
+        description: "Configure which metadata you want to report on",
+        suggestions: [
+          :application,
+          :module,
+          :file,
+          :function,
+          :line,
+          :pid,
+          :crash_reason,
+          :initial_call,
+          :registered_name,
+          :all,
+          :none
+        ]
+      },
+      %{
+        key: :webhook_url,
+        label: "Webhook URL",
+        type: :string,
+        description: "Configure the Slack incoming webhook",
+        suggestions: ["https://hooks.slack.com/services/YOUR-KEY-HERE"]
+      }
+    ]
+  },
   %{
     group: :pleroma,
     key: :frontend_configurations,
@@ -2661,12 +2695,6 @@
           "What user agent to use. Must be a string or an atom `:default`. Default value is `:default`.",
         suggestions: ["Pleroma", :default]
       },
-      %{
-        key: :pool_size,
-        type: :integer,
-        description: "Number of concurrent outbound HTTP requests to allow. Default 50.",
-        suggestions: [50]
-      },
       %{
         key: :adapter,
         type: :keyword,
@@ -3442,32 +3470,5 @@
         suggestion: [nil]
       }
     ]
-  },
-  %{
-    group: :pleroma,
-    key: :argos_translate,
-    type: :group,
-    description: "ArgosTranslate Settings.",
-    children: [
-      %{
-        key: :command_argos_translate,
-        type: :string,
-        description:
-          "command for `argos-translate`. Can be the command if it's in your PATH, or the full path to the file.",
-        suggestion: ["argos-translate"]
-      },
-      %{
-        key: :command_argospm,
-        type: :string,
-        description:
-          "command for `argospm`. Can be the command if it's in your PATH, or the full path to the file.",
-        suggestion: ["argospm"]
-      },
-      %{
-        key: :strip_html,
-        type: :boolean,
-        description: "Strip html from the post before translating it."
-      }
-    ]
   }
 ]

docker-resources/env.example

@@ -1,5 +1,4 @@
 MIX_ENV=prod
-ERL_EPMD_ADDRESS=127.0.0.1
 DB_NAME=akkoma
 DB_USER=akkoma
 DB_PASS=akkoma

docs/docs/administration/CLI_tasks/config.md

@@ -155,51 +155,3 @@ This forcibly removes all saved values in the database.
     ```sh
     mix pleroma.config [--force] reset
     ```
-
-## Dumping specific configuration values to JSON
-
-If you want to bulk-modify configuration values (for example, for MRF modifications),
-it may be easier to dump the values to JSON and then modify them in a text editor.
-
-=== "OTP"
-
-    ```sh
-    ./bin/pleroma_ctl config dump_to_file group key path
-    # For example, to dump the MRF simple configuration:
-    ./bin/pleroma_ctl config dump_to_file pleroma mrf_simple /tmp/mrf_simple.json
-    ```
-
-=== "From Source"
-
-    ```sh
-    mix pleroma.config dump_to_file group key path 
-    # For example, to dump the MRF simple configuration:
-    mix pleroma.config dump_to_file pleroma mrf_simple /tmp/mrf_simple.json
-    ```
-
-## Loading specific configuration values from JSON
-
-**Note:** This will overwrite any existing value in the database, and can
-cause crashes if you do not have exactly the correct formatting.
-
-Once you have modified the JSON file, you can load it back into the database.
-
-=== "OTP"
-
-    ```sh
-    ./bin/pleroma_ctl config load_from_file path
-    # For example, to load the MRF simple configuration:
-    ./bin/pleroma_ctl config load_from_file /tmp/mrf_simple.json
-    ```
-
-=== "From Source"
-
-    ```sh
-    mix pleroma.config load_from_file path
-    # For example, to load the MRF simple configuration:
-    mix pleroma.config load_from_file /tmp/mrf_simple.json
-    ```
-
-**NOTE** an instance reboot is needed for many changes to take effect,
-you may want to visit `/api/v1/pleroma/admin/restart` on your instance
-to soft-restart the instance.

docs/docs/administration/CLI_tasks/frontend.md

@@ -21,23 +21,24 @@ Currently, known `<frontend>` values are:
 - [admin-fe](https://akkoma.dev/AkkomaGang/admin-fe)
 - [mastodon-fe](https://akkoma.dev/AkkomaGang/masto-fe)
 - [pleroma-fe](https://akkoma.dev/AkkomaGang/pleroma-fe)
+- [soapbox-fe](https://gitlab.com/soapbox-pub/soapbox-fe)
 
 You can still install frontends that are not configured, see below.
 
-## Example installations for a known frontend (Stable-Version)
+## Example installations for a known frontend
 
 For a frontend configured under the `available` key, it's enough to install it by name.
 
 === "OTP"
 
     ```sh
-    ./bin/pleroma_ctl frontend install pleroma-fe --ref stable
+    ./bin/pleroma_ctl frontend install pleroma-fe
     ```
 
 === "From Source"
 
     ```sh
-    mix pleroma.frontend install pleroma-fe --ref stable
+    mix pleroma.frontend install pleroma-fe
     ```
 
 This will download the latest build for the pre-configured `ref` and install it. It can then be configured as the one of the served frontends in the config file (see `primary` or `admin`).

docs/docs/administration/CLI_tasks/robots_txt.md

@@ -11,11 +11,11 @@ If you want to generate a restrictive `robots.txt`, you can run the following mi
 === "OTP"
 
     ```sh
-    ./bin/pleroma_ctl robotstxt disallow_all
+    ./bin/pleroma_ctl robots_txt disallow_all
     ```
 
 === "From Source"
 
     ```sh
-    mix pleroma.robotstxt disallow_all
+    mix pleroma.robots_txt disallow_all
     ```

docs/docs/administration/monitoring.md

@@ -1,33 +0,0 @@
-# Monitoring Akkoma
-
-If you run akkoma, you may be inclined to collect metrics to ensure your instance is running smoothly,
-and that there's nothing quietly failing in the background.
-
-To facilitate this, akkoma exposes prometheus metrics to be scraped.
-
-## Prometheus
-
-See: [export\_prometheus\_metrics](../../configuration/cheatsheet#instance)
-
-To scrape prometheus metrics, we need an oauth2 token with the `admin:metrics` scope.
-
-consider using [constanze](https://akkoma.dev/AkkomaGang/constanze) to make this easier -
-
-```bash
-constanze token --client-app --scopes "admin:metrics" --client-name "Prometheus"
-```
-
-or see `scripts/create_metrics_app.sh` in the source tree for the process to get this token.
-
-Once you have your token of the form `Bearer $ACCESS_TOKEN`, you can use that in your prometheus config:
-
-```yaml
-- job_name: akkoma
-  scheme: https
-  authorization:
-    credentials: $ACCESS_TOKEN # this should have the bearer prefix removed
-  metrics_path: /api/v1/akkoma/metrics
-  static_configs:
-  - targets:
-    - example.com
-```

docs/docs/administration/updating.md

@@ -1,36 +1,17 @@
 # Updating your instance
 
-You should **always check the [release notes/changelog](https://akkoma.dev/AkkomaGang/akkoma/src/branch/stable/CHANGELOG.md)** in case there are config deprecations, special update steps, etc.
+You should **always check the [release notes/changelog](https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/CHANGELOG.md)** in case there are config deprecations, special update steps, etc.
 
 Besides that, doing the following is generally enough:
-## Switch to the akkoma user
-```sh
-# Using sudo
-sudo -su akkoma
-
-# Using doas
-doas -su akkoma
-
-# Using su
-su -s "$SHELL" akkoma
-```
 
 ## For OTP installations
+
 ```sh
-# Download latest stable release
+# Download the new release
-./bin/pleroma_ctl update --branch stable
+su akkoma -s $SHELL -lc "./bin/pleroma_ctl update" 
 
-# Stop akkoma
+# Migrate the database, you are advised to stop the instance before doing that
-./bin/pleroma stop # or using the system service manager (e.g. systemctl stop akkoma)
+su akkoma -s $SHELL -lc "./bin/pleroma_ctl migrate"
-
-# Run database migrations
-./bin/pleroma_ctl migrate
-
-# Update frontend(s). See Frontend Configuration doc for more information.
-./bin/pleroma_ctl frontend install pleroma-fe --ref stable
-
-# Start akkoma
-./bin/pleroma daemon # or using the system service manager (e.g. systemctl start akkoma)
 ```
 
 If you selected an alternate flavour on installation, 
@@ -38,30 +19,13 @@ you _may_ need to specify `--flavour`, in the same way as
 [when installing](../../installation/otp_en#detecting-flavour).
 
 ## For from source installations (using git)
-Run as the `akkoma` user:
 
-```sh
+1. Go to the working directory of Akkoma (default is `/opt/akkoma`)
-# fetch changes
+2. Run `git pull` [^1]. This pulls the latest changes from upstream.
-git fetch
+3. Run `mix deps.get` [^1]. This pulls in any new dependencies.
-# check out the latest tag
+4. Stop the Akkoma service.
-git checkout $(git tag -l | grep -v 'rc[0-9]*$' | sort -V | tail -n 1)
+5. Run `mix ecto.migrate` [^1] [^2]. This task performs database migrations, if there were any.
+6. Start the Akkoma service.
 
-# Run with production configuration
+[^1]: Depending on which install guide you followed (for example on Debian/Ubuntu), you want to run `git` and `mix` tasks as `akkoma` user by adding `sudo -Hu akkoma` before the command.
-export MIX_ENV=prod
+[^2]: Prefix with `MIX_ENV=prod` to run it using the production config file.
-
-# Download and compile dependencies
-mix deps.get
-mix compile
-
-# Stop akkoma (replace with your system service manager's equivalent if different)
-sudo systemctl stop akkoma
-
-# Run database migrations
-mix ecto.migrate
-
-# Update Pleroma-FE frontend to latest stable. For other Frontends see Frontend Configration doc for more information.
-mix pleroma.frontend install pleroma-fe --ref stable
-
-# Start akkoma (replace with your system service manager's equivalent if different)
-sudo systemctl start akkoma
-```

docs/docs/configuration/cheatsheet.md

@@ -62,7 +62,6 @@ To add configuration to your config file, you can copy it from the base config.
 * `password_reset_token_validity`: The time after which reset tokens aren't accepted anymore, in seconds (default: one day).
 * `local_bubble`: Array of domains representing instances closely related to yours. Used to populate the `bubble` timeline. e.g `["example.com"]`, (default: `[]`)
 * `languages`: List of Language Codes used by the instance. This is used to try and set a default language from the frontend. It will try and find the first match between the languages set here and the user's browser languages. It will default to the first language in this setting if there is no match.. (default `["en"]`)
-* `export_prometheus_metrics`: Enable prometheus metrics, served at `/api/v1/akkoma/metrics`, requiring the `admin:metrics` oauth scope.
 
 ## :database
 * `improved_hashtag_timeline`: Setting to force toggle / force disable improved hashtags timeline. `:enabled` forces hashtags to be fetched from `hashtags` table for hashtags timeline. `:disabled` forces object-embedded hashtags to be used (slower). Keep it `:auto` for automatic behaviour (it is auto-set to `:enabled` [unless overridden] when HashtagsTableMigrator completes).
@@ -529,6 +528,54 @@ Available caches:
 * `user_agent`: what user agent should we use? (default: `:default`), must be string or `:default`
 * `adapter`: array of adapter options
 
+### :hackney_pools
+
+Advanced. Tweaks Hackney (http client) connections pools.
+
+There's three pools used:
+
+* `:federation` for the federation jobs.
+  You may want this pool max_connections to be at least equal to the number of federator jobs + retry queue jobs.
+* `:media` for rich media, media proxy
+* `:upload` for uploaded media (if using a remote uploader and `proxy_remote: true`)
+
+For each pool, the options are:
+
+* `max_connections` - how much connections a pool can hold
+* `timeout` - retention duration for connections
+
+
+### :connections_pool
+
+*For `gun` adapter*
+
+Settings for HTTP connection pool.
+
+* `:connection_acquisition_wait` - Timeout to acquire a connection from pool.The total max time is this value multiplied by the number of retries.
+* `connection_acquisition_retries` - Number of attempts to acquire the connection from the pool if it is overloaded. Each attempt is timed `:connection_acquisition_wait` apart.
+* `:max_connections` - Maximum number of connections in the pool.
+* `:connect_timeout` - Timeout to connect to the host.
+* `:reclaim_multiplier` - Multiplied by `:max_connections` this will be the maximum number of idle connections that will be reclaimed in case the pool is overloaded.
+
+### :pools
+
+*For `gun` adapter*
+
+Settings for request pools. These pools are limited on top of `:connections_pool`.
+
+There are four pools used:
+
+* `:federation` for the federation jobs. You may want this pool's max_connections to be at least equal to the number of federator jobs + retry queue jobs.
+* `:media` - for rich media, media proxy.
+* `:upload` - for proxying media when a remote uploader is used and `proxy_remote: true`.
+* `:default` - for other requests.
+
+For each pool, the options are:
+
+* `:size` - limit to how much requests can be concurrently executed.
+* `:recv_timeout` - timeout while `gun` will wait for response
+* `:max_waiting` - limit to how much requests can be waiting for others to finish, after this is reached, subsequent requests will be dropped.
+
 ## Captcha
 
 ### Pleroma.Captcha
@@ -786,8 +833,17 @@ config :logger, :ex_syslogger,
   level: :info,
   ident: "pleroma",
   format: "$metadata[$level] $message"
+
+config :quack,
+  level: :warn,
+  meta: [:all],
+  webhook_url: "https://hooks.slack.com/services/YOUR-API-KEY-HERE"
 ```
 
+See the [Quack Github](https://github.com/azohra/quack) for more details
+
+
+
 ## Database options
 
 ### RUM indexing for full text search
@@ -1119,7 +1175,7 @@ Each job has these settings:
 ### Translation Settings
 
 Settings to automatically translate statuses for end users. Currently supported
-translation services are DeepL and LibreTranslate. The supported command line tool is [Argos Translate](https://github.com/argosopentech/argos-translate).
+translation services are DeepL and LibreTranslate.
 
 Translations are available at `/api/v1/statuses/:id/translations/:language`, where
 `language` is the target language code (e.g `en`)
@@ -1128,7 +1184,7 @@ Translations are available at `/api/v1/statuses/:id/translations/:language`, whe
 
 - `:enabled` - enables translation
 - `:module` - Sets module to be used
-  - Either `Pleroma.Akkoma.Translators.DeepL`, `Pleroma.Akkoma.Translators.LibreTranslate`, or `Pleroma.Akkoma.Translators.ArgosTranslate`
+  - Either `Pleroma.Akkoma.Translators.DeepL` or `Pleroma.Akkoma.Translators.LibreTranslate`
 
 ### `:deepl`
 
@@ -1140,9 +1196,3 @@ Translations are available at `/api/v1/statuses/:id/translations/:language`, whe
 
 - `:url` - URL of LibreTranslate instance
 - `:api_key` - API key for LibreTranslate
-
-### `:argos_translate`
-
-- `:command_argos_translate` - command for `argos-translate`. Can be the command if it's in your PATH, or the full path to the file  (default: `argos-translate`).
-- `:command_argospm` - command for `argospm`. Can be the command if it's in your PATH, or the full path to the file (default: `argospm`).
-- `:strip_html` - Strip html from the post before translating it (default: `true`).

docs/docs/configuration/custom_emoji.md

@@ -67,29 +67,3 @@ Priority of tags assigns in emoji.txt and custom.txt:
 Priority for globs:
 
 `special group setting in config.exs > default setting in config.exs`
-
-## Stealing emoji
-
-Managing your emoji can be hard work, and you just want to have the cool emoji your friends use? As usual, crime comes to the rescue!
-
-You can use the `Pleroma.Web.ActivityPub.MRF.StealEmojiPolicy` [Message Rewrite Facility](../configuration/cheatsheet.md#mrf) to automatically add to your instance emoji that messages from specific servers contain. Note that this happens on message processing, so the emoji will be added only after your instance receives some interaction containing emoji _after_ configuring this.
-
-To activate this you have to [configure](../configuration/cheatsheet.md#mrf_steal_emoji) it in your configuration file. For example if you wanted to steal any emoji that is not related to cinnamon and not larger than about 10K from `coolemoji.space` and `spiceenthusiasts.biz`, you would add the following:
-```elixir
-config :pleroma, :mrf,
-  policies: [
-    Pleroma.Web.ActivityPub.MRF.StealEmojiPolicy
-  ]
-
-config :pleroma, :mrf_steal_emoji,
-  hosts: [
-    "coolemoji.space",
-    "spiceenthusiasts.biz"
-  ],
-  rejected_shortcodes: [
-    ".*cinnamon.*"
-  ],
-  size_limit: 10000
-```
-
-Note that this may not obey emoji licensing restrictions. It's extremely unlikely that anyone will care, but keep this in mind for when Nintendo starts their own instance.

docs/docs/development/API/admin_api.md

@@ -1056,13 +1056,14 @@ Most of the settings will be applied in `runtime`, this means that you don't nee
 
 Example of setting without keyword in value:
 ```elixir
-config :tesla, :adapter, {Tesla.Adapter.Finch, name: MyFinch}
+config :tesla, :adapter, Tesla.Adapter.Hackney
 ```
 
 List of settings which support only full update by key:
 ```elixir
 @full_key_update [
     {:pleroma, :ecto_repos},
+    {:quack, :meta},
     {:mime, :types},
     {:cors_plug, [:max_age, :methods, :expose, :headers]},
     {:auto_linker, :opts},
@@ -1082,6 +1083,22 @@ List of settings which support only full update by subkey:
   ]
 ```
 
+*Settings without explicit key must be sended in separate config object params.*
+```elixir
+config :quack,
+  level: :debug,
+  meta: [:all],
+  ...
+```
+```json
+{
+  "configs": [
+    {"group": ":quack", "key": ":level", "value": ":debug"},
+    {"group": ":quack", "key": ":meta", "value": [":all"]},
+    ...
+  ]
+}
+```
 - Request:
 
 ```json

docs/docs/installation/alpine_linux_en.md

@@ -84,12 +84,12 @@ doas adduser -S -s /bin/false -h /opt/akkoma -H -G akkoma akkoma
 
 **Note**: To execute a single command as the Akkoma system user, use `doas -u akkoma command`. You can also switch to a shell by using `doas -su akkoma`. If you don’t have and want `doas` on your system, you can use `su` as root user (UID 0) for a single command by using `su -l akkoma -s $SHELL -c 'command'` and `su -l akkoma -s $SHELL` for starting a shell.
 
-* Git clone the AkkomaBE repository from stable-branch and make the Akkoma user the owner of the directory:
+* Git clone the AkkomaBE repository and make the Akkoma user the owner of the directory:
 
 ```shell
 doas mkdir -p /opt/akkoma
 doas chown -R akkoma:akkoma /opt/akkoma
-doas -u akkoma git clone https://akkoma.dev/AkkomaGang/akkoma.git -b stable /opt/akkoma
+doas -u akkoma git clone https://akkoma.dev/AkkomaGang/akkoma.git /opt/akkoma
 ```
 
 * Change to the new directory:
@@ -109,7 +109,7 @@ doas -u akkoma mix deps.get
   * This may take some time, because parts of akkoma get compiled first.
   * After that it will ask you a few questions about your instance and generates a configuration file in `config/generated_config.exs`.
 
-* Check the configuration and if all looks right, rename it, so Akkoma will load it (`prod.secret.exs` for productive instances):
+* Check the configuration and if all looks right, rename it, so Akkoma will load it (`prod.secret.exs` for productive instance, `dev.secret.exs` for development instances):
 
 ```shell
 doas -u akkoma mv config/{generated_config.exs,prod.secret.exs}

docs/docs/installation/arch_linux_en.md

@@ -75,12 +75,12 @@ sudo useradd -r -s /bin/false -m -d /var/lib/akkoma -U akkoma
 
 **Note**: To execute a single command as the Akkoma system user, use `sudo -Hu akkoma command`. You can also switch to a shell by using `sudo -Hu akkoma $SHELL`. If you don’t have and want `sudo` on your system, you can use `su` as root user (UID 0) for a single command by using `su -l akkoma -s $SHELL -c 'command'` and `su -l akkoma -s $SHELL` for starting a shell.
 
-* Git clone the AkkomaBE repository from stable-branch and make the Akkoma user the owner of the directory:
+* Git clone the AkkomaBE repository and make the Akkoma user the owner of the directory:
 
 ```shell
 sudo mkdir -p /opt/akkoma
 sudo chown -R akkoma:akkoma /opt/akkoma
-sudo -Hu akkoma git clone https://akkoma.dev/AkkomaGang/akkoma.git -b stable /opt/akkoma
+sudo -Hu akkoma git clone https://akkoma.dev/AkkomaGang/akkoma.git /opt/akkoma
 ```
 
 * Change to the new directory:
@@ -100,7 +100,7 @@ sudo -Hu akkoma mix deps.get
   * This may take some time, because parts of akkoma get compiled first.
   * After that it will ask you a few questions about your instance and generates a configuration file in `config/generated_config.exs`.
 
-* Check the configuration and if all looks right, rename it, so Akkoma will load it (`prod.secret.exs` for productive instances):
+* Check the configuration and if all looks right, rename it, so Akkoma will load it (`prod.secret.exs` for productive instance, `dev.secret.exs` for development instances):
 
 ```shell
 sudo -Hu akkoma mv config/{generated_config.exs,prod.secret.exs}

docs/docs/installation/debian_based_en.md

@@ -49,12 +49,12 @@ sudo useradd -r -s /bin/false -m -d /var/lib/akkoma -U akkoma
 
 **Note**: To execute a single command as the Akkoma system user, use `sudo -Hu akkoma command`. You can also switch to a shell by using `sudo -Hu akkoma $SHELL`. If you don’t have and want `sudo` on your system, you can use `su` as root user (UID 0) for a single command by using `su -l akkoma -s $SHELL -c 'command'` and `su -l akkoma -s $SHELL` for starting a shell.
 
-* Git clone the AkkomaBE repository from stable-branch and make the Akkoma user the owner of the directory:
+* Git clone the AkkomaBE repository and make the Akkoma user the owner of the directory:
 
 ```shell
 sudo mkdir -p /opt/akkoma
 sudo chown -R akkoma:akkoma /opt/akkoma
-sudo -Hu akkoma git clone https://akkoma.dev/AkkomaGang/akkoma.git -b stable /opt/akkoma
+sudo -Hu akkoma git clone https://akkoma.dev/AkkomaGang/akkoma.git /opt/akkoma
 ```
 
 * Change to the new directory:
@@ -74,7 +74,7 @@ sudo -Hu akkoma mix deps.get
   * This may take some time, because parts of akkoma get compiled first.
   * After that it will ask you a few questions about your instance and generates a configuration file in `config/generated_config.exs`.
 
-* Check the configuration and if all looks right, rename it, so Akkoma will load it (`prod.secret.exs` for productive instances):
+* Check the configuration and if all looks right, rename it, so Akkoma will load it (`prod.secret.exs` for productive instance, `dev.secret.exs` for development instances):
 
 ```shell
 sudo -Hu akkoma mv config/{generated_config.exs,prod.secret.exs}

docs/docs/installation/fedora_based_en.md

@@ -30,10 +30,11 @@ sudo dnf install git gcc g++ make cmake file-devel postgresql-server postgresql-
 
 * Enable and initialize Postgres:
 ```shell
+sudo systemctl enable postgresql.service
 sudo postgresql-setup --initdb --unit postgresql
 # Allow password auth for postgres
 sudo sed -E -i 's|(host +all +all +127.0.0.1/32 +)ident|\1md5|' /var/lib/pgsql/data/pg_hba.conf
-sudo systemctl enable --now postgresql.service
+sudo systemctl start postgresql.service
 ```
 
 ### Install Elixir and Erlang
@@ -58,7 +59,7 @@ sudo dnf install ffmpeg
 * Install ImageMagick and ExifTool for image manipulation:
 
 ```shell
-sudo dnf install ImageMagick perl-Image-ExifTool
+sudo dnf install Imagemagick perl-Image-ExifTool
 ```
 
 
@@ -73,12 +74,12 @@ sudo useradd -r -s /bin/false -m -d /var/lib/akkoma -U akkoma
 
 **Note**: To execute a single command as the Akkoma system user, use `sudo -Hu akkoma command`. You can also switch to a shell by using `sudo -Hu akkoma $SHELL`. If you don’t have and want `sudo` on your system, you can use `su` as root user (UID 0) for a single command by using `su -l akkoma -s $SHELL -c 'command'` and `su -l akkoma -s $SHELL` for starting a shell.
 
-* Git clone the AkkomaBE repository from stable-branch and make the Akkoma user the owner of the directory:
+* Git clone the AkkomaBE repository and make the Akkoma user the owner of the directory:
 
 ```shell
 sudo mkdir -p /opt/akkoma
 sudo chown -R akkoma:akkoma /opt/akkoma
-sudo -Hu akkoma git clone https://akkoma.dev/AkkomaGang/akkoma.git -b stable /opt/akkoma
+sudo -Hu akkoma git clone https://akkoma.dev/AkkomaGang/akkoma.git /opt/akkoma
 ```
 
 * Change to the new directory:
@@ -98,7 +99,7 @@ sudo -Hu akkoma mix deps.get
   * This may take some time, because parts of akkoma get compiled first.
   * After that it will ask you a few questions about your instance and generates a configuration file in `config/generated_config.exs`.
 
-* Check the configuration and if all looks right, rename it, so Akkoma will load it (`prod.secret.exs` for productive instances):
+* Check the configuration and if all looks right, rename it, so Akkoma will load it (`prod.secret.exs` for productive instance, `dev.secret.exs` for development instances):
 
 ```shell
 sudo -Hu akkoma mv config/{generated_config.exs,prod.secret.exs}

docs/docs/installation/otp_en.md

@@ -118,8 +118,8 @@ Restart PostgreSQL to apply configuration changes:
 adduser --system --shell  /bin/false --home /opt/akkoma akkoma
 
 # Set the flavour environment variable to the string you got in Detecting flavour section.
-# For example if the flavour is `amd64` the command will be
+# For example if the flavour is `amd64-musl` the command will be
-export FLAVOUR="amd64"
+export FLAVOUR="amd64-musl"
 
 # Clone the release build into a temporary directory and unpack it
 su akkoma -s $SHELL -lc "

docs/docs/installation/otp_redhat_en.md

@@ -37,7 +37,7 @@ sudo dnf install git gcc g++ erlang elixir erlang-os_mon erlang-eldap erlang-xme
 
 ```shell
 cd ~
-git clone https://akkoma.dev/AkkomaGang/akkoma.git -b stable
+git clone https://akkoma.dev/AkkomaGang/akkoma.git
 ```
 
 * Change to the new directory:

docs/docs/installation/verifying_otp_releases.md

@@ -12,7 +12,7 @@ Release URLs will always be of the form
 https://akkoma-updates.s3-website.fr-par.scw.cloud/{branch}/akkoma-{flavour}.zip
 ```
 
-Where branch is usually `stable` and `flavour` is
+Where branch is usually `stable` or `develop`, and `flavour` is
 the one [that you detect on install](../otp_en/#detecting-flavour).
 
 So, for an AMD64 stable install, your update URL will be

docs/mkdocs.yml

@@ -12,19 +12,6 @@ theme:
     - navigation.instant
     - navigation.sections
   palette:
-    - media: "(prefers-color-scheme: light)"
-      scheme: default
-      toggle:
-        icon: material/brightness-7
-        name: Switch to dark mode
-      primary: 'deep purple'
-      accent: 'blue grey'
-
-    - media: "(prefers-color-scheme: dark)"
-      scheme: slate
-      toggle:
-        icon: material/brightness-4
-        name: Switch to light mode
     primary: 'deep purple'
     accent: 'blue grey'
 

installation/akkoma.service

@@ -4,6 +4,7 @@ After=network.target postgresql.service
 
 [Service]
 ExecReload=/bin/kill $MAINPID
+KillMode=process
 Restart=on-failure
 
 ; Uncomment this if you're on Arch Linux
@@ -14,9 +15,6 @@ User=akkoma
 ; Declares that Akkoma runs in production mode.
 Environment="MIX_ENV=prod"
 
-; Don't listen epmd on 0.0.0.0
-Environment="ERL_EPMD_ADDRESS=127.0.0.1"
-
 ; Make sure that all paths fit your installation.
 ; Path to the home directory of the user running the Akkoma service.
 Environment="HOME=/var/lib/akkoma"

installation/akkoma.supervisord

@@ -12,8 +12,7 @@ environment =
   HOME=/home/akkoma,
   USER=akkoma,
   PATH="/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/akkoma/bin:%(ENV_PATH)s",
-  PWD=/home/akkoma/akkoma,
+  PWD=/home/akkoma/akkoma
-  ERL_EPMD_ADDRESS=127.0.0.1
 stdout_logfile=/home/akkoma/logs/stdout.log
 stdout_logfile_maxbytes=50MB
 stdout_logfile_backups=10

installation/freebsd/rc.d/akkoma

@@ -18,8 +18,7 @@ load_rc_config ${name}
 : ${akkoma_user:=akkoma}
 : ${akkoma_home:=$(getent passwd ${akkoma_user} | awk -F: '{print $6}')}
 : ${akkoma_chdir:="${akkoma_home}/akkoma"}
-: ${akkoma_env:="HOME=${akkoma_home} MIX_ENV=prod ERL_EPMD_ADDRESS=127.0.0.1"}
+: ${akkoma_env:="HOME=${akkoma_home} MIX_ENV=prod"}
-
 
 command=/usr/local/bin/elixir
 command_args="--erl \"-detached\" -S /usr/local/bin/mix phx.server"

installation/init.d/akkoma

@@ -31,7 +31,6 @@ else
 fi
 
 export MIX_ENV=prod
-export ERL_EPMD_ADDRESS=127.0.0.1
 
 depend() {
 	need nginx postgresql

installation/netbsd/rc.d/akkoma

@@ -14,7 +14,7 @@ start_precmd="ulimit -n unlimited"
 pidfile="/dev/null"
 
 akkoma_chdir="${akkoma_home}/akkoma"
-akkoma_env="HOME=${akkoma_home} MIX_ENV=prod ERL_EPMD_ADDRESS=127.0.0.1"
+akkoma_env="HOME=${akkoma_home} MIX_ENV=prod"
 
 check_pidfile()
 {

installation/nginx/akkoma.nginx

@@ -54,6 +54,8 @@ server {
     ssl_protocols TLSv1.2 TLSv1.3;
     ssl_ciphers "ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:!aNULL:!eNULL:!EXPORT:!DES:!MD5:!PSK:!RC4";
     ssl_prefer_server_ciphers off;
+    # In case of an old server with an OpenSSL version of 1.0.2 or below,
+    # leave only prime256v1 or comment out the following line.
     ssl_ecdh_curve X25519:prime256v1:secp384r1:secp521r1;
     ssl_stapling on;
     ssl_stapling_verify on;

lib/mix/tasks/pleroma/activity.ex

@@ -1,4 +1,3 @@
-# credo:disable-for-this-file
 # Pleroma: A lightweight social networking server
 # Copyright © 2017-2018 Pleroma Authors <https://pleroma.social/>
 # SPDX-License-Identifier: AGPL-3.0-only

lib/mix/tasks/pleroma/config.ex

@@ -79,45 +79,6 @@ def run(["dump", group]) do
     end)
   end
 
-  def run(["dump_to_file", group, key, fname]) do
-    check_configdb(fn ->
-      start_pleroma()
-
-      group = maybe_atomize(group)
-      key = maybe_atomize(key)
-
-      config = ConfigDB.get_by_group_and_key(group, key)
-
-      json =
-        %{
-          group: ConfigDB.to_json_types(config.group),
-          key: ConfigDB.to_json_types(config.key),
-          value: ConfigDB.to_json_types(config.value)
-        }
-        |> Jason.encode!()
-        |> Jason.Formatter.pretty_print()
-
-      File.write(fname, json)
-      shell_info("Wrote #{group}_#{key}.json")
-    end)
-  end
-
-  def run(["load_from_file", fname]) do
-    check_configdb(fn ->
-      start_pleroma()
-
-      json = File.read!(fname)
-      config = Jason.decode!(json)
-      group = ConfigDB.to_elixir_types(config["group"])
-      key = ConfigDB.to_elixir_types(config["key"])
-      value = ConfigDB.to_elixir_types(config["value"])
-      params = %{group: group, key: key, value: value}
-
-      ConfigDB.update_or_create(params)
-      shell_info("Loaded #{config["group"]}, #{config["key"]}")
-    end)
-  end
-
   def run(["groups"]) do
     check_configdb(fn ->
       start_pleroma()

lib/mix/tasks/pleroma/database.ex

@@ -115,6 +115,7 @@ def run(["prune_task"]) do
 
     nil
     |> Pleroma.Workers.Cron.PruneDatabaseWorker.perform()
+    |> IO.inspect()
   end
 
   def run(["fix_likes_collections"]) do

lib/mix/tasks/pleroma/diagnostics.ex

@@ -1,4 +1,3 @@
-# credo:disable-for-this-file
 defmodule Mix.Tasks.Pleroma.Diagnostics do
   alias Pleroma.Repo
   alias Pleroma.User
@@ -10,13 +9,6 @@ defmodule Mix.Tasks.Pleroma.Diagnostics do
   import Ecto.Query
   use Mix.Task
 
-  def run(["http", url]) do
-    start_pleroma()
-
-    Pleroma.HTTP.get(url)
-    |> IO.inspect()
-  end
-
   def run(["home_timeline", nickname]) do
     start_pleroma()
     user = Repo.get_by!(User, nickname: nickname)

lib/mix/tasks/pleroma/instance.ex

@@ -247,13 +247,9 @@ def run(["gen" | rest]) do
       config_dir = Path.dirname(config_path)
       psql_dir = Path.dirname(psql_path)
 
-      to_create =
       [config_dir, psql_dir, static_dir, uploads_dir]
       |> Enum.reject(&File.exists?/1)
-
+      |> Enum.map(&File.mkdir_p!/1)
-      for dir <- to_create do
-        File.mkdir_p!(dir)
-      end
 
       shell_info("Writing config to #{config_path}.")
 
@@ -323,4 +319,6 @@ defp upload_filters(filters) when is_map(filters) do
 
     enabled_filters
   end
+
+  defp upload_filters(_), do: []
 end

lib/mix/tasks/pleroma/search.ex

@@ -10,11 +10,14 @@ defmodule Mix.Tasks.Pleroma.Search do
 
   def run(["import", "activities" | _rest]) do
     start_pleroma()
+    IO.inspect(Pleroma.Config.get([Pleroma.Search.Elasticsearch.Cluster, :indexes, :activities]))
 
+    IO.inspect(
       Elasticsearch.Index.Bulk.upload(
         Pleroma.Search.Elasticsearch.Cluster,
         "activities",
         Pleroma.Config.get([Pleroma.Search.Elasticsearch.Cluster, :indexes, :activities])
       )
+    )
   end
 end

lib/mix/tasks/pleroma/user.ex

@@ -378,11 +378,9 @@ def run(["change_email", nickname, email]) do
   def run(["show", nickname]) do
     start_pleroma()
 
-    user =
     nickname
     |> User.get_cached_by_nickname()
-
+    |> IO.inspect()
-    shell_info("#{inspect(user)}")
   end
 
   def run(["send_confirmation", nickname]) do
@@ -391,6 +389,7 @@ def run(["send_confirmation", nickname]) do
     with %User{} = user <- User.get_cached_by_nickname(nickname) do
       user
       |> Pleroma.Emails.UserEmail.account_confirmation_email()
+      |> IO.inspect()
       |> Pleroma.Emails.Mailer.deliver!()
 
       shell_info("#{nickname}'s email sent")
@@ -466,7 +465,7 @@ def run(["blocking", nickname]) do
 
     with %User{local: true} = user <- User.get_cached_by_nickname(nickname) do
       blocks = User.following_ap_ids(user)
-      IO.puts("#{inspect(blocks)}")
+      IO.inspect(blocks, limit: :infinity)
     end
   end
 

lib/pleroma/activity/html.ex

@@ -38,11 +38,7 @@ defp add_cache_key_for(activity_id, additional_key) do
 
   def invalidate_cache_for(activity_id) do
     keys = get_cache_keys_for(activity_id)
-
+    Enum.map(keys, &@cachex.del(:scrubber_cache, &1))
-    for key <- keys do
-      @cachex.del(:scrubber_cache, key)
-    end
-
     @cachex.del(:scrubber_management_cache, activity_id)
   end
 

lib/pleroma/akkoma/translators/argos_translate.ex

@@ -1,109 +0,0 @@
-defmodule Pleroma.Akkoma.Translators.ArgosTranslate do
-  @behaviour Pleroma.Akkoma.Translator
-
-  alias Pleroma.Config
-
-  defp argos_translate do
-    Config.get([:argos_translate, :command_argos_translate])
-  end
-
-  defp argospm do
-    Config.get([:argos_translate, :command_argospm])
-  end
-
-  defp strip_html? do
-    Config.get([:argos_translate, :strip_html])
-  end
-
-  defp safe_languages() do
-    try do
-      System.cmd(argospm(), ["list"], stderr_to_stdout: true, parallelism: true)
-    rescue
-      _ -> {"Command #{argospm()} not found", 1}
-    end
-  end
-
-  @impl Pleroma.Akkoma.Translator
-  def languages do
-    with {response, 0} <- safe_languages() do
-      langs =
-        response
-        |> String.split("\n", trim: true)
-        |> Enum.map(fn
-          "translate-" <> l -> String.split(l, "_")
-        end)
-
-      source_langs =
-        langs
-        |> Enum.map(fn [l, _] -> %{code: l, name: l} end)
-        |> Enum.uniq()
-
-      dest_langs =
-        langs
-        |> Enum.map(fn [_, l] -> %{code: l, name: l} end)
-        |> Enum.uniq()
-
-      {:ok, source_langs, dest_langs}
-    else
-      {response, _} -> {:error, "ArgosTranslate failed to fetch languages (#{response})"}
-    end
-  end
-
-  defp safe_translate(string, from_language, to_language) do
-    try do
-      System.cmd(
-        argos_translate(),
-        ["--from-lang", from_language, "--to-lang", to_language, string],
-        stderr_to_stdout: true,
-        parallelism: true
-      )
-    rescue
-      _ -> {"Command #{argos_translate()} not found", 1}
-    end
-  end
-
-  defp clean_string(string, true) do
-    string
-    |> String.replace("<p>", "\n")
-    |> String.replace("</p>", "\n")
-    |> String.replace("<br>", "\n")
-    |> String.replace("<br/>", "\n")
-    |> String.replace("<li>", "\n")
-    |> Pleroma.HTML.strip_tags()
-    |> HtmlEntities.decode()
-  end
-
-  defp clean_string(string, _), do: string
-
-  defp htmlify_response(string, true) do
-    string
-    |> HtmlEntities.encode()
-    |> String.replace("\n", "<br/>")
-  end
-
-  defp htmlify_response(string, _), do: string
-
-  @impl Pleroma.Akkoma.Translator
-  def translate(string, nil, to_language) do
-    # Akkoma's Pleroma-fe expects us to detect the source language automatically.
-    # Argos-translate doesn't have that option (yet?)
-    #     see <https://github.com/argosopentech/argos-translate/issues/9>
-    # For now we return the text unchanged, supposedly translated from the target language.
-    # Afterwards people get the option to overwrite the source language from a dropdown.
-    {:ok, to_language, string}
-  end
-
-  def translate(string, from_language, to_language) do
-    # Argos Translate doesn't properly translate HTML (yet?)
-    # For now we give admins the option to strip the html before translating
-    # Note that we have to add some html back to the response afterwards
-    string = clean_string(string, strip_html?())
-
-    with {translated, 0} <-
-           safe_translate(string, from_language, to_language) do
-      {:ok, from_language, translated |> htmlify_response(strip_html?())}
-    else
-      {response, _} -> {:error, "ArgosTranslate failed to translate (#{response})"}
-    end
-  end
-end

lib/pleroma/announcement.ex

@@ -24,10 +24,8 @@ defmodule Pleroma.Announcement do
   end
 
   def change(struct, params \\ %{}) do
-    params = validate_params(struct, params)
-
     struct
-    |> cast(params, [:data, :starts_at, :ends_at, :rendered])
+    |> cast(validate_params(struct, params), [:data, :starts_at, :ends_at, :rendered])
     |> validate_required([:data])
   end
 

lib/pleroma/application.ex

@@ -73,8 +73,7 @@ def start(_type, _args) do
           Pleroma.JobQueueMonitor,
           {Majic.Pool, [name: Pleroma.MajicPool, pool_size: Config.get([:majic_pool, :size], 2)]},
           {Oban, Config.get(Oban)},
-          Pleroma.Web.Endpoint,
+          Pleroma.Web.Endpoint
-          Pleroma.Web.Telemetry
         ] ++
         elasticsearch_children() ++
         task_children(@mix_env) ++
@@ -159,8 +158,7 @@ defp cachex_children do
       build_cachex("banned_urls", default_ttl: :timer.hours(24 * 30), limit: 5_000),
       build_cachex("translations", default_ttl: :timer.hours(24 * 30), limit: 2500),
       build_cachex("instances", default_ttl: :timer.hours(24), ttl_interval: 1000, limit: 2500),
-      build_cachex("request_signatures", default_ttl: :timer.hours(24 * 30), limit: 3000),
+      build_cachex("request_signatures", default_ttl: :timer.hours(24 * 30), limit: 3000)
-      build_cachex("rel_me", default_ttl: :timer.hours(24 * 30), limit: 300)
     ]
   end
 
@@ -200,8 +198,6 @@ defp background_migrators do
     ]
   end
 
-  @spec task_children(atom()) :: [map()]
-
   defp task_children(:test) do
     [
       %{
@@ -227,7 +223,6 @@ defp task_children(_) do
     ]
   end
 
-  @spec elasticsearch_children :: [Pleroma.Search.Elasticsearch.Cluster]
   def elasticsearch_children do
     config = Config.get([Pleroma.Search, :module])
 
@@ -260,12 +255,10 @@ def limiters_setup do
   defp http_children do
     proxy_url = Config.get([:http, :proxy_url])
     proxy = Pleroma.HTTP.AdapterHelper.format_proxy(proxy_url)
-    pool_size = Config.get([:http, :pool_size])
 
     config =
       [:http, :adapter]
       |> Config.get([])
-      |> Pleroma.HTTP.AdapterHelper.add_pool_size(pool_size)
       |> Pleroma.HTTP.AdapterHelper.maybe_add_proxy_pool(proxy)
       |> Keyword.put(:name, MyFinch)
 

lib/pleroma/application_requirements.ex

@@ -194,6 +194,8 @@ defp check_system_commands!(:ok) do
     end
   end
 
+  defp check_system_commands!(result), do: result
+
   defp check_repo_pool_size!(:ok) do
     if Pleroma.Config.get([Pleroma.Repo, :pool_size], 10) != 10 and
          not Pleroma.Config.get([:dangerzone, :override_repo_pool_size], false) do

lib/pleroma/config/deprecation_warnings.ex

@@ -181,8 +181,7 @@ def warn do
       check_uploders_s3_public_endpoint(),
       check_quarantined_instances_tuples(),
       check_transparency_exclusions_tuples(),
-      check_simple_policy_tuples(),
+      check_simple_policy_tuples()
-      check_http_adapter()
     ]
     |> Enum.reduce(:ok, fn
       :ok, :ok -> :ok
@@ -211,32 +210,6 @@ def check_welcome_message_config do
     end
   end
 
-  def check_http_adapter do
-    http_adapter = Application.get_env(:tesla, :adapter)
-
-    case http_adapter do
-      {Tesla.Adapter.Finch, _} ->
-        :ok
-
-      Tesla.Mock ->
-        # tests do be testing
-        :ok
-
-      _anything_else ->
-        Logger.error("""
-        !!!CONFIG ERROR!!!
-        Your config is using a custom tesla adapter, this was standardised
-        to finch in 2022.06, and alternate adapters were removed in 2023.02.
-        Please ensure you either:
-        \n* do not have any custom value for `:tesla, :adapter`, or
-        \n* have `config :tesla, :adapter, {Tesla.Adapter.Finch, name: MyFinch}`
-        (your current value is #{inspect(http_adapter)})
-        """)
-
-        :error
-    end
-  end
-
   def check_old_mrf_config do
     warning_preface = """
     !!!DEPRECATION WARNING!!!

lib/pleroma/config/transfer_task.ex

@@ -25,9 +25,7 @@ defp reboot_time_subkeys,
     do: [
       {:pleroma, Pleroma.Captcha, [:seconds_valid]},
       {:pleroma, Pleroma.Upload, [:proxy_remote]},
-      {:pleroma, :instance, [:upload_limit]},
+      {:pleroma, :instance, [:upload_limit]}
-      {:pleroma, :http, [:pool_size]},
-      {:pleroma, :http, [:proxy_url]}
     ]
 
   def start_link(restart_pleroma? \\ true) do
@@ -42,9 +40,8 @@ def load_and_update_env(deleted_settings \\ [], restart_pleroma? \\ true) do
       # We need to restart applications for loaded settings take effect
       {logger, other} =
         (Repo.all(ConfigDB) ++ deleted_settings)
-        |> Enum.reject(&invalid_key_or_group/1)
         |> Enum.map(&merge_with_default/1)
-        |> Enum.split_with(fn {group, _, _, _} -> group == :logger end)
+        |> Enum.split_with(fn {group, _, _, _} -> group in [:logger, :quack] end)
 
       logger
       |> Enum.sort()
@@ -86,10 +83,6 @@ defp maybe_set_pleroma_last(apps) do
     end
   end
 
-  defp invalid_key_or_group(%ConfigDB{key: :invalid_atom}), do: true
-  defp invalid_key_or_group(%ConfigDB{group: :invalid_atom}), do: true
-  defp invalid_key_or_group(_), do: false
-
   defp merge_with_default(%{group: group, key: key, value: value} = setting) do
     default =
       if group == :pleroma do
@@ -108,6 +101,12 @@ defp merge_with_default(%{group: group, key: key, value: value} = setting) do
     {group, key, value, merged}
   end
 
+  # change logger configuration in runtime, without restart
+  defp configure({:quack, key, _, merged}) do
+    Logger.configure_backend(Quack.Logger, [{key, merged}])
+    :ok = update_env(:quack, key, merged)
+  end
+
   defp configure({_, :backends, _, merged}) do
     # removing current backends
     Enum.each(Application.get_env(:logger, :backends), &Logger.remove_backend/1)

lib/pleroma/config_db.ex

@@ -163,6 +163,7 @@ defp can_be_partially_updated?(%ConfigDB{} = config), do: not only_full_update?(
   defp only_full_update?(%ConfigDB{group: group, key: key}) do
     full_key_update = [
       {:pleroma, :ecto_repos},
+      {:quack, :meta},
       {:mime, :types},
       {:cors_plug, [:max_age, :methods, :expose, :headers]},
       {:swarm, :node_blacklist},
@@ -342,11 +343,7 @@ def string_to_elixir_types(":" <> atom), do: String.to_atom(atom)
 
   def string_to_elixir_types(value) do
     if module_name?(value) do
-      try do
       String.to_existing_atom("Elixir." <> value)
-      rescue
-        ArgumentError -> :invalid_atom
-      end
     else
       value
     end

lib/pleroma/emails/mailer.ex

@@ -35,6 +35,11 @@ def perform(:deliver_async, email, config), do: deliver(email, config)
   def deliver(email, config \\ [])
 
   def deliver(email, config) do
+    # temporary hackney fix until hackney max_connections bug is fixed
+    # https://git.pleroma.social/pleroma/pleroma/-/issues/2101
+    email =
+      Swoosh.Email.put_private(email, :hackney_options, ssl_options: [versions: [:"tlsv1.2"]])
+
     case enabled?() do
       true -> Swoosh.Mailer.deliver(email, parse_config(config))
       false -> {:error, :deliveries_disabled}

lib/pleroma/emoji/pack.ex

@@ -209,9 +209,7 @@ def list_remote(opts) do
 
     with :ok <- validate_shareable_packs_available(uri) do
       uri
-      |> URI.merge(
+      |> URI.merge("/api/pleroma/emoji/packs?page=#{opts[:page]}&page_size=#{opts[:page_size]}")
-        "/api/v1/pleroma/emoji/packs?page=#{opts[:page]}&page_size=#{opts[:page_size]}"
-      )
       |> http_get()
     end
   end
@@ -252,7 +250,7 @@ def download(name, url, as) do
 
     with :ok <- validate_shareable_packs_available(uri),
          {:ok, remote_pack} <-
-           uri |> URI.merge("/api/v1/pleroma/emoji/pack?name=#{name}") |> http_get(),
+           uri |> URI.merge("/api/pleroma/emoji/pack?name=#{name}") |> http_get(),
          {:ok, %{sha: sha, url: url} = pack_info} <- fetch_pack_info(remote_pack, uri, name),
          {:ok, archive} <- download_archive(url, sha),
          pack <- copy_as(remote_pack, as || name),
@@ -593,7 +591,7 @@ defp fetch_pack_info(remote_pack, uri, name) do
         {:ok,
          %{
            sha: sha,
-           url: URI.merge(uri, "/api/v1/pleroma/emoji/packs/archive?name=#{name}") |> to_string()
+           url: URI.merge(uri, "/api/pleroma/emoji/packs/archive?name=#{name}") |> to_string()
          }}
 
       %{"fallback-src" => src, "fallback-src-sha256" => sha} when is_binary(src) ->

lib/pleroma/following_relationship.ex

@@ -14,8 +14,6 @@ defmodule Pleroma.FollowingRelationship do
   alias Pleroma.Repo
   alias Pleroma.User
 
-  @type follow_state :: :follow_pending | :follow_accept | :follow_reject | :unfollow
-
   schema "following_relationships" do
     field(:state, State, default: :follow_pending)
 
@@ -74,7 +72,6 @@ def update(%User{} = follower, %User{} = following, state) do
     end
   end
 
-  @spec follow(User.t(), User.t()) :: {:ok, User.t(), User.t()} | {:error, any}
   def follow(%User{} = follower, %User{} = following, state \\ :follow_accept) do
     with {:ok, _following_relationship} <-
            %__MODULE__{}
@@ -84,7 +81,6 @@ def follow(%User{} = follower, %User{} = following, state \\ :follow_accept) do
     end
   end
 
-  @spec unfollow(User.t(), User.t()) :: {:ok, User.t(), User.t()} | {:error, any}
   def unfollow(%User{} = follower, %User{} = following) do
     case get(follower, following) do
       %__MODULE__{} = following_relationship ->
@@ -93,12 +89,10 @@ def unfollow(%User{} = follower, %User{} = following) do
         end
 
       _ ->
-        {:ok, follower, following}
+        {:ok, nil}
     end
   end
 
-  @spec after_update(follow_state(), User.t(), User.t()) ::
-          {:ok, User.t(), User.t()} | {:error, any()}
   defp after_update(state, %User{} = follower, %User{} = following) do
     with {:ok, following} <- User.update_follower_count(following),
          {:ok, follower} <- User.update_following_count(follower) do
@@ -109,8 +103,6 @@ defp after_update(state, %User{} = follower, %User{} = following) do
       })
 
       {:ok, follower, following}
-    else
-      err -> {:error, err}
     end
   end
 

lib/pleroma/frontend.ex

@@ -93,7 +93,7 @@ defp download_build(frontend_info, dest) do
     url = String.replace(frontend_info["build_url"], "${ref}", frontend_info["ref"])
 
     with {:ok, %{status: 200, body: zip_body}} <-
-           Pleroma.HTTP.get(url, [], receive_timeout: 120_000) do
+           Pleroma.HTTP.get(url, [], recv_timeout: 120_000) do
       unzip(zip_body, dest)
     else
       {:error, e} -> {:error, e}

lib/pleroma/gun.ex

@@ -0,0 +1,29 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Gun do
+  @callback open(charlist(), pos_integer(), map()) :: {:ok, pid()}
+  @callback info(pid()) :: map()
+  @callback close(pid()) :: :ok
+  @callback await_up(pid, pos_integer()) :: {:ok, atom()} | {:error, atom()}
+  @callback connect(pid(), map()) :: reference()
+  @callback await(pid(), reference()) :: {:response, :fin, 200, []}
+  @callback set_owner(pid(), pid()) :: :ok
+
+  defp api, do: Pleroma.Config.get([Pleroma.Gun], Pleroma.Gun.API)
+
+  def open(host, port, opts), do: api().open(host, port, opts)
+
+  def info(pid), do: api().info(pid)
+
+  def close(pid), do: api().close(pid)
+
+  def await_up(pid, timeout \\ 5_000), do: api().await_up(pid, timeout)
+
+  def connect(pid, opts), do: api().connect(pid, opts)
+
+  def await(pid, ref), do: api().await(pid, ref)
+
+  def set_owner(pid, owner), do: api().set_owner(pid, owner)
+end

lib/pleroma/gun/api.ex

@@ -0,0 +1,46 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Gun.API do
+  @behaviour Pleroma.Gun
+
+  alias Pleroma.Gun
+
+  @gun_keys [
+    :connect_timeout,
+    :http_opts,
+    :http2_opts,
+    :protocols,
+    :retry,
+    :retry_timeout,
+    :trace,
+    :transport,
+    :tls_opts,
+    :tcp_opts,
+    :socks_opts,
+    :ws_opts,
+    :supervise
+  ]
+
+  @impl Gun
+  def open(host, port, opts \\ %{}), do: :gun.open(host, port, Map.take(opts, @gun_keys))
+
+  @impl Gun
+  defdelegate info(pid), to: :gun
+
+  @impl Gun
+  defdelegate close(pid), to: :gun
+
+  @impl Gun
+  defdelegate await_up(pid, timeout \\ 5_000), to: :gun
+
+  @impl Gun
+  defdelegate connect(pid, opts), to: :gun
+
+  @impl Gun
+  defdelegate await(pid, ref), to: :gun
+
+  @impl Gun
+  defdelegate set_owner(pid, owner), to: :gun
+end

lib/pleroma/gun/conn.ex

@@ -0,0 +1,131 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Gun.Conn do
+  alias Pleroma.Gun
+
+  require Logger
+
+  def open(%URI{} = uri, opts) do
+    pool_opts = Pleroma.Config.get([:connections_pool], [])
+
+    opts =
+      opts
+      |> Enum.into(%{})
+      |> Map.put_new(:connect_timeout, pool_opts[:connect_timeout] || 5_000)
+      |> Map.put_new(:supervise, false)
+      |> maybe_add_tls_opts(uri)
+
+    do_open(uri, opts)
+  end
+
+  defp maybe_add_tls_opts(opts, %URI{scheme: "http"}), do: opts
+
+  defp maybe_add_tls_opts(opts, %URI{scheme: "https"}) do
+    tls_opts = [
+      verify: :verify_peer,
+      cacertfile: CAStore.file_path(),
+      depth: 20,
+      reuse_sessions: false,
+      log_level: :warning,
+      customize_hostname_check: [match_fun: :public_key.pkix_verify_hostname_match_fun(:https)]
+    ]
+
+    tls_opts =
+      if Keyword.keyword?(opts[:tls_opts]) do
+        Keyword.merge(tls_opts, opts[:tls_opts])
+      else
+        tls_opts
+      end
+
+    Map.put(opts, :tls_opts, tls_opts)
+  end
+
+  defp do_open(uri, %{proxy: {proxy_host, proxy_port}} = opts) do
+    connect_opts =
+      uri
+      |> destination_opts()
+      |> add_http2_opts(uri.scheme, Map.get(opts, :tls_opts, []))
+
+    with open_opts <- Map.delete(opts, :tls_opts),
+         {:ok, conn} <- Gun.open(proxy_host, proxy_port, open_opts),
+         {:ok, protocol} <- Gun.await_up(conn, opts[:connect_timeout]),
+         stream <- Gun.connect(conn, connect_opts),
+         {:response, :fin, 200, _} <- Gun.await(conn, stream) do
+      {:ok, conn, protocol}
+    else
+      error ->
+        Logger.warn(
+          "Opening proxied connection to #{compose_uri_log(uri)} failed with error #{inspect(error)}"
+        )
+
+        error
+    end
+  end
+
+  defp do_open(uri, %{proxy: {proxy_type, proxy_host, proxy_port}} = opts) do
+    version =
+      proxy_type
+      |> to_string()
+      |> String.last()
+      |> case do
+        "4" -> 4
+        _ -> 5
+      end
+
+    socks_opts =
+      uri
+      |> destination_opts()
+      |> add_http2_opts(uri.scheme, Map.get(opts, :tls_opts, []))
+      |> Map.put(:version, version)
+
+    opts =
+      opts
+      |> Map.put(:protocols, [:socks])
+      |> Map.put(:socks_opts, socks_opts)
+
+    with {:ok, conn} <- Gun.open(proxy_host, proxy_port, opts),
+         {:ok, protocol} <- Gun.await_up(conn, opts[:connect_timeout]) do
+      {:ok, conn, protocol}
+    else
+      error ->
+        Logger.warn(
+          "Opening socks proxied connection to #{compose_uri_log(uri)} failed with error #{inspect(error)}"
+        )
+
+        error
+    end
+  end
+
+  defp do_open(%URI{host: host, port: port} = uri, opts) do
+    host = Pleroma.HTTP.AdapterHelper.parse_host(host)
+
+    with {:ok, conn} <- Gun.open(host, port, opts),
+         {:ok, protocol} <- Gun.await_up(conn, opts[:connect_timeout]) do
+      {:ok, conn, protocol}
+    else
+      error ->
+        Logger.warn(
+          "Opening connection to #{compose_uri_log(uri)} failed with error #{inspect(error)}"
+        )
+
+        error
+    end
+  end
+
+  defp destination_opts(%URI{host: host, port: port}) do
+    host = Pleroma.HTTP.AdapterHelper.parse_host(host)
+    %{host: host, port: port}
+  end
+
+  defp add_http2_opts(opts, "https", tls_opts) do
+    Map.merge(opts, %{protocols: [:http2], transport: :tls, tls_opts: tls_opts})
+  end
+
+  defp add_http2_opts(opts, _, _), do: opts
+
+  def compose_uri_log(%URI{scheme: scheme, host: host, path: path}) do
+    "#{scheme}://#{host}#{path}"
+  end
+end

lib/pleroma/gun/connection_pool.ex

@@ -0,0 +1,86 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Gun.ConnectionPool do
+  @registry __MODULE__
+
+  alias Pleroma.Gun.ConnectionPool.WorkerSupervisor
+
+  def children do
+    [
+      {Registry, keys: :unique, name: @registry},
+      Pleroma.Gun.ConnectionPool.WorkerSupervisor
+    ]
+  end
+
+  @spec get_conn(URI.t(), keyword()) :: {:ok, pid()} | {:error, term()}
+  def get_conn(uri, opts) do
+    key = "#{uri.scheme}:#{uri.host}:#{uri.port}"
+
+    case Registry.lookup(@registry, key) do
+      # The key has already been registered, but connection is not up yet
+      [{worker_pid, nil}] ->
+        get_gun_pid_from_worker(worker_pid, true)
+
+      [{worker_pid, {gun_pid, _used_by, _crf, _last_reference}}] ->
+        GenServer.call(worker_pid, :add_client)
+        {:ok, gun_pid}
+
+      [] ->
+        # :gun.set_owner fails in :connected state for whatevever reason,
+        # so we open the connection in the process directly and send it's pid back
+        # We trust gun to handle timeouts by itself
+        case WorkerSupervisor.start_worker([key, uri, opts, self()]) do
+          {:ok, worker_pid} ->
+            get_gun_pid_from_worker(worker_pid, false)
+
+          {:error, {:already_started, worker_pid}} ->
+            get_gun_pid_from_worker(worker_pid, true)
+
+          err ->
+            err
+        end
+    end
+  end
+
+  defp get_gun_pid_from_worker(worker_pid, register) do
+    # GenServer.call will block the process for timeout length if
+    # the server crashes on startup (which will happen if gun fails to connect)
+    # so instead we use cast + monitor
+
+    ref = Process.monitor(worker_pid)
+    if register, do: GenServer.cast(worker_pid, {:add_client, self()})
+
+    receive do
+      {:conn_pid, pid} ->
+        Process.demonitor(ref)
+        {:ok, pid}
+
+      {:DOWN, ^ref, :process, ^worker_pid, reason} ->
+        case reason do
+          {:shutdown, {:error, _} = error} -> error
+          {:shutdown, error} -> {:error, error}
+          _ -> {:error, reason}
+        end
+    end
+  end
+
+  @spec release_conn(pid()) :: :ok
+  def release_conn(conn_pid) do
+    # :ets.fun2ms(fn {_, {worker_pid, {gun_pid, _, _, _}}} when gun_pid == conn_pid ->
+    #    worker_pid end)
+    query_result =
+      Registry.select(@registry, [
+        {{:_, :"$1", {:"$2", :_, :_, :_}}, [{:==, :"$2", conn_pid}], [:"$1"]}
+      ])
+
+    case query_result do
+      [worker_pid] ->
+        GenServer.call(worker_pid, :remove_client)
+
+      [] ->
+        :ok
+    end
+  end
+end

lib/pleroma/gun/connection_pool/reclaimer.ex

@@ -0,0 +1,89 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Gun.ConnectionPool.Reclaimer do
+  use GenServer, restart: :temporary
+
+  defp registry, do: Pleroma.Gun.ConnectionPool
+
+  def start_monitor do
+    pid =
+      case :gen_server.start(__MODULE__, [], name: {:via, Registry, {registry(), "reclaimer"}}) do
+        {:ok, pid} ->
+          pid
+
+        {:error, {:already_registered, pid}} ->
+          pid
+      end
+
+    {pid, Process.monitor(pid)}
+  end
+
+  @impl true
+  def init(_) do
+    {:ok, nil, {:continue, :reclaim}}
+  end
+
+  @impl true
+  def handle_continue(:reclaim, _) do
+    max_connections = Pleroma.Config.get([:connections_pool, :max_connections])
+
+    reclaim_max =
+      [:connections_pool, :reclaim_multiplier]
+      |> Pleroma.Config.get()
+      |> Kernel.*(max_connections)
+      |> round
+      |> max(1)
+
+    :telemetry.execute([:pleroma, :connection_pool, :reclaim, :start], %{}, %{
+      max_connections: max_connections,
+      reclaim_max: reclaim_max
+    })
+
+    # :ets.fun2ms(
+    # fn {_, {worker_pid, {_, used_by, crf, last_reference}}} when used_by == [] ->
+    #   {worker_pid, crf, last_reference} end)
+    unused_conns =
+      Registry.select(
+        registry(),
+        [
+          {{:_, :"$1", {:_, :"$2", :"$3", :"$4"}}, [{:==, :"$2", []}], [{{:"$1", :"$3", :"$4"}}]}
+        ]
+      )
+
+    case unused_conns do
+      [] ->
+        :telemetry.execute(
+          [:pleroma, :connection_pool, :reclaim, :stop],
+          %{reclaimed_count: 0},
+          %{
+            max_connections: max_connections
+          }
+        )
+
+        {:stop, :no_unused_conns, nil}
+
+      unused_conns ->
+        reclaimed =
+          unused_conns
+          |> Enum.sort(fn {_pid1, crf1, last_reference1}, {_pid2, crf2, last_reference2} ->
+            crf1 <= crf2 and last_reference1 <= last_reference2
+          end)
+          |> Enum.take(reclaim_max)
+
+        reclaimed
+        |> Enum.each(fn {pid, _, _} ->
+          DynamicSupervisor.terminate_child(Pleroma.Gun.ConnectionPool.WorkerSupervisor, pid)
+        end)
+
+        :telemetry.execute(
+          [:pleroma, :connection_pool, :reclaim, :stop],
+          %{reclaimed_count: Enum.count(reclaimed)},
+          %{max_connections: max_connections}
+        )
+
+        {:stop, :normal, nil}
+    end
+  end
+end

lib/pleroma/gun/connection_pool/worker.ex

@@ -0,0 +1,153 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Gun.ConnectionPool.Worker do
+  alias Pleroma.Gun
+  use GenServer, restart: :temporary
+
+  defp registry, do: Pleroma.Gun.ConnectionPool
+
+  def start_link([key | _] = opts) do
+    GenServer.start_link(__MODULE__, opts, name: {:via, Registry, {registry(), key}})
+  end
+
+  @impl true
+  def init([_key, _uri, _opts, _client_pid] = opts) do
+    {:ok, nil, {:continue, {:connect, opts}}}
+  end
+
+  @impl true
+  def handle_continue({:connect, [key, uri, opts, client_pid]}, _) do
+    with {:ok, conn_pid, protocol} <- Gun.Conn.open(uri, opts),
+         Process.link(conn_pid) do
+      time = :erlang.monotonic_time(:millisecond)
+
+      {_, _} =
+        Registry.update_value(registry(), key, fn _ ->
+          {conn_pid, [client_pid], 1, time}
+        end)
+
+      send(client_pid, {:conn_pid, conn_pid})
+
+      {:noreply,
+       %{
+         key: key,
+         timer: nil,
+         client_monitors: %{client_pid => Process.monitor(client_pid)},
+         protocol: protocol
+       }, :hibernate}
+    else
+      err ->
+        {:stop, {:shutdown, err}, nil}
+    end
+  end
+
+  @impl true
+  def handle_cast({:add_client, client_pid}, state) do
+    case handle_call(:add_client, {client_pid, nil}, state) do
+      {:reply, conn_pid, state, :hibernate} ->
+        send(client_pid, {:conn_pid, conn_pid})
+        {:noreply, state, :hibernate}
+    end
+  end
+
+  @impl true
+  def handle_cast({:remove_client, client_pid}, state) do
+    case handle_call(:remove_client, {client_pid, nil}, state) do
+      {:reply, _, state, :hibernate} ->
+        {:noreply, state, :hibernate}
+    end
+  end
+
+  @impl true
+  def handle_call(:add_client, {client_pid, _}, %{key: key, protocol: protocol} = state) do
+    time = :erlang.monotonic_time(:millisecond)
+
+    {{conn_pid, used_by, _, _}, _} =
+      Registry.update_value(registry(), key, fn {conn_pid, used_by, crf, last_reference} ->
+        {conn_pid, [client_pid | used_by], crf(time - last_reference, crf), time}
+      end)
+
+    :telemetry.execute(
+      [:pleroma, :connection_pool, :client, :add],
+      %{client_pid: client_pid, clients: used_by},
+      %{key: state.key, protocol: protocol}
+    )
+
+    state =
+      if state.timer != nil do
+        Process.cancel_timer(state[:timer])
+        %{state | timer: nil}
+      else
+        state
+      end
+
+    ref = Process.monitor(client_pid)
+
+    state = put_in(state.client_monitors[client_pid], ref)
+    {:reply, conn_pid, state, :hibernate}
+  end
+
+  @impl true
+  def handle_call(:remove_client, {client_pid, _}, %{key: key} = state) do
+    {{_conn_pid, used_by, _crf, _last_reference}, _} =
+      Registry.update_value(registry(), key, fn {conn_pid, used_by, crf, last_reference} ->
+        {conn_pid, List.delete(used_by, client_pid), crf, last_reference}
+      end)
+
+    {ref, state} = pop_in(state.client_monitors[client_pid])
+
+    Process.demonitor(ref, [:flush])
+
+    timer =
+      if used_by == [] do
+        max_idle = Pleroma.Config.get([:connections_pool, :max_idle_time], 30_000)
+        Process.send_after(self(), :idle_close, max_idle)
+      else
+        nil
+      end
+
+    {:reply, :ok, %{state | timer: timer}, :hibernate}
+  end
+
+  @impl true
+  def handle_info(:idle_close, state) do
+    # Gun monitors the owner process, and will close the connection automatically
+    # when it's terminated
+    {:stop, :normal, state}
+  end
+
+  @impl true
+  def handle_info({:gun_up, _pid, _protocol}, state) do
+    {:noreply, state, :hibernate}
+  end
+
+  # Gracefully shutdown if the connection got closed without any streams left
+  @impl true
+  def handle_info({:gun_down, _pid, _protocol, _reason, []}, state) do
+    {:stop, :normal, state}
+  end
+
+  # Otherwise, wait for retry
+  @impl true
+  def handle_info({:gun_down, _pid, _protocol, _reason, _killed_streams}, state) do
+    {:noreply, state, :hibernate}
+  end
+
+  @impl true
+  def handle_info({:DOWN, _ref, :process, pid, reason}, state) do
+    :telemetry.execute(
+      [:pleroma, :connection_pool, :client, :dead],
+      %{client_pid: pid, reason: reason},
+      %{key: state.key}
+    )
+
+    handle_cast({:remove_client, pid}, state)
+  end
+
+  # LRFU policy: https://citeseerx.ist.psu.edu/viewdoc/summary?doi=10.1.1.55.1478
+  defp crf(time_delta, prev_crf) do
+    1 + :math.pow(0.5, 0.0001 * time_delta) * prev_crf
+  end
+end

lib/pleroma/gun/connection_pool/worker_supervisor.ex

@@ -0,0 +1,49 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Gun.ConnectionPool.WorkerSupervisor do
+  @moduledoc "Supervisor for pool workers. Does not do anything except enforce max connection limit"
+
+  use DynamicSupervisor
+
+  def start_link(opts) do
+    DynamicSupervisor.start_link(__MODULE__, opts, name: __MODULE__)
+  end
+
+  def init(_opts) do
+    DynamicSupervisor.init(
+      strategy: :one_for_one,
+      max_children: Pleroma.Config.get([:connections_pool, :max_connections])
+    )
+  end
+
+  def start_worker(opts, retry \\ false) do
+    case DynamicSupervisor.start_child(__MODULE__, {Pleroma.Gun.ConnectionPool.Worker, opts}) do
+      {:error, :max_children} ->
+        if retry or free_pool() == :error do
+          :telemetry.execute([:pleroma, :connection_pool, :provision_failure], %{opts: opts})
+          {:error, :pool_full}
+        else
+          start_worker(opts, true)
+        end
+
+      res ->
+        res
+    end
+  end
+
+  defp free_pool do
+    wait_for_reclaimer_finish(Pleroma.Gun.ConnectionPool.Reclaimer.start_monitor())
+  end
+
+  defp wait_for_reclaimer_finish({pid, mon}) do
+    receive do
+      {:DOWN, ^mon, :process, ^pid, :no_unused_conns} ->
+        :error
+
+      {:DOWN, ^mon, :process, ^pid, :normal} ->
+        :ok
+    end
+  end
+end

lib/pleroma/helpers/media_helper.ex

@@ -104,10 +104,10 @@ defp run_fifo(fifo_path, env, executable, args) do
         args: args
       ])
 
-    fifo = File.open!(fifo_path, [:append, :binary])
+    fifo = Port.open(to_charlist(fifo_path), [:eof, :binary, :stream, :out])
     fix = Pleroma.Helpers.QtFastStart.fix(env.body)
-    IO.binwrite(fifo, fix)
+    true = Port.command(fifo, fix)
-    File.close(fifo)
+    :erlang.port_close(fifo)
     loop_recv(pid)
   after
     File.rm(fifo_path)

lib/pleroma/http.ex

@@ -65,7 +65,7 @@ def request(method, url, body, headers, options) when is_binary(url) do
     options = put_in(options[:adapter], adapter_opts)
     params = options[:params] || []
     request = build_request(method, headers, options, url, body, params)
-    client = Tesla.client([Tesla.Middleware.FollowRedirects, Tesla.Middleware.Telemetry])
+    client = Tesla.client([Tesla.Middleware.FollowRedirects])
 
     request(client, request)
   end

lib/pleroma/http/adapter_helper.ex

@@ -14,7 +14,9 @@ defmodule Pleroma.HTTP.AdapterHelper do
   alias Pleroma.HTTP.AdapterHelper
   require Logger
 
-  @type proxy :: {Connection.proxy_type(), Connection.host(), pos_integer(), list()}
+  @type proxy ::
+          {Connection.host(), pos_integer()}
+          | {Connection.proxy_type(), Connection.host(), pos_integer()}
 
   @callback options(keyword(), URI.t()) :: keyword()
 
@@ -23,6 +25,7 @@ def format_proxy(nil), do: nil
 
   def format_proxy(proxy_url) do
     case parse_proxy(proxy_url) do
+      {:ok, host, port} -> {:http, host, port, []}
       {:ok, type, host, port} -> {type, host, port, []}
       _ -> nil
     end
@@ -47,13 +50,6 @@ def maybe_add_proxy_pool(opts, proxy) do
     |> put_in([:pools, :default, :conn_opts, :proxy], proxy)
   end
 
-  def add_pool_size(opts, pool_size) do
-    opts
-    |> maybe_add_pools()
-    |> maybe_add_default_pool()
-    |> put_in([:pools, :default, :size], pool_size)
-  end
-
   defp maybe_add_pools(opts) do
     if Keyword.has_key?(opts, :pools) do
       opts
@@ -98,7 +94,8 @@ defp proxy_type("https"), do: {:ok, :https}
   defp proxy_type(_), do: {:error, :unknown}
 
   @spec parse_proxy(String.t() | tuple() | nil) ::
-          {:ok, proxy_type(), host(), pos_integer()}
+          {:ok, host(), pos_integer()}
+          | {:ok, proxy_type(), host(), pos_integer()}
           | {:error, atom()}
           | nil
   def parse_proxy(nil), do: nil

lib/pleroma/migrators/support/base_migrator.ex

@@ -14,7 +14,7 @@ defmodule Pleroma.Migrators.Support.BaseMigrator do
   @callback fault_rate_allowance() :: integer() | float()
 
   defmacro __using__(_opts) do
-    quote generated: true do
+    quote do
       use GenServer
 
       require Logger

lib/pleroma/moderation_log.ex

@@ -237,8 +237,7 @@ def insert_log(%{actor: %User{}, action: action, target: target} = attrs)
     insert_log_entry_with_message(%ModerationLog{data: data})
   end
 
-  @spec insert_log_entry_with_message(ModerationLog.t()) ::
+  @spec insert_log_entry_with_message(ModerationLog) :: {:ok, ModerationLog} | {:error, any}
-          {:ok, ModerationLog.t()} | {:error, any}
   defp insert_log_entry_with_message(entry) do
     entry.data["message"]
     |> put_in(get_log_entry_message(entry))

lib/pleroma/object.ex

@@ -240,7 +240,7 @@ def delete(%Object{data: %{"id" => id}} = object) do
          {:ok, _} <- invalid_object_cache(object) do
       cleanup_attachments(
         Config.get([:instance, :cleanup_attachments]),
-        %{object: object}
+        %{"object" => object}
       )
 
       {:ok, object, deleted_activity}
@@ -249,7 +249,7 @@ def delete(%Object{data: %{"id" => id}} = object) do
 
   @spec cleanup_attachments(boolean(), %{required(:object) => map()}) ::
           {:ok, Oban.Job.t() | nil}
-  def cleanup_attachments(true, %{object: _} = params) do
+  def cleanup_attachments(true, %{"object" => _} = params) do
     AttachmentsCleanupWorker.enqueue("cleanup_attachments", params)
   end
 

lib/pleroma/object/fetcher.ex

@@ -262,7 +262,7 @@ def fetch_and_contain_remote_object_from_id(id) when is_binary(id) do
   def fetch_and_contain_remote_object_from_id(_id),
     do: {:error, "id must be a string"}
 
-  def get_object(id) do
+  defp get_object(id) do
     date = Pleroma.Signature.signed_date()
 
     headers =
@@ -282,11 +282,6 @@ def get_object(id) do
                %{"profile" => "https://www.w3.org/ns/activitystreams"}} ->
                 {:ok, body}
 
-              # pixelfed sometimes (and only sometimes) responds with http instead of https
-              {:ok, "application", "ld+json",
-               %{"profile" => "http://www.w3.org/ns/activitystreams"}} ->
-                {:ok, body}
-
               _ ->
                 {:error, {:content_type, content_type}}
             end

lib/pleroma/pagination.ex

@@ -88,9 +88,9 @@ def paginate(query, options, :offset, table_binding) do
 
   defp cast_params(params) do
     param_types = %{
-      min_id: params[:id_type] || :string,
+      min_id: :string,
-      since_id: params[:id_type] || :string,
+      since_id: :string,
-      max_id: params[:id_type] || :string,
+      max_id: :string,
       offset: :integer,
       limit: :integer,
       skip_extra_order: :boolean,

lib/pleroma/password.ex

@@ -1,55 +0,0 @@
-defmodule Pleroma.Password do
-  @moduledoc """
-  This module handles password hashing and verification.
-  It will delegate to the appropriate module based on the password hash.
-  It also handles upgrading of password hashes.
-  """
-
-  alias Pleroma.User
-  alias Pleroma.Password.Pbkdf2
-  require Logger
-
-  @hashing_module Argon2
-
-  @spec hash_pwd_salt(String.t()) :: String.t()
-  defdelegate hash_pwd_salt(pass), to: @hashing_module
-
-  @spec checkpw(String.t(), String.t()) :: boolean()
-  def checkpw(password, "$2" <> _ = password_hash) do
-    # Handle bcrypt passwords for Mastodon migration
-    Bcrypt.verify_pass(password, password_hash)
-  end
-
-  def checkpw(password, "$pbkdf2" <> _ = password_hash) do
-    Pbkdf2.verify_pass(password, password_hash)
-  end
-
-  def checkpw(password, "$argon2" <> _ = password_hash) do
-    Argon2.verify_pass(password, password_hash)
-  end
-
-  def checkpw(_password, _password_hash) do
-    Logger.error("Password hash not recognized")
-    false
-  end
-
-  @spec maybe_update_password(User.t(), String.t()) ::
-          {:ok, User.t()} | {:error, Ecto.Changeset.t()}
-  def maybe_update_password(%User{password_hash: "$2" <> _} = user, password) do
-    do_update_password(user, password)
-  end
-
-  def maybe_update_password(%User{password_hash: "$6" <> _} = user, password) do
-    do_update_password(user, password)
-  end
-
-  def maybe_update_password(%User{password_hash: "$pbkdf2" <> _} = user, password) do
-    do_update_password(user, password)
-  end
-
-  def maybe_update_password(user, _), do: {:ok, user}
-
-  defp do_update_password(user, password) do
-    User.reset_password(user, %{password: password, password_confirmation: password})
-  end
-end

lib/pleroma/prometheus_exporter.ex

@@ -1,49 +0,0 @@
-defmodule Pleroma.PrometheusExporter do
-  @moduledoc """
-  Exports metrics in Prometheus format.
-  Mostly exists because of https://github.com/beam-telemetry/telemetry_metrics_prometheus_core/issues/52
-  Basically we need to fetch metrics every so often, or the lib will let them pile up and eventually crash the VM.
-  It also sorta acts as a cache so there is that too.
-  """
-
-  use GenServer
-  require Logger
-
-  def start_link(_opts) do
-    GenServer.start_link(__MODULE__, :ok, name: __MODULE__)
-  end
-
-  def init(_opts) do
-    schedule_next()
-    {:ok, ""}
-  end
-
-  defp schedule_next do
-    Process.send_after(self(), :gather, 60_000)
-  end
-
-  # Scheduled function, gather metrics and schedule next run
-  def handle_info(:gather, _state) do
-    schedule_next()
-    state = TelemetryMetricsPrometheus.Core.scrape()
-    {:noreply, state}
-  end
-
-  # Trigger the call dynamically, mostly for testing
-  def handle_call(:gather, _from, _state) do
-    state = TelemetryMetricsPrometheus.Core.scrape()
-    {:reply, state, state}
-  end
-
-  def handle_call(:show, _from, state) do
-    {:reply, state, state}
-  end
-
-  def show do
-    GenServer.call(__MODULE__, :show)
-  end
-
-  def gather do
-    GenServer.call(__MODULE__, :gather)
-  end
-end

lib/pleroma/release_tasks.ex

@@ -61,6 +61,9 @@ def create do
         IO.puts("The database for #{inspect(@repo)} has already been created")
 
       {:error, term} when is_binary(term) ->
+        IO.puts(:stderr, "The database for #{inspect(@repo)} couldn't be created: #{term}")
+
+      {:error, term} ->
         IO.puts(
           :stderr,
           "The database for #{inspect(@repo)} couldn't be created: #{inspect(term)}"

lib/pleroma/reverse_proxy/client/hackney.ex

@@ -0,0 +1,25 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.ReverseProxy.Client.Hackney do
+  @behaviour Pleroma.ReverseProxy.Client
+
+  @impl true
+  def request(method, url, headers, body, opts \\ []) do
+    opts = Keyword.put(opts, :ssl_options, versions: [:"tlsv1.2", :"tlsv1.1", :tlsv1])
+    :hackney.request(method, url, headers, body, opts)
+  end
+
+  @impl true
+  def stream_body(ref) do
+    case :hackney.stream_body(ref) do
+      :done -> :done
+      {:ok, data} -> {:ok, data, ref}
+      {:error, error} -> {:error, error}
+    end
+  end
+
+  @impl true
+  def close(ref), do: :hackney.close(ref)
+end

lib/pleroma/reverse_proxy/client/tesla.ex

@@ -5,6 +5,8 @@
 defmodule Pleroma.ReverseProxy.Client.Tesla do
   @behaviour Pleroma.ReverseProxy.Client
 
+  alias Pleroma.Gun.ConnectionPool
+
   @type headers() :: [{String.t(), String.t()}]
   @type status() :: pos_integer()
 
@@ -31,6 +33,8 @@ def request(method, url, headers, body, opts \\ []) do
       if is_map(response.body) and method != :head do
         {:ok, response.status, response.headers, response.body}
       else
+        conn_pid = response.opts[:adapter][:conn]
+        ConnectionPool.release_conn(conn_pid)
         {:ok, response.status, response.headers}
       end
     else
@@ -41,7 +45,8 @@ def request(method, url, headers, body, opts \\ []) do
   @impl true
   @spec stream_body(map()) ::
           {:ok, binary(), map()} | {:error, atom() | String.t()} | :done | no_return()
-  def stream_body(%{pid: _pid, fin: true}) do
+  def stream_body(%{pid: pid, fin: true}) do
+    ConnectionPool.release_conn(pid)
     :done
   end
 
@@ -65,13 +70,17 @@ defp read_chunk!(%{pid: pid, stream: stream, opts: opts}) do
 
   @impl true
   @spec close(map) :: :ok | no_return()
-  def close(%{pid: _pid}) do
+  def close(%{pid: pid}) do
-    :ok
+    ConnectionPool.release_conn(pid)
   end
 
   defp check_adapter do
     adapter = Application.get_env(:tesla, :adapter)
 
+    unless adapter == Tesla.Adapter.Gun do
+      raise "#{adapter} doesn't support reading body in chunks"
+    end
+
     adapter
   end
 end

lib/pleroma/reverse_proxy/client/wrapper.ex

@@ -23,6 +23,8 @@ defp client do
     |> client()
   end
 
-  defp client({Tesla.Adapter.Finch, _}), do: Pleroma.ReverseProxy.Client.Tesla
+  defp client(Tesla.Adapter.Hackney), do: Pleroma.ReverseProxy.Client.Hackney
+  defp client(Tesla.Adapter.Gun), do: Pleroma.ReverseProxy.Client.Tesla
+  defp client({Tesla.Adapter.Finch, _}), do: Pleroma.ReverseProxy.Client.Hackney
   defp client(_), do: Pleroma.Config.get!(Pleroma.ReverseProxy.Client)
 end

lib/pleroma/search/elasticsearch.ex

@@ -13,6 +13,9 @@ defmodule Pleroma.Search.Elasticsearch do
   def es_query(:activity, query, offset, limit) do
     must = Parsers.Activity.parse(query)
 
+    if must == [] do
+      :skip
+    else
       %{
         size: limit,
         from: offset,
@@ -29,6 +32,7 @@ def es_query(:activity, query, offset, limit) do
         }
       }
     end
+  end
 
   defp maybe_fetch(:activity, search_query) do
     with true <- Regex.match?(~r/https?:/, search_query),

lib/pleroma/search/elasticsearch/document_mappings/activity.ex

@@ -57,5 +57,5 @@ def encode(activity) do
 defimpl Elasticsearch.Document, for: Pleroma.Object do
   def id(obj), do: obj.id
   def routing(_), do: false
-  def encode(_), do: %{}
+  def encode(_), do: nil
 end

lib/pleroma/search/meilisearch.ex

@@ -154,11 +154,10 @@ def add_to_index(activity) do
 
       with {:ok, res} <- result,
            true <- Map.has_key?(res, "taskUid") do
-        {:ok, res}
+        # Do nothing
       else
-        err ->
+        _ ->
           Logger.error("Failed to add activity #{activity.id} to index: #{inspect(result)}")
-          {:error, err}
       end
     end
   end

lib/pleroma/search/search_backend.ex

@@ -4,7 +4,7 @@ defmodule Pleroma.Search.SearchBackend do
 
   The whole activity is passed, to allow filtering on things such as scope.
   """
-  @callback add_to_index(activity :: Pleroma.Activity.t()) :: {:ok, any()} | {:error, any()}
+  @callback add_to_index(activity :: Pleroma.Activity.t()) :: nil
 
   @doc """
   Remove the object from the index.
@@ -13,5 +13,5 @@ defmodule Pleroma.Search.SearchBackend do
   is what contains the actual content and there is no need for fitlering when removing
   from index.
   """
-  @callback remove_from_index(object :: Pleroma.Object.t()) :: {:ok, any()} | {:error, any()}
+  @callback remove_from_index(object :: Pleroma.Object.t()) :: nil
 end

lib/pleroma/signature.ex

@@ -27,7 +27,7 @@ def key_id_to_actor_id(key_id) do
 
       _ ->
         case Pleroma.Web.WebFinger.finger(maybe_ap_id) do
-          {:ok, %{"ap_id" => ap_id}} -> {:ok, ap_id}
+          %{"ap_id" => ap_id} -> {:ok, ap_id}
           _ -> {:error, maybe_ap_id}
         end
     end

lib/pleroma/stats.ex

@@ -11,7 +11,7 @@ defmodule Pleroma.Stats do
   alias Pleroma.Repo
   alias Pleroma.User
 
-  @interval :timer.seconds(300)
+  @interval :timer.seconds(60)
 
   def start_link(_) do
     GenServer.start_link(
@@ -85,24 +85,14 @@ def calculate_stat_data do
         where: not u.invisible
       )
 
-    remote_users_query =
-      from(u in User,
-        where: u.is_active == true,
-        where: u.local == false,
-        where: not is_nil(u.nickname),
-        where: not u.invisible
-      )
-
     user_count = Repo.aggregate(users_query, :count, :id)
-    remote_user_count = Repo.aggregate(remote_users_query, :count, :id)
 
     %{
       peers: peers,
       stats: %{
         domain_count: domain_count,
         status_count: status_count || 0,
-        user_count: user_count,
+        user_count: user_count
-        remote_user_count: remote_user_count
       }
     }
   end

lib/pleroma/tesla/middleware/connection_pool.ex

@@ -0,0 +1,50 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Tesla.Middleware.ConnectionPool do
+  @moduledoc """
+  Middleware to get/release connections from `Pleroma.Gun.ConnectionPool`
+  """
+
+  @behaviour Tesla.Middleware
+
+  alias Pleroma.Gun.ConnectionPool
+
+  @impl Tesla.Middleware
+  def call(%Tesla.Env{url: url, opts: opts} = env, next, _) do
+    uri = URI.parse(url)
+
+    # Avoid leaking connections when the middleware is called twice
+    # with body_as: :chunks. We assume only the middleware can set
+    # opts[:adapter][:conn]
+    if opts[:adapter][:conn] do
+      ConnectionPool.release_conn(opts[:adapter][:conn])
+    end
+
+    case ConnectionPool.get_conn(uri, opts[:adapter]) do
+      {:ok, conn_pid} ->
+        adapter_opts = Keyword.merge(opts[:adapter], conn: conn_pid, close_conn: false)
+        opts = Keyword.put(opts, :adapter, adapter_opts)
+        env = %{env | opts: opts}
+
+        case Tesla.run(env, next) do
+          {:ok, env} ->
+            unless opts[:adapter][:body_as] == :chunks do
+              ConnectionPool.release_conn(conn_pid)
+              {_, res} = pop_in(env.opts[:adapter][:conn])
+              {:ok, res}
+            else
+              {:ok, env}
+            end
+
+          err ->
+            ConnectionPool.release_conn(conn_pid)
+            err
+        end
+
+      err ->
+        err
+    end
+  end
+end

lib/pleroma/upload.ex

@@ -162,7 +162,7 @@ defp prepare_upload(%Plug.Upload{} = file, opts) do
   defp prepare_upload(%{img: "data:image/" <> image_data}, opts) do
     parsed = Regex.named_captures(~r/(?<filetype>jpeg|png|gif);base64,(?<data>.*)/, image_data)
     data = Base.decode64!(parsed["data"], ignore: :whitespace)
-    hash = Base.encode16(:crypto.hash(:sha256, data), case: :lower)
+    hash = Base.encode16(:crypto.hash(:sha256, data), lower: true)
 
     with :ok <- check_binary_size(data, opts.size_limit),
          tmp_path <- tempfile_for_image(data),

lib/pleroma/upload/filter/analyze_metadata.ex

@@ -77,6 +77,7 @@ defp media_dimensions(file) do
       %{width: width, height: height}
     else
       nil -> {:error, {:ffprobe, :command_not_found}}
+      {:error, _} = error -> error
     end
   end
 end

lib/pleroma/upload/filter/exiftool.ex

@@ -9,12 +9,11 @@ defmodule Pleroma.Upload.Filter.Exiftool do
   """
   @behaviour Pleroma.Upload.Filter
 
-  @spec filter(Pleroma.Upload.t()) :: {:ok, :noop} | {:ok, :filtered} | {:error, String.t()}
+  @spec filter(Pleroma.Upload.t()) :: {:ok, any()} | {:error, String.t()}
 
   # Formats not compatible with exiftool at this time
   def filter(%Pleroma.Upload{content_type: "image/heic"}), do: {:ok, :noop}
   def filter(%Pleroma.Upload{content_type: "image/webp"}), do: {:ok, :noop}
-  def filter(%Pleroma.Upload{content_type: "image/svg+xml"}), do: {:ok, :noop}
 
   def filter(%Pleroma.Upload{tempfile: file, content_type: "image" <> _}) do
     try do

lib/pleroma/upload/filter/mogrifun.ex

@@ -38,7 +38,7 @@ defmodule Pleroma.Upload.Filter.Mogrifun do
     [{"fill", "yellow"}, {"tint", "40"}]
   ]
 
-  @spec filter(Pleroma.Upload.t()) :: {:ok, :filtered | :noop} | {:error, String.t()}
+  @spec filter(Pleroma.Upload.t()) :: {:ok, atom()} | {:error, String.t()}
   def filter(%Pleroma.Upload{tempfile: file, content_type: "image" <> _}) do
     try do
       Filter.Mogrify.do_filter(file, [Enum.random(@filters)])

lib/pleroma/user.ex

@@ -3,10 +3,6 @@
 # SPDX-License-Identifier: AGPL-3.0-only
 
 defmodule Pleroma.User do
-  @moduledoc """
-  A user, local or remote
-  """
-
   use Ecto.Schema
 
   import Ecto.Changeset
@@ -479,7 +475,7 @@ def remote_user_changeset(struct \\ %User{local: false}, params) do
     |> validate_format(:nickname, @email_regex)
     |> validate_length(:bio, max: bio_limit)
     |> validate_length(:name, max: name_limit)
-    |> validate_fields(true, struct)
+    |> validate_fields(true)
     |> validate_non_local()
   end
 
@@ -549,21 +545,13 @@ def update_changeset(struct, params \\ %{}) do
       :pleroma_settings_store,
       &{:ok, Map.merge(struct.pleroma_settings_store, &1)}
     )
-    |> validate_fields(false, struct)
+    |> validate_fields(false)
   end
 
   defp put_fields(changeset) do
-    # These fields are inconsistent in tests when it comes to binary/atom keys
     if raw_fields = get_change(changeset, :raw_fields) do
       raw_fields =
         raw_fields
-        |> Enum.map(fn
-          %{name: name, value: value} ->
-            %{"name" => name, "value" => value}
-
-          %{"name" => _} = field ->
-            field
-        end)
         |> Enum.filter(fn %{"name" => n} -> n != "" end)
 
       fields =
@@ -611,13 +599,7 @@ defp put_change_if_present(changeset, map_field, value_function) do
          {:ok, new_value} <- value_function.(value) do
       put_change(changeset, map_field, new_value)
     else
-      {:error, :file_too_large} ->
+      _ -> changeset
-        Ecto.Changeset.validate_change(changeset, map_field, fn map_field, _value ->
-          [{map_field, "file is too large"}]
-        end)
-
-      _ ->
-        changeset
     end
   end
 
@@ -717,8 +699,7 @@ def register_changeset_ldap(struct, params = %{password: password})
     |> put_private_key()
   end
 
-  @spec register_changeset(User.t(), map(), keyword()) :: Changeset.t()
+  def register_changeset(struct, params \\ %{}, opts \\ []) do
-  def register_changeset(%User{} = struct, params \\ %{}, opts \\ []) do
     bio_limit = Config.get([:instance, :user_bio_length], 5000)
     name_limit = Config.get([:instance, :user_name_length], 100)
     reason_limit = Config.get([:instance, :registration_reason_length], 500)
@@ -832,14 +813,12 @@ defp autofollowing_users(user) do
   end
 
   @doc "Inserts provided changeset, performs post-registration actions (confirmation email sending etc.)"
-  @spec register(Changeset.t()) :: {:ok, User.t()} | {:error, any} | nil
   def register(%Ecto.Changeset{} = changeset) do
     with {:ok, user} <- Repo.insert(changeset) do
       post_register_action(user)
     end
   end
 
-  @spec post_register_action(User.t()) :: {:error, any} | {:ok, User.t()}
   def post_register_action(%User{is_confirmed: false} = user) do
     with {:ok, _} <- maybe_send_confirmation_email(user) do
       {:ok, user}
@@ -954,8 +933,7 @@ def needs_update?(%User{local: false} = user) do
 
   def needs_update?(_), do: true
 
-  @spec maybe_direct_follow(User.t(), User.t()) ::
+  @spec maybe_direct_follow(User.t(), User.t()) :: {:ok, User.t()} | {:error, String.t()}
-          {:ok, User.t(), User.t()} | {:error, String.t()}
 
   # "Locked" (self-locked) users demand explicit authorization of follow requests
   def maybe_direct_follow(%User{} = follower, %User{local: true, is_locked: true} = followed) do
@@ -1088,11 +1066,6 @@ def get_by_guessed_nickname(ap_id) do
     get_cached_by_nickname(nickname)
   end
 
-  @spec set_cache(
-          {:error, any}
-          | {:ok, User.t()}
-          | User.t()
-        ) :: {:ok, User.t()} | {:error, any}
   def set_cache({:ok, user}), do: set_cache(user)
   def set_cache({:error, err}), do: {:error, err}
 
@@ -1103,14 +1076,12 @@ def set_cache(%User{} = user) do
     {:ok, user}
   end
 
-  @spec update_and_set_cache(User.t(), map()) :: {:ok, User.t()} | {:error, any}
   def update_and_set_cache(struct, params) do
     struct
     |> update_changeset(params)
     |> update_and_set_cache()
   end
 
-  @spec update_and_set_cache(Changeset.t()) :: {:ok, User.t()} | {:error, any}
   def update_and_set_cache(%{data: %Pleroma.User{} = user} = changeset) do
     was_superuser_before_update = User.superuser?(user)
 
@@ -1165,7 +1136,6 @@ def get_cached_by_ap_id(ap_id) do
     end
   end
 
-  @spec get_cached_by_id(String.t()) :: nil | Pleroma.User.t()
   def get_cached_by_id(id) do
     key = "id:#{id}"
 
@@ -2277,7 +2247,7 @@ def get_ap_ids_by_nicknames(nicknames) do
   defp put_password_hash(
          %Ecto.Changeset{valid?: true, changes: %{password: password}} = changeset
        ) do
-    change(changeset, password_hash: Pleroma.Password.hash_pwd_salt(password))
+    change(changeset, password_hash: Pleroma.Password.Pbkdf2.hash_pwd_salt(password))
   end
 
   defp put_password_hash(changeset), do: changeset
@@ -2326,7 +2296,6 @@ def add_alias(user, new_alias_user) do
     end
   end
 
-  @spec delete_alias(User.t(), User.t()) :: {:error, :no_such_alias}
   def delete_alias(user, alias_user) do
     current_aliases = user.also_known_as || []
     alias_ap_id = alias_user.ap_id
@@ -2359,8 +2328,7 @@ def update_background(user, background) do
     |> update_and_set_cache()
   end
 
-  @spec validate_fields(Ecto.Changeset.t(), Boolean.t(), User.t()) :: Ecto.Changeset.t()
+  def validate_fields(changeset, remote? \\ false) do
-  def validate_fields(changeset, remote? \\ false, struct) do
     limit_name = if remote?, do: :max_remote_account_fields, else: :max_account_fields
     limit = Config.get([:instance, limit_name], 0)
 
@@ -2373,7 +2341,6 @@ def validate_fields(changeset, remote? \\ false, struct) do
         [fields: "invalid"]
       end
     end)
-    |> maybe_validate_rel_me_field(struct)
   end
 
   defp valid_field?(%{"name" => name, "value" => value}) do
@@ -2386,75 +2353,6 @@ defp valid_field?(%{"name" => name, "value" => value}) do
 
   defp valid_field?(_), do: false
 
-  defp is_url(nil), do: nil
-
-  defp is_url(uri) do
-    case URI.parse(uri) do
-      %URI{host: nil} -> false
-      %URI{scheme: nil} -> false
-      _ -> true
-    end
-  end
-
-  @spec maybe_validate_rel_me_field(Changeset.t(), User.t()) :: Changeset.t()
-  defp maybe_validate_rel_me_field(changeset, %User{ap_id: _ap_id} = struct) do
-    fields = get_change(changeset, :fields)
-    raw_fields = get_change(changeset, :raw_fields)
-
-    if is_nil(fields) do
-      changeset
-    else
-      validate_rel_me_field(changeset, fields, raw_fields, struct)
-    end
-  end
-
-  defp maybe_validate_rel_me_field(changeset, _), do: changeset
-
-  @spec validate_rel_me_field(Changeset.t(), [Map.t()], [Map.t()], User.t()) :: Changeset.t()
-  defp validate_rel_me_field(changeset, fields, raw_fields, %User{
-         nickname: nickname,
-         ap_id: ap_id
-       }) do
-    fields =
-      fields
-      |> Enum.with_index()
-      |> Enum.map(fn {%{"name" => name, "value" => value}, index} ->
-        raw_value =
-          if is_nil(raw_fields) do
-            nil
-          else
-            Enum.at(raw_fields, index)["value"]
-          end
-
-        if is_url(raw_value) do
-          frontend_url =
-            Pleroma.Web.Router.Helpers.redirect_url(
-              Pleroma.Web.Endpoint,
-              :redirector_with_meta,
-              nickname
-            )
-
-          possible_urls = [ap_id, frontend_url]
-
-          with "me" <- RelMe.maybe_put_rel_me(raw_value, possible_urls) do
-            %{
-              "name" => name,
-              "value" => value,
-              "verified_at" => DateTime.to_iso8601(DateTime.utc_now())
-            }
-          else
-            e ->
-              Logger.error("Could not check for rel=me, #{inspect(e)}")
-              %{"name" => name, "value" => value}
-          end
-        else
-          %{"name" => name, "value" => value}
-        end
-      end)
-
-    put_change(changeset, :fields, fields)
-  end
-
   defp truncate_field(%{"name" => name, "value" => value}) do
     {name, _chopped} =
       String.split_at(name, Config.get([:instance, :account_field_name_length], 255))
@@ -2513,7 +2411,7 @@ def confirmation_changeset(user, set_confirmation: confirmed?) do
     cast(user, params, [:is_confirmed, :confirmation_token])
   end
 
-  @spec approval_changeset(Changeset.t(), keyword()) :: Changeset.t()
+  @spec approval_changeset(User.t(), keyword()) :: Changeset.t()
   def approval_changeset(user, set_approval: approved?) do
     cast(user, %{is_approved: approved?}, [:is_approved])
   end
@@ -2588,19 +2486,15 @@ defp add_to_block(%User{} = user, %User{} = blocked) do
     with {:ok, relationship} <- UserRelationship.create_block(user, blocked) do
       @cachex.del(:user_cache, "blocked_users_ap_ids:#{user.ap_id}")
       {:ok, relationship}
-    else
-      err -> err
     end
   end
 
-  @spec remove_from_block(User.t(), User.t()) ::
+  @spec add_to_block(User.t(), User.t()) ::
           {:ok, UserRelationship.t()} | {:ok, nil} | {:error, Ecto.Changeset.t()}
   defp remove_from_block(%User{} = user, %User{} = blocked) do
     with {:ok, relationship} <- UserRelationship.delete_block(user, blocked) do
       @cachex.del(:user_cache, "blocked_users_ap_ids:#{user.ap_id}")
       {:ok, relationship}
-    else
-      err -> err
     end
   end
 
@@ -2622,8 +2516,11 @@ def sanitize_html(%User{} = user) do
   # - display name
   def sanitize_html(%User{} = user, filter) do
     fields =
-      Enum.map(user.fields, fn %{"value" => value} = field ->
+      Enum.map(user.fields, fn %{"name" => name, "value" => value} ->
-        Map.put(field, "value", HTML.filter_tags(value, Pleroma.HTML.Scrubber.LinksOnly))
+        %{
+          "name" => name,
+          "value" => HTML.filter_tags(value, Pleroma.HTML.Scrubber.LinksOnly)
+        }
       end)
 
     user

lib/pleroma/user/backup.ex

@@ -130,8 +130,7 @@ def export(%__MODULE__{} = backup) do
          :ok <- statuses(dir, backup.user),
          :ok <- likes(dir, backup.user),
          :ok <- bookmarks(dir, backup.user),
-         {:ok, zip_path} <-
+         {:ok, zip_path} <- :zip.create(String.to_charlist(dir <> ".zip"), @files, cwd: dir),
-           :zip.create(String.to_charlist(dir <> ".zip"), @files, cwd: String.to_charlist(dir)),
          {:ok, _} <- File.rm_rf(dir) do
       {:ok, to_string(zip_path)}
     end

lib/pleroma/user/hashtag_follow.ex

@@ -43,13 +43,7 @@ def get(%User{} = user, %Hashtag{} = hashtag) do
   end
 
   def get_by_user(%User{} = user) do
-    user
+    Ecto.assoc(user, :followed_hashtags)
-    |> followed_hashtags_query()
     |> Repo.all()
   end
-
-  def followed_hashtags_query(%User{} = user) do
-    Ecto.assoc(user, :followed_hashtags)
-    |> Ecto.Query.order_by([h], desc: h.id)
-  end
 end

lib/pleroma/web.ex

@@ -56,10 +56,7 @@ defp skip_plug(conn, plug_modules) do
               plug_module.skip_plug(conn)
             rescue
               UndefinedFunctionError ->
-                reraise(
+                raise "`#{plug_module}` is not skippable. Append `use Pleroma.Web, :plug` to its code."
-                  "`#{plug_module}` is not skippable. Append `use Pleroma.Web, :plug` to its code.",
-                  __STACKTRACE__
-                )
             end
           end
         )
@@ -132,6 +129,66 @@ defp maybe_halt_on_missing_oauth_scopes_check(conn) do
     end
   end
 
+  def view do
+    quote do
+      use Phoenix.View,
+        root: "lib/pleroma/web/templates",
+        namespace: Pleroma.Web
+
+      # Import convenience functions from controllers
+      import Phoenix.Controller, only: [get_csrf_token: 0, get_flash: 2, view_module: 1]
+
+      import Pleroma.Web.ErrorHelpers
+      import Pleroma.Web.Gettext
+
+      alias Pleroma.Web.Router.Helpers, as: Routes
+
+      require Logger
+
+      @doc "Same as `render/3` but wrapped in a rescue block"
+      def safe_render(view, template, assigns \\ %{}) do
+        Phoenix.View.render(view, template, assigns)
+      rescue
+        error ->
+          Logger.error(
+            "#{__MODULE__} failed to render #{inspect({view, template})}\n" <>
+              Exception.format(:error, error, __STACKTRACE__)
+          )
+
+          nil
+      end
+
+      @doc """
+      Same as `render_many/4` but wrapped in rescue block.
+      """
+      def safe_render_many(collection, view, template, assigns \\ %{}) do
+        Enum.map(collection, fn resource ->
+          as = Map.get(assigns, :as) || view.__resource__
+          assigns = Map.put(assigns, as, resource)
+          safe_render(view, template, assigns)
+        end)
+        |> Enum.filter(& &1)
+      end
+    end
+  end
+
+  def router do
+    quote do
+      use Phoenix.Router
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
+      import Plug.Conn
+      import Phoenix.Controller
+    end
+  end
+
+  def channel do
+    quote do
+      # credo:disable-for-next-line Credo.Check.Consistency.MultiAliasImportRequireUse
+      import Phoenix.Channel
+      import Pleroma.Web.Gettext
+    end
+  end
+
   def plug do
     quote do
       @behaviour Pleroma.Web.Plug
@@ -176,80 +233,6 @@ def call(%Plug.Conn{} = conn, options) do
     end
   end
 
-  def view do
-    quote do
-      use Phoenix.View,
-        root: "lib/pleroma/web/templates",
-        namespace: Pleroma.Web
-
-      # Import convenience functions from controllers
-      import Phoenix.Controller,
-        only: [get_flash: 1, get_flash: 2, view_module: 1, view_template: 1]
-
-      # Include shared imports and aliases for views
-      unquote(view_helpers())
-    end
-  end
-
-  def live_view do
-    quote do
-      use Phoenix.LiveView,
-        layout: {Pleroma.Web.LayoutView, "live.html"}
-
-      unquote(view_helpers())
-    end
-  end
-
-  def live_component do
-    quote do
-      use Phoenix.LiveComponent
-
-      unquote(view_helpers())
-    end
-  end
-
-  def component do
-    quote do
-      use Phoenix.Component
-
-      unquote(view_helpers())
-    end
-  end
-
-  def router do
-    quote do
-      use Phoenix.Router
-
-      import Plug.Conn
-      import Phoenix.Controller
-      import Phoenix.LiveView.Router
-    end
-  end
-
-  def channel do
-    quote do
-      use Phoenix.Channel
-      import Pleroma.Web.Gettext
-    end
-  end
-
-  defp view_helpers do
-    quote do
-      # Use all HTML functionality (forms, tags, etc)
-      use Phoenix.HTML
-
-      # Import LiveView and .heex helpers (live_render, live_patch, <.form>, etc)
-      import Phoenix.LiveView.Helpers
-
-      # Import basic rendering functionality (render, render_layout, etc)
-      import Phoenix.View
-
-      import Pleroma.Web.ErrorHelpers
-      import Pleroma.Web.Gettext
-      alias Pleroma.Web.Router.Helpers, as: Routes
-    end
-  end
-
   @doc """
   When used, dispatch to the appropriate controller/view/etc.
   """

lib/pleroma/web/activity_pub/activity_pub.ex

@@ -1531,10 +1531,6 @@ defp normalize_image(%{"url" => url}) do
   defp normalize_image(urls) when is_list(urls), do: urls |> List.first() |> normalize_image()
   defp normalize_image(_), do: nil
 
-  defp normalize_also_known_as(aka) when is_list(aka), do: aka
-  defp normalize_also_known_as(aka) when is_binary(aka), do: [aka]
-  defp normalize_also_known_as(nil), do: []
-
   defp object_to_user_data(data, additional) do
     fields =
       data
@@ -1580,7 +1576,6 @@ defp object_to_user_data(data, additional) do
     also_known_as =
       data
       |> Map.get("alsoKnownAs", [])
-      |> normalize_also_known_as()
       |> Enum.filter(fn url ->
         case URI.parse(url) do
           %URI{scheme: "http"} -> true

lib/pleroma/web/activity_pub/mrf/media_proxy_warming_policy.ex

@@ -12,7 +12,7 @@ defmodule Pleroma.Web.ActivityPub.MRF.MediaProxyWarmingPolicy do
   require Logger
 
   @adapter_options [
-    receive_timeout: 10_000
+    recv_timeout: 10_000
   ]
 
   @impl true

lib/pleroma/web/admin_api/views/status_view.ex

@@ -14,11 +14,11 @@ defmodule Pleroma.Web.AdminAPI.StatusView do
   defdelegate merge_account_views(user), to: AdminAPI.AccountView
 
   def render("index.json", %{total: total} = opts) do
-    %{total: total, activities: render_many(opts.activities, __MODULE__, "show.json", opts)}
+    %{total: total, activities: safe_render_many(opts.activities, __MODULE__, "show.json", opts)}
   end
 
   def render("index.json", opts) do
-    render_many(opts.activities, __MODULE__, "show.json", opts)
+    safe_render_many(opts.activities, __MODULE__, "show.json", opts)
   end
 
   def render("show.json", %{activity: %{data: %{"object" => _object}} = activity} = opts) do

lib/pleroma/web/akkoma_api/controllers/metrics_controller.ex

@@ -1,24 +0,0 @@
-defmodule Pleroma.Web.AkkomaAPI.MetricsController do
-  use Pleroma.Web, :controller
-
-  alias Pleroma.Web.Plugs.OAuthScopesPlug
-  alias Pleroma.Config
-
-  plug(
-    OAuthScopesPlug,
-    %{scopes: ["admin:metrics"]}
-    when action in [
-           :show
-         ]
-  )
-
-  def show(conn, _params) do
-    if Config.get([:instance, :export_prometheus_metrics], true) do
-      conn
-      |> text(Pleroma.PrometheusExporter.show())
-    else
-      conn
-      |> send_resp(404, "Not Found")
-    end
-  end
-end

lib/pleroma/web/akkoma_api/controllers/translation_controller.ex

@@ -3,8 +3,6 @@ defmodule Pleroma.Web.AkkomaAPI.TranslationController do
 
   alias Pleroma.Web.Plugs.OAuthScopesPlug
 
-  require Logger
-
   @cachex Pleroma.Config.get([:cachex, :provider], Cachex)
 
   @unauthenticated_access %{fallback: :proceed_unauthenticated, scopes: []}
@@ -28,12 +26,8 @@ def languages(conn, _params) do
       conn
       |> json(%{source: source_languages, target: dest_languages})
     else
-      {:enabled, false} ->
+      {:enabled, false} -> json(conn, %{})
-        json(conn, %{})
+      e -> IO.inspect(e)
-
-      e ->
-        Logger.error("Translation language list error: #{inspect(e)}")
-        {:error, e}
     end
   end
 

lib/pleroma/web/api_spec.ex

@@ -23,19 +23,19 @@ def spec(opts \\ []) do
           []
         end,
       info: %OpenApiSpex.Info{
-        title: "Akkoma API",
+        title: "Pleroma API",
         description: """
-        This is documentation for the Akkoma API. Most of the endpoints and entities come
+        This is documentation for client Pleroma API. Most of the endpoints and entities come
         from Mastodon API and have custom extensions on top.
 
-        While this document aims to be a complete guide to the client API Akkoma exposes,
+        While this document aims to be a complete guide to the client API Pleroma exposes,
-        it may not be complete. Some endpoints may have incomplete or poorly worded documentation.
+        the details are still being worked out. Some endpoints may have incomplete or poorly worded documentation.
         You might want to check the following resources if something is not clear:
         - [Legacy Pleroma-specific endpoint documentation](https://docs-develop.pleroma.social/backend/development/API/pleroma_api/)
         - [Mastodon API documentation](https://docs.joinmastodon.org/client/intro/)
-        - [Differences in Mastodon API responses from vanilla Mastodon](https://docs.akkoma.dev/stable/development/API/differences_in_mastoapi_responses/)
+        - [Differences in Mastodon API responses from vanilla Mastodon](https://docs-develop.pleroma.social/backend/development/API/differences_in_mastoapi_responses/)
 
-        Please report such occurrences on our [issue tracker](https://akkoma.dev/AkkomaGang/akkoma). Feel free to submit API questions or proposals there too!
+        Please report such occurences on our [issue tracker](https://git.pleroma.social/pleroma/pleroma/-/issues). Feel free to submit API questions or proposals there too!
         """,
         # Strip environment from the version
         version: Application.spec(:pleroma, :vsn) |> to_string() |> String.replace(~r/\+.*$/, ""),

lib/pleroma/web/api_spec/operations/account_operation.ex

@@ -64,8 +64,7 @@ def update_credentials_operation do
       requestBody: request_body("Parameters", update_credentials_request(), required: true),
       responses: %{
         200 => Operation.response("Account", "application/json", Account),
-        403 => Operation.response("Error", "application/json", ApiError),
+        403 => Operation.response("Error", "application/json", ApiError)
-        413 => Operation.response("Error", "application/json", ApiError)
       }
     }
   end
@@ -432,7 +431,6 @@ def lookup_operation do
       ],
       responses: %{
         200 => Operation.response("Account", "application/json", Account),
-        401 => Operation.response("Error", "application/json", ApiError),
         404 => Operation.response("Error", "application/json", ApiError)
       }
     }

lib/pleroma/web/api_spec/operations/pleroma_emoji_pack_operation.ex

@@ -231,20 +231,11 @@ defp emoji_packs_response do
       "application/json",
       %Schema{
         type: :object,
-        properties: %{
+        additionalProperties: emoji_pack(),
-          count: %Schema{type: :integer},
-          packs: %Schema{
-            type: :object,
-            additionalProperties: emoji_pack()
-          }
-        },
         example: %{
-          "count" => 4,
-          "packs" => %{
           "emojos" => emoji_pack().example
         }
       }
-      }
     )
   end
 

lib/pleroma/web/api_spec/operations/tag_operation.ex

@@ -44,7 +44,7 @@ def unfollow_operation do
       tags: ["Tags"],
       summary: "Unfollow a hashtag",
       description: "Unfollow a hashtag",
-      security: [%{"oAuth" => ["write:follows"]}],
+      security: [%{"oAuth" => ["write:follow"]}],
       parameters: [id_param()],
       operationId: "TagController.unfollow",
       responses: %{
@@ -54,26 +54,6 @@ def unfollow_operation do
     }
   end
 
-  def show_followed_operation do
-    %Operation{
-      tags: ["Tags"],
-      summary: "Followed hashtags",
-      description: "View a list of hashtags the currently authenticated user is following",
-      parameters: pagination_params(),
-      security: [%{"oAuth" => ["read:follows"]}],
-      operationId: "TagController.show_followed",
-      responses: %{
-        200 =>
-          Operation.response("Hashtags", "application/json", %Schema{
-            type: :array,
-            items: Tag
-          }),
-        403 => Operation.response("Forbidden", "application/json", ApiError),
-        404 => Operation.response("Not Found", "application/json", ApiError)
-      }
-    }
-  end
-
   defp id_param do
     Operation.parameter(
       :id,
@@ -82,22 +62,4 @@ defp id_param do
       "Name of the hashtag"
     )
   end
-
-  def pagination_params do
-    [
-      Operation.parameter(:max_id, :query, :integer, "Return items older than this ID"),
-      Operation.parameter(
-        :min_id,
-        :query,
-        :integer,
-        "Return the oldest items newer than this ID"
-      ),
-      Operation.parameter(
-        :limit,
-        :query,
-        %Schema{type: :integer, default: 20},
-        "Maximum number of items to return. Will be ignored if it's more than 40"
-      )
-    ]
-  end
 end

lib/pleroma/web/api_spec/schemas/tag.ex

@@ -21,12 +21,6 @@ defmodule Pleroma.Web.ApiSpec.Schemas.Tag do
       following: %Schema{
         type: :boolean,
         description: "Whether the authenticated user is following the hashtag"
-      },
-      history: %Schema{
-        type: :array,
-        items: %Schema{type: :string},
-        description:
-          "A list of historical uses of the hashtag (not implemented, for compatibility only)"
       }
     },
     example: %{

lib/pleroma/web/auth/pleroma_authenticator.ex

@@ -6,6 +6,7 @@ defmodule Pleroma.Web.Auth.PleromaAuthenticator do
   alias Pleroma.Registration
   alias Pleroma.Repo
   alias Pleroma.User
+  alias Pleroma.Web.Plugs.AuthenticationPlug
 
   import Pleroma.Web.Auth.Helpers, only: [fetch_credentials: 1, fetch_user: 1]
 
@@ -14,8 +15,8 @@ defmodule Pleroma.Web.Auth.PleromaAuthenticator do
   def get_user(%Plug.Conn{} = conn) do
     with {:ok, {name, password}} <- fetch_credentials(conn),
          {_, %User{} = user} <- {:user, fetch_user(name)},
-         {_, true} <- {:checkpw, Pleroma.Password.checkpw(password, user.password_hash)},
+         {_, true} <- {:checkpw, AuthenticationPlug.checkpw(password, user.password_hash)},
-         {:ok, user} <- Pleroma.Password.maybe_update_password(user, password) do
+         {:ok, user} <- AuthenticationPlug.maybe_update_password(user, password) do
       {:ok, user}
     else
       {:error, _reason} = error -> error
@@ -59,8 +60,6 @@ def get_registration(%Plug.Conn{
   def get_registration(%Plug.Conn{} = _conn), do: {:error, :missing_credentials}
 
   @doc "Creates Pleroma.User record basing on params and Pleroma.Registration record."
-  @spec create_from_registration(Plug.Conn.t(), Registration.t()) ::
-          {:ok, User.t()} | {:error, any()}
   def create_from_registration(
         %Plug.Conn{params: %{"authorization" => registration_attrs}},
         %Registration{} = registration
@@ -90,8 +89,6 @@ def create_from_registration(
          {:ok, _} <-
            Registration.changeset(registration, %{user_id: new_user.id}) |> Repo.update() do
       {:ok, new_user}
-    else
-      err -> err
     end
   end
 

lib/pleroma/web/auth/totp_authenticator.ex

@@ -6,6 +6,7 @@ defmodule Pleroma.Web.Auth.TOTPAuthenticator do
   alias Pleroma.MFA
   alias Pleroma.MFA.TOTP
   alias Pleroma.User
+  alias Pleroma.Web.Plugs.AuthenticationPlug
 
   @doc "Verify code or check backup code."
   @spec verify(String.t(), User.t()) ::
@@ -30,7 +31,7 @@ def verify_recovery_code(
         code
       )
       when is_list(codes) and is_binary(code) do
-    hash_code = Enum.find(codes, fn hash -> Pleroma.Password.checkpw(code, hash) end)
+    hash_code = Enum.find(codes, fn hash -> AuthenticationPlug.checkpw(code, hash) end)
 
     if hash_code do
       MFA.invalidate_backup_code(user, hash_code)

lib/pleroma/web/common_api/activity_draft.ex

@@ -177,7 +177,7 @@ defp to_and_cc(draft) do
   end
 
   defp context(draft) do
-    context = Utils.make_context(draft)
+    context = Utils.make_context(draft.in_reply_to, draft.in_reply_to_conversation)
     %__MODULE__{draft | context: context}
   end