FoundKey/packages/backend
Johann150 804fa33535
refactor: improve code quality (#8751)
* remove unnecessary if

`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.

* perf: use count instead of find

When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.

* remove duplicate null check

The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.

* simplify `getJsonSchema`

Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.

Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.

* remove duplicate condition

The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.

To make this more obvious the `return` is removed in favour of using
an if...else construct.

* remove impossible "unknown" time

The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
..
.vscode Update settings.json 2022-04-15 21:33:00 +09:00
assets feat: use instance icon for splash screen 2022-03-09 23:00:28 +09:00
migration hotfix: uniform color migration fix 2022-05-19 15:42:55 +02:00
src refactor: improve code quality (#8751) 2022-05-29 15:15:52 +09:00
test refactor: use === 2022-05-25 23:19:39 +09:00
.eslintignore use eslint 2021-11-12 10:35:41 +09:00
.eslintrc.cjs test: __dirnameはESModuleでは使えないので置き換えた (#8626) 2022-05-14 16:09:47 +09:00
.mocharc.json Update .mocharc.json 2022-05-21 22:24:57 +09:00
.npmrc refactoring 2021-11-12 02:02:25 +09:00
.yarnrc use eslint 2021-11-12 10:35:41 +09:00
jsconfig.json use eslint 2021-11-12 10:35:41 +09:00
ormconfig.js refactor: migrate to typeorm 3.0 (#8443) 2022-03-26 15:34:00 +09:00
package.json use http-signature module that supports hs2019 (#8635) 2022-05-26 09:12:17 +09:00
tsconfig.json update node to 18 2022-04-23 12:37:44 +09:00
watch.mjs implement dev command 2021-11-19 14:48:59 +09:00
yarn.lock use http-signature module that supports hs2019 (#8635) 2022-05-26 09:12:17 +09:00