fedward/custom-fe
1
0
Fork 0
forked from AkkomaGang/akkoma-fe
Code Issues Pull requests Projects Releases Packages Wiki Activity

Explicitly cast notification ids to integers when using them for setting maxId

Browse source 
This fixes the bug where BE receives incorrect `since_id` when marking
notifications as read.
This commit is contained in:
eugenijm 2019-02-02 17:04:07 +03:00
parent fbe7af3d56
commit 0ab2f17991
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/modules/statuses.js
View file

@ -273,10 +273,11 @@ const addNewNotifications = (state, { dispatch, notifications, older, visibleNot
// Only add a new notification if we don't have one for the same action // Only add a new notification if we don't have one for the same action
if (!state.notifications.idStore.hasOwnProperty(notification.id)) { if (!state.notifications.idStore.hasOwnProperty(notification.id)) {
state.notifications.maxId = notification.id > state.notifications.maxId const notificationId = parseInt(notification.id, 10)
state.notifications.maxId = notificationId > parseInt(state.notifications.maxId, 10)
? notification.id ? notification.id
: state.notifications.maxId : state.notifications.maxId
state.notifications.minId = notification.id < state.notifications.minId state.notifications.minId = notificationId < parseInt(state.notifications.minId, 10)
? notification.id ? notification.id
: state.notifications.minId : state.notifications.minId