[Pleroma.Web.ActivityPub.Transmogrifier]: fix emoji in tag when it’s not in a array [kroeg]

Also simplified the code for name trimming.

And not copying the Map.merge part as it looks buggy.
See: https://queer.hacktivis.me/objects/a9f21ebc-9a12-4a6c-89d5-3d46955c6ee8
This commit is contained in:
Haelwenn (lanodan) Monnier 2018-09-21 14:36:29 +02:00
parent f8a0cb9c0b
commit 28e8a8ab36
No known key found for this signature in database
GPG key ID: D5B7A8E43C997DEE

View file

@ -164,21 +164,13 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
object
end
def fix_emoji(object) do
tags = object["tag"] || []
def fix_emoji(%{"tag" => tags} = object) when is_list(tags) do
emoji = tags |> Enum.filter(fn data -> data["type"] == "Emoji" and data["icon"] end)
emoji =
emoji
|> Enum.reduce(%{}, fn data, mapping ->
name = data["name"]
name =
if String.starts_with?(name, ":") do
name |> String.slice(1..-2)
else
name
end
name = String.trim(data["name"], ":")
mapping |> Map.put(name, data["icon"]["url"])
end)
@ -190,6 +182,18 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier do
|> Map.put("emoji", emoji)
end
def fix_emoji(%{"tag" => %{"type" => "Emoji"} = tag} = object) do
name = String.trim(tag["name"], ":")
emoji = %{name => tag["icon"]["url"]}
object
|> Map.put("emoji", emoji)
end
def fix_emoji(object) do
object
end
def fix_tag(object) do
tags =
(object["tag"] || [])