From 9c411d181a12be738f8dfea05f7899a48408dfda Mon Sep 17 00:00:00 2001
From: Johann150 <johann.galle@protonmail.com>
Date: Thu, 21 Jul 2022 01:17:36 +0200
Subject: [PATCH] fix: volume sliders

Fixed a typo that made a required property be undefined.
Also reduced code duplication.

Fixes https://akkoma.dev/FoundKeyGang/FoundKey/issues/18
---
 packages/client/src/pages/settings/sounds.vue | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/packages/client/src/pages/settings/sounds.vue b/packages/client/src/pages/settings/sounds.vue
index f29c9eb04..287a5a9eb 100644
--- a/packages/client/src/pages/settings/sounds.vue
+++ b/packages/client/src/pages/settings/sounds.vue
@@ -1,6 +1,6 @@
 <template>
 <div class="_formRoot">
-	<FormRange v-model="masterVolume" :min="0" :max="1" :step="0.05" :text-converter="(v) => `${Math.floor(v * 100)}%`" class="_formBlock">
+	<FormRange v-model="masterVolume" :min="0" :max="1" :step="0.05" :text-converter="textConverter" class="_formBlock">
 		<template #label>{{ i18n.ts.masterVolume }}</template>
 	</FormRange>
 
@@ -77,6 +77,8 @@ const soundsTypes = [
 	'noizenecio/kick_gaba2',
 ];
 
+const textConverter = (v) => `${Math.floor(v * 100)}%`;
+
 async function edit(type) {
 	const { canceled, result } = await os.form(i18n.t('_sfx.' + type), {
 		type: {
@@ -90,10 +92,10 @@ async function edit(type) {
 		},
 		volume: {
 			type: 'range',
-			mim: 0,
+			min: 0,
 			max: 1,
 			step: 0.05,
-			textConverter: (v) => `${Math.floor(v * 100)}%`,
+			textConverter,
 			label: i18n.ts.volume,
 			default: sounds.value[type].volume,
 		},