2018-12-23 20:11:29 +00:00
|
|
|
# Pleroma: A lightweight social networking server
|
|
|
|
# Copyright © 2017-2018 Pleroma Authors <https://pleroma.social/>
|
|
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
|
2018-09-22 03:44:19 +00:00
|
|
|
defmodule Pleroma.HTMLTest do
|
|
|
|
alias Pleroma.HTML
|
|
|
|
use Pleroma.DataCase
|
|
|
|
|
|
|
|
@html_sample """
|
|
|
|
<b>this is in bold</b>
|
|
|
|
<p>this is a paragraph</p>
|
|
|
|
this is a linebreak<br />
|
2019-03-17 13:46:46 +00:00
|
|
|
this is a link with allowed "rel" attribute: <a href="http://example.com/" rel="tag">example.com</a>
|
|
|
|
this is a link with not allowed "rel" attribute: <a href="http://example.com/" rel="tag noallowed">example.com</a>
|
2018-09-22 03:44:19 +00:00
|
|
|
this is an image: <img src="http://example.com/image.jpg"><br />
|
|
|
|
<script>alert('hacked')</script>
|
|
|
|
"""
|
|
|
|
|
|
|
|
@html_onerror_sample """
|
|
|
|
<img src="http://example.com/image.jpg" onerror="alert('hacked')">
|
|
|
|
"""
|
|
|
|
|
2019-04-23 22:55:21 +00:00
|
|
|
@html_span_class_sample """
|
|
|
|
<span class="animate-spin">hi</span>
|
|
|
|
"""
|
|
|
|
|
|
|
|
@html_span_microformats_sample """
|
|
|
|
<span class="h-card"><a class="u-url mention">@<span>foo</span></a></span>
|
|
|
|
"""
|
|
|
|
|
|
|
|
@html_span_invalid_microformats_sample """
|
|
|
|
<span class="h-card"><a class="u-url mention animate-spin">@<span>foo</span></a></span>
|
|
|
|
"""
|
|
|
|
|
2018-09-22 03:44:19 +00:00
|
|
|
describe "StripTags scrubber" do
|
|
|
|
test "works as expected" do
|
|
|
|
expected = """
|
|
|
|
this is in bold
|
|
|
|
this is a paragraph
|
|
|
|
this is a linebreak
|
2019-03-17 13:46:46 +00:00
|
|
|
this is a link with allowed "rel" attribute: example.com
|
|
|
|
this is a link with not allowed "rel" attribute: example.com
|
2018-09-22 03:44:19 +00:00
|
|
|
this is an image:
|
|
|
|
alert('hacked')
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected == HTML.strip_tags(@html_sample)
|
|
|
|
end
|
|
|
|
|
|
|
|
test "does not allow attribute-based XSS" do
|
|
|
|
expected = "\n"
|
|
|
|
|
|
|
|
assert expected == HTML.strip_tags(@html_onerror_sample)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "TwitterText scrubber" do
|
|
|
|
test "normalizes HTML as expected" do
|
|
|
|
expected = """
|
|
|
|
this is in bold
|
|
|
|
<p>this is a paragraph</p>
|
|
|
|
this is a linebreak<br />
|
2019-03-17 13:46:46 +00:00
|
|
|
this is a link with allowed "rel" attribute: <a href="http://example.com/" rel="tag">example.com</a>
|
|
|
|
this is a link with not allowed "rel" attribute: <a href="http://example.com/">example.com</a>
|
2018-09-22 03:44:19 +00:00
|
|
|
this is an image: <img src="http://example.com/image.jpg" /><br />
|
|
|
|
alert('hacked')
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected == HTML.filter_tags(@html_sample, Pleroma.HTML.Scrubber.TwitterText)
|
|
|
|
end
|
|
|
|
|
|
|
|
test "does not allow attribute-based XSS" do
|
|
|
|
expected = """
|
|
|
|
<img src="http://example.com/image.jpg" />
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected == HTML.filter_tags(@html_onerror_sample, Pleroma.HTML.Scrubber.TwitterText)
|
|
|
|
end
|
2019-04-23 22:55:21 +00:00
|
|
|
|
|
|
|
test "does not allow spans with invalid classes" do
|
|
|
|
expected = """
|
|
|
|
<span>hi</span>
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected ==
|
|
|
|
HTML.filter_tags(@html_span_class_sample, Pleroma.HTML.Scrubber.TwitterText)
|
|
|
|
end
|
|
|
|
|
|
|
|
test "does allow microformats" do
|
|
|
|
expected = """
|
|
|
|
<span class="h-card"><a class="u-url mention">@<span>foo</span></a></span>
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected ==
|
|
|
|
HTML.filter_tags(@html_span_microformats_sample, Pleroma.HTML.Scrubber.TwitterText)
|
|
|
|
end
|
|
|
|
|
|
|
|
test "filters invalid microformats markup" do
|
|
|
|
expected = """
|
|
|
|
<span class="h-card"><a>@<span>foo</span></a></span>
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected ==
|
|
|
|
HTML.filter_tags(
|
|
|
|
@html_span_invalid_microformats_sample,
|
|
|
|
Pleroma.HTML.Scrubber.TwitterText
|
|
|
|
)
|
|
|
|
end
|
2018-09-22 03:44:19 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "default scrubber" do
|
|
|
|
test "normalizes HTML as expected" do
|
|
|
|
expected = """
|
|
|
|
<b>this is in bold</b>
|
|
|
|
<p>this is a paragraph</p>
|
|
|
|
this is a linebreak<br />
|
2019-03-17 13:46:46 +00:00
|
|
|
this is a link with allowed "rel" attribute: <a href="http://example.com/" rel="tag">example.com</a>
|
|
|
|
this is a link with not allowed "rel" attribute: <a href="http://example.com/">example.com</a>
|
2018-09-22 03:44:19 +00:00
|
|
|
this is an image: <img src="http://example.com/image.jpg" /><br />
|
|
|
|
alert('hacked')
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected == HTML.filter_tags(@html_sample, Pleroma.HTML.Scrubber.Default)
|
|
|
|
end
|
|
|
|
|
|
|
|
test "does not allow attribute-based XSS" do
|
|
|
|
expected = """
|
|
|
|
<img src="http://example.com/image.jpg" />
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected == HTML.filter_tags(@html_onerror_sample, Pleroma.HTML.Scrubber.Default)
|
|
|
|
end
|
2019-04-23 22:55:21 +00:00
|
|
|
|
|
|
|
test "does not allow spans with invalid classes" do
|
|
|
|
expected = """
|
|
|
|
<span>hi</span>
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected == HTML.filter_tags(@html_span_class_sample, Pleroma.HTML.Scrubber.Default)
|
|
|
|
end
|
|
|
|
|
|
|
|
test "does allow microformats" do
|
|
|
|
expected = """
|
|
|
|
<span class="h-card"><a class="u-url mention">@<span>foo</span></a></span>
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected ==
|
|
|
|
HTML.filter_tags(@html_span_microformats_sample, Pleroma.HTML.Scrubber.Default)
|
|
|
|
end
|
|
|
|
|
|
|
|
test "filters invalid microformats markup" do
|
|
|
|
expected = """
|
|
|
|
<span class="h-card"><a>@<span>foo</span></a></span>
|
|
|
|
"""
|
|
|
|
|
|
|
|
assert expected ==
|
|
|
|
HTML.filter_tags(
|
|
|
|
@html_span_invalid_microformats_sample,
|
|
|
|
Pleroma.HTML.Scrubber.Default
|
|
|
|
)
|
|
|
|
end
|
2018-09-22 03:44:19 +00:00
|
|
|
end
|
|
|
|
end
|