forked from AkkomaGang/akkoma
8b843be03e
For some reason I had a test who suddenly failed, mix test test/pleroma/web/o_auth/app_test.exs:54. A user has a list of applications and this test adds them and then sees if the list it gets back is the same as the apps it added.
When I ran mix test a day before I didn't have this problem and when I pushed code today in a different MR, the pipeline succeeded (see https://git.pleroma.social/ilja/pleroma/-/jobs/205827), yet locally it failed. So it seems the test can sometimes succeed and sometimes fail, which makes it untrustworthy.
The failure I see is because the returned list is in reverse order. I assume that's not per sé wrong. You just want to know if the apps you added are actually there. I fixed the test by first ordering the lists before comparing.
AFAICT (and as far as that's relevant) the test got introduced in commit
|
||
|---|---|---|
| .. | ||
| activity_pub | ||
| admin_api | ||
| api_spec | ||
| auth | ||
| common_api | ||
| endpoint | ||
| feed | ||
| mastodon_api | ||
| media_proxy | ||
| metadata | ||
| o_auth | ||
| o_status | ||
| pleroma_api | ||
| plugs | ||
| preload/providers | ||
| push | ||
| rich_media | ||
| static_fe | ||
| twitter_api | ||
| views | ||
| web_finger | ||
| common_api_test.exs | ||
| fallback_test.exs | ||
| federator_test.exs | ||
| manifest_controller_test.exs | ||
| media_proxy_test.exs | ||
| mongoose_im_controller_test.exs | ||
| node_info_test.exs | ||
| rel_me_test.exs | ||
| shout_channel_test.exs | ||
| streamer_test.exs | ||
| uploader_controller_test.exs | ||
| web_finger_test.exs | ||