johan/FoundKey
1
0
Fork 0
forked from FoundKeyGang/FoundKey
Code Issues Pull requests Projects Releases Packages Wiki Activity

server: change JSON.parse/stringify to structuredClone

Browse source 
structuredClone is more typesafe than using JSON.parse and
JSON.stringify.

Now that Node 18.x is the new baseline, this should be safe to use now.

See https://developer.mozilla.org/en-US/docs/Web/API/structuredClone
for details.
This commit is contained in:
Norm 2022-12-13 16:45:04 -05:00
parent a9d3cae511
commit 78717e85d3
Signed by untrusted user: norm
GPG key ID: 7123E30E441E80DE
3 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/backend/src/models/repositories/drive-file.ts
View file

@ -27,9 +27,7 @@ export const DriveFileRepository = db.getRepository(DriveFile).extend({
getPublicProperties(file: DriveFile): DriveFile['properties'] { getPublicProperties(file: DriveFile): DriveFile['properties'] {
if (file.properties.orientation != null) { if (file.properties.orientation != null) {
// TODO const properties = structuredClone(file.properties);
//const properties = structuredClone(file.properties);
const properties = JSON.parse(JSON.stringify(file.properties));
if (file.properties.orientation >= 5) { if (file.properties.orientation >= 5) {
[properties.width, properties.height] = [properties.height, properties.width]; [properties.width, properties.height] = [properties.height, properties.width];
} }

2
packages/backend/src/server/web/manifest.ts
View file

@ -5,7 +5,7 @@ import manifest from './manifest.json' assert { type: 'json' };
export const manifestHandler = async (ctx: Koa.Context): Promise<void> => { export const manifestHandler = async (ctx: Koa.Context): Promise<void> => {
// TODO // TODO
//const res = structuredClone(manifest); //const res = structuredClone(manifest);
const res = JSON.parse(JSON.stringify(manifest)); const res = structuredClone(manifest);
const instance = await fetchMeta(true); const instance = await fetchMeta(true);

4
packages/backend/src/services/relay.ts
View file

@ -96,9 +96,7 @@ export async function deliverToRelays(user: { id: User['id']; host: null; }, act
const relays = await relaysCache.fetch(''); const relays = await relaysCache.fetch('');
if (relays == null || relays.length === 0) return; if (relays == null || relays.length === 0) return;
// TODO const copy = structuredClone(activity);
//const copy = structuredClone(activity);
const copy = JSON.parse(JSON.stringify(activity));
if (!copy.to) copy.to = ['https://www.w3.org/ns/activitystreams#Public']; if (!copy.to) copy.to = ['https://www.w3.org/ns/activitystreams#Public'];
const signed = await attachLdSignature(copy, user); const signed = await attachLdSignature(copy, user);