Chat: Only create them for valid users for now.

This commit is contained in:
lain 2020-04-10 14:47:56 +02:00
parent 2cc6841424
commit 64c78581fe
2 changed files with 14 additions and 0 deletions

View file

@ -26,6 +26,13 @@ defmodule Pleroma.Chat do
def creation_cng(struct, params) do def creation_cng(struct, params) do
struct struct
|> cast(params, [:user_id, :recipient, :unread]) |> cast(params, [:user_id, :recipient, :unread])
|> validate_change(:recipient, fn
:recipient, recipient ->
case User.get_cached_by_ap_id(recipient) do
nil -> [recipient: "must a an existing user"]
_ -> []
end
end)
|> validate_required([:user_id, :recipient]) |> validate_required([:user_id, :recipient])
|> unique_constraint(:user_id, name: :chats_user_id_recipient_index) |> unique_constraint(:user_id, name: :chats_user_id_recipient_index)
end end

View file

@ -10,6 +10,13 @@ defmodule Pleroma.ChatTest do
import Pleroma.Factory import Pleroma.Factory
describe "creation and getting" do describe "creation and getting" do
test "it only works if the recipient is a valid user (for now)" do
user = insert(:user)
assert {:error, _chat} = Chat.bump_or_create(user.id, "http://some/nonexisting/account")
assert {:error, _chat} = Chat.get_or_create(user.id, "http://some/nonexisting/account")
end
test "it creates a chat for a user and recipient" do test "it creates a chat for a user and recipient" do
user = insert(:user) user = insert(:user)
other_user = insert(:user) other_user = insert(:user)