Validators: ObjectID is an http uri.

This commit is contained in:
lain 2020-03-31 16:11:38 +02:00
parent f6835333be
commit 643f15e77b
2 changed files with 50 additions and 4 deletions

View file

@ -4,12 +4,20 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.Types.ObjectID do
def type, do: :string
def cast(object) when is_binary(object) do
with %URI{
scheme: scheme,
host: host
}
when scheme in ["https", "http"] and not is_nil(host) <-
URI.parse(object) do
{:ok, object}
else
_ ->
:error
end
end
def cast(%{"id" => object}) when is_binary(object) do
{:ok, object}
end
def cast(%{"id" => object}), do: cast(object)
def cast(_) do
:error

View file

@ -0,0 +1,38 @@
defmodule Pleroma.Web.ObjectValidators.Types.ObjectIDTest do
alias Pleroma.Web.ActivityPub.ObjectValidators.Types.ObjectID
use Pleroma.DataCase
@uris [
"http://lain.com/users/lain",
"http://lain.com",
"https://lain.com/object/1"
]
@non_uris [
"https://",
"rin"
]
test "it rejects integers" do
assert :error == ObjectID.cast(1)
end
test "it accepts http uris" do
Enum.each(@uris, fn uri ->
assert {:ok, uri} == ObjectID.cast(uri)
end)
end
test "it accepts an object with a nested uri id" do
Enum.each(@uris, fn uri ->
assert {:ok, uri} == ObjectID.cast(%{"id" => uri})
end)
end
test "it rejects non-uri strings" do
Enum.each(@non_uris, fn non_uri ->
assert :error == ObjectID.cast(non_uri)
assert :error == ObjectID.cast(%{"id" => non_uri})
end)
end
end