Revert "Remove newlines completely so mastodon doesn't bug out."

This reverts commit 0ca3ab7b59.

lib/pleroma/web/twitter_api/utils.ex

@@ -15,13 +15,13 @@ def add_attachments(text, attachments) do
         "<a href=\"#{URI.encode(href)}\" class='attachment'>#{Path.basename(href)}</a>"
       _ -> ""
     end)
-    Enum.join([text | attachment_text], "<br />")
+    Enum.join([text | attachment_text], "<br />\n")
   end
 
   def format_input(text, mentions) do
     HtmlSanitizeEx.strip_tags(text)
     |> Formatter.linkify
-    |> String.replace("\n", "<br />")
+    |> String.replace("\n", "<br />\n")
     |> add_user_links(mentions)
   end
 

test/web/twitter_api/twitter_api_test.exs

@@ -33,7 +33,7 @@ test "create a status" do
 
     { :ok, activity = %Activity{} } = TwitterAPI.create_status(user, input)
 
-    assert get_in(activity.data, ["object", "content"]) == "<p>Hello again, <a href='shp'>@shp</a>.<br />This is on another line. #2hu #epic #phantasmagoric<br /><a href=\"http://example.org/image.jpg\" class='attachment'>image.jpg</a></p>"
+    assert get_in(activity.data, ["object", "content"]) == "<p>Hello again, <a href='shp'>@shp</a>.<br />\nThis is on another line. #2hu #epic #phantasmagoric<br />\n<a href=\"http://example.org/image.jpg\" class='attachment'>image.jpg</a></p>"
     assert get_in(activity.data, ["object", "type"]) == "Note"
     assert get_in(activity.data, ["object", "actor"]) == user.ap_id
     assert get_in(activity.data, ["actor"]) == user.ap_id

test/web/twitter_api/twitter_api_utils_test.exs

@@ -9,6 +9,6 @@ test "it adds attachment links to a given text and attachment set" do
 
     res = Utils.add_attachments("", [attachment])
 
-    assert res == "<br /><a href=\"http://heise.de/i%22m%20a%20boy.png\" class='attachment'>i\"m a boy.png</a>"
+    assert res == "<br />\n<a href=\"http://heise.de/i%22m%20a%20boy.png\" class='attachment'>i\"m a boy.png</a>"
   end
 end