forked from AkkomaGang/akkoma
Oneric
5a3c6a6896
Currently logic unconditionally adds public adressing to "cc"
and follower adressing to "to" after attempting to strip it
from the other one. This is horrible for two reasons:
First the bug prompting this investigation and fix,
this creates duplicates when adressing URIs already
were in their intended final field; e.g. prominently
the case for all "unlisted" posts.
Since List.delete only removes the first occurence,
this then broke follower-adress stripping later on.
It’s also not safe in general wrt to non-public adressing:
e.g. pre-existing duplicates didn’t get fully stripped,
bespoke adressing modes with only one of public addressing
or follower addressing — and most importantly:
any belatedly received DM also got public adressing added!
Shockingly this last point was actually checked as "correct" in tests
albeit this appears to be a mistake from mindless match adjustments
from when genuine crashes on nil adressing lists got fixed in
|
||
|---|---|---|
| .. | ||
| activity_pub | ||
| admin_api | ||
| akkoma_api | ||
| api_spec | ||
| auth | ||
| common_api | ||
| feed | ||
| mastodon_api | ||
| media_proxy | ||
| metadata | ||
| o_auth | ||
| o_status | ||
| pleroma_api | ||
| plugs | ||
| preload/providers | ||
| push | ||
| rich_media | ||
| static_fe | ||
| twitter_api | ||
| views | ||
| web_finger | ||
| common_api_test.exs | ||
| embed_controller_test.exs | ||
| fallback_test.exs | ||
| federator_test.exs | ||
| gettext_test.exs | ||
| manifest_controller_test.exs | ||
| masto_fe_controller_test.exs | ||
| media_proxy_test.exs | ||
| mongoose_im_controller_test.exs | ||
| node_info_test.exs | ||
| rel_me_test.exs | ||
| streamer_test.exs | ||
| uploader_controller_test.exs | ||
| web_finger_test.exs | ||
| xml_test.exs | ||