norm
/
foundkey.js
Archived
1
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases Wiki Activity

feat: add type definition for messagingMessage event to main stream channel #30

Merged
Candinya merged 2 commits from feature/messagingMessage into develop 2021-10-17 05:03:43 +00:00
Conversation 1 Commits 2 Files Changed 2 +4
Candinya commented 2021-10-17 04:47:29 +00:00 (Migrated from github.com)
Copy Link

What

add messagingMessage event definition to main stream channel, for clients to receive messages from all instance users.

Why

I think it's somewhat a missing type with full functionality but not employed in SDK yet, so I've made this PR.

Additional info (optional)

I'm not sure if this is dropped out deliberately or just a missing, so if it's preparing to be depreciated, just close this and sorry for the inconvenience I've caused.

<!-- ℹ お読みください PRありがとうございます！ PRを作成する前に、コントリビューションガイドをご確認ください: https://github.com/misskey-dev/misskey.js/blob/develop/CONTRIBUTING.md --> <!-- ℹ README Thank you for your PR! Before creating a PR, please check the contribution guide: https://github.com/misskey-dev/misskey.js/blob/develop/docs/CONTRIBUTING.en.md --> # What <!-- このPRで何をしたのか？ どう変わるのか？ --> <!-- What did you do with this PR? How will it change things? --> add `messagingMessage` event definition to main stream channel, for clients to receive messages from all instance users. # Why <!-- なぜそうするのか？ どういう意図なのか？ 何が困っているのか？ --> <!-- Why do you do it? What are your intentions? What is the problem? --> I think it's somewhat a missing type with full functionality but not employed in SDK yet, so I've made this PR. # Additional info (optional) <!-- テスト観点など --> <!-- Test perspective, etc --> I'm not sure if this is dropped out deliberately or just a missing, so if it's preparing to be depreciated, just close this and sorry for the inconvenience I've caused.
syuilo commented 2021-10-17 05:03:53 +00:00 (Migrated from github.com)
Copy Link

Thanks!

Thanks!
❤️ 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: norm/foundkey.js#30
No description provided.
Delete Branch "feature/messagingMessage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?