changed the way tab-switcher works to avoid removing/adding nodes since that

seems to cause issues, instead hiding nodes with css.
This commit is contained in:
Henry Jameson 2018-11-21 07:38:00 +03:00
parent 50562eb6b7
commit acf414e451
2 changed files with 15 additions and 9 deletions

View file

@ -1,7 +1,5 @@
import Vue from 'vue'
// FIXME: This doesn't like v-if directly inside the tab's contents, breaks vue really bad
import './tab_switcher.scss'
export default Vue.component('tab-switcher', {
@ -27,11 +25,14 @@ export default Vue.component('tab-switcher', {
}
return (<button onClick={this.activateTab(index)} class={ classes.join(' ') }>{slot.data.attrs.label}</button>)
});
const contents = (
<div>
{this.$slots.default.filter(slot => slot.data)[this.active]}
const contents = this.$slots.default.filter(_=>_.data).map(( slot, index ) => {
const active = index === this.active
return (
<div class={active ? 'active' : 'hidden'}>
{slot}
</div>
);
)
});
return (
<div class="tab-switcher">
<div class="tabs">

View file

@ -1,6 +1,11 @@
@import '../../_variables.scss';
.tab-switcher {
.contents {
.hidden {
display: none;
}
}
.tabs {
display: flex;
position: relative;