From f1e66b39c75071f990a49d803ab4b8fd9ac13fb3 Mon Sep 17 00:00:00 2001
From: midnight <midnightsky@posteo.net>
Date: Mon, 8 May 2023 18:52:19 -0400
Subject: [PATCH] Return empty string in the event of no detected language

---
 .../akkoma/translators/libre_translate.ex        |  6 +++---
 .../pleroma/translators/libre_translate_test.exs | 16 ++++++++++++++++
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/lib/pleroma/akkoma/translators/libre_translate.ex b/lib/pleroma/akkoma/translators/libre_translate.ex
index 3a8d9d827..5b08a6384 100644
--- a/lib/pleroma/akkoma/translators/libre_translate.ex
+++ b/lib/pleroma/akkoma/translators/libre_translate.ex
@@ -39,9 +39,9 @@ def translate(string, from_language, to_language) do
       detected =
         if Map.has_key?(body, "detectedLanguage") do
           get_in(body, ["detectedLanguage", "language"])
-        else
-          from_language
-        end
+	else
+          from_language || ""
+	end
 
       {:ok, detected, translated}
     else
diff --git a/test/pleroma/translators/libre_translate_test.exs b/test/pleroma/translators/libre_translate_test.exs
index 3c81c3d76..a93f408f5 100644
--- a/test/pleroma/translators/libre_translate_test.exs
+++ b/test/pleroma/translators/libre_translate_test.exs
@@ -133,5 +133,21 @@ test "should gracefully handle an unsupported language" do
       assert {:error, "libre_translate: request failed (code 400)"} =
                LibreTranslate.translate("ギュギュ握りつぶしちゃうぞ", nil, "zoop")
     end
+
+    test "should work when no detected language is received" do
+      Tesla.Mock.mock(fn
+        %{method: :post, url: "http://libre.translate/translate"} ->
+          %Tesla.Env{
+            status: 200,
+            body:
+              Jason.encode!(%{
+                translatedText: "I will crush you"
+              })
+          }
+      end)
+
+      assert {:ok, "", "I will crush you"} =
+               LibreTranslate.translate("ギュギュ握りつぶしちゃうぞ", nil, "en")
+    end
   end
 end