Fix controlled status display toggles

src/components/status_body/status_body.js

@@ -25,14 +25,16 @@ const StatusContent = {
     'focused',
     'noHeading',
     'fullContent',
-    'singleLine'
+    'singleLine',
+    'showingTall',
+    'expandingSubject',
+    'showingLongSubject',
+    'toggleShowingTall',
+    'toggleExpandingSubject',
+    'toggleShowingLongSubject'
   ],
   data () {
     return {
-      showingTall: this.fullContent || (this.inConversation && this.focused),
-      showingLongSubject: false,
-      // not as computed because it sets the initial state which will be changed later
-      expandingSubject: !this.$store.getters.mergedConfig.collapseMessageWithSubject,
       postLength: this.status.text.length,
       parseReadyDone: false
     }
@@ -113,9 +115,9 @@ const StatusContent = {
     },
     toggleShowMore () {
       if (this.mightHideBecauseTall) {
-        this.showingTall = !this.showingTall
+        this.toggleShowingTall()
       } else if (this.mightHideBecauseSubject) {
-        this.expandingSubject = !this.expandingSubject
+        this.toggleExpandingSubject()
       }
     },
     generateTagLink (tag) {

src/components/status_content/status_content.js

@@ -134,12 +134,8 @@ const StatusContent = {
     toggleExpandingSubject () {
       controlledOrUncontrolledToggle(this, 'expandingSubject')
     },
-    toggleShowMore () {
+    toggleShowingLongSubject () {
-      if (this.mightHideBecauseTall) {
+      controlledOrUncontrolledToggle(this, 'showingLongSubject')
-        this.toggleShowingTall()
-      } else if (this.mightHideBecauseSubject) {
-        this.toggleExpandingSubject()
-      }
     },
     setMedia () {
       const attachments = this.attachmentSize === 'hide' ? this.status.attachments : this.galleryAttachments

src/components/status_content/status_content.vue

@@ -4,6 +4,12 @@
     <StatusBody
       :status="status"
       :single-line="singleLine"
+      :showing-tall="showingTall"
+      :expanding-subject="expandingSubject"
+      :showing-long-subject="showingLongSubject"
+      :toggle-showing-tall="toggleShowingTall"
+      :toggle-expanding-subject="toggleExpandingSubject"
+      :toggle-showing-long-subject="toggleShowingLongSubject"
       @parseReady="$emit('parseReady', $event)"
     >
       <div v-if="status.poll && status.poll.options">