truncate config table on migrate to db task

CHANGELOG.md

@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Store status data inside Flag activity
 - Deprecated (reorganized as `UserRelationship` entity) User fields with user AP IDs (`blocks`, `mutes`, `muted_reblogs`, `muted_notifications`, `subscribers`).
 - Logger: default log level changed from `warn` to `info`.
+- Config mix task `migrate_to_db` truncates `config` table before migrating the config file.
 <details>
   <summary>API Changes</summary>
 

lib/mix/tasks/pleroma/config.ex

@@ -52,6 +52,8 @@ def migrate_to_db(file_path \\ nil) do
 
   defp do_migrate_to_db(config_file) do
     if File.exists?(config_file) do
+      Ecto.Adapters.SQL.query!(Repo, "TRUNCATE config;")
+
       custom_config =
         config_file
         |> read_file()

test/tasks/config_test.exs

@@ -34,21 +34,41 @@ test "error if file with custom settings doesn't exist" do
                    15
   end
 
-  test "settings are migrated to db" do
+  describe "migrate_to_db/1" do
-    initial = Application.get_env(:quack, :level)
+    setup do
-    on_exit(fn -> Application.put_env(:quack, :level, initial) end)
+      initial = Application.get_env(:quack, :level)
-    assert Repo.all(ConfigDB) == []
+      on_exit(fn -> Application.put_env(:quack, :level, initial) end)
+    end
 
-    Mix.Tasks.Pleroma.Config.migrate_to_db("test/fixtures/config/temp.secret.exs")
+    test "settings are migrated to db" do
+      assert Repo.all(ConfigDB) == []
 
-    config1 = ConfigDB.get_by_params(%{group: ":pleroma", key: ":first_setting"})
+      Mix.Tasks.Pleroma.Config.migrate_to_db("test/fixtures/config/temp.secret.exs")
-    config2 = ConfigDB.get_by_params(%{group: ":pleroma", key: ":second_setting"})
-    config3 = ConfigDB.get_by_params(%{group: ":quack", key: ":level"})
-    refute ConfigDB.get_by_params(%{group: ":pleroma", key: "Pleroma.Repo"})
 
-    assert ConfigDB.from_binary(config1.value) == [key: "value", key2: [Repo]]
+      config1 = ConfigDB.get_by_params(%{group: ":pleroma", key: ":first_setting"})
-    assert ConfigDB.from_binary(config2.value) == [key: "value2", key2: ["Activity"]]
+      config2 = ConfigDB.get_by_params(%{group: ":pleroma", key: ":second_setting"})
-    assert ConfigDB.from_binary(config3.value) == :info
+      config3 = ConfigDB.get_by_params(%{group: ":quack", key: ":level"})
+      refute ConfigDB.get_by_params(%{group: ":pleroma", key: "Pleroma.Repo"})
+
+      assert ConfigDB.from_binary(config1.value) == [key: "value", key2: [Repo]]
+      assert ConfigDB.from_binary(config2.value) == [key: "value2", key2: ["Activity"]]
+      assert ConfigDB.from_binary(config3.value) == :info
+    end
+
+    test "config table is truncated before migration" do
+      ConfigDB.create(%{
+        group: ":pleroma",
+        key: ":first_setting",
+        value: [key: "value", key2: ["Activity"]]
+      })
+
+      assert Repo.aggregate(ConfigDB, :count, :id) == 1
+
+      Mix.Tasks.Pleroma.Config.migrate_to_db("test/fixtures/config/temp.secret.exs")
+
+      config = ConfigDB.get_by_params(%{group: ":pleroma", key: ":first_setting"})
+      assert ConfigDB.from_binary(config.value) == [key: "value", key2: [Repo]]
+    end
   end
 
   describe "with deletion temp file" do