forked from AkkomaGang/akkoma
2c55f7d7cb
Current FedSocket implementation has a bunch of problems. It doesn't have proper error handling (in case of an error the server just doesn't respond until the connection is closed, while the client doesn't match any error messages and just assumes there has been an error after 15s) and the code is full of bad descisions (see: fetch registry which uses uuids for no reason and waits for a response by recursively querying a ets table until the value changes, or double JSON encoding). Sometime ago I almost completed rewriting fedsockets from scrach to adress these issues. However, while doing so, I realized that fedsockets are just too overkill for what they were trying to accomplish, which is reduce the overhead of federation by not signing every message. This could be done without reimplementing failure states and endpoint logic we already have with HTTP by, for example, using TLS cert auth, or switching to a more performant signature algorithm. I opened https://git.pleroma.social/pleroma/pleroma/-/issues/2262 for further discussion on alternatives to fedsockets. From discussions I had with other Pleroma developers it seems like they would approve the descision to remove them as well, therefore I am submitting this patch. |
||
|---|---|---|
| .. | ||
| activity/ir | ||
| bbs | ||
| chat | ||
| config | ||
| conversation | ||
| docs | ||
| ecto_type/activity_pub/object_validators | ||
| emails | ||
| emoji | ||
| gun | ||
| http | ||
| instances | ||
| integration | ||
| mfa | ||
| migration_helper | ||
| object | ||
| repo/migrations | ||
| upload | ||
| uploaders | ||
| user | ||
| web | ||
| workers | ||
| activity_test.exs | ||
| application_requirements_test.exs | ||
| bookmark_test.exs | ||
| captcha_test.exs | ||
| chat_test.exs | ||
| config_db_test.exs | ||
| config_test.exs | ||
| conversation_test.exs | ||
| earmark_renderer_test.exs | ||
| emoji_test.exs | ||
| filter_test.exs | ||
| following_relationship_test.exs | ||
| formatter_test.exs | ||
| healthcheck_test.exs | ||
| html_test.exs | ||
| http_test.exs | ||
| instances_test.exs | ||
| job_queue_monitor_test.exs | ||
| keys_test.exs | ||
| list_test.exs | ||
| marker_test.exs | ||
| mfa_test.exs | ||
| moderation_log_test.exs | ||
| notification_test.exs | ||
| object_test.exs | ||
| otp_version_test.exs | ||
| pagination_test.exs | ||
| registration_test.exs | ||
| repo_test.exs | ||
| report_note_test.exs | ||
| reverse_proxy_test.exs | ||
| runtime_test.exs | ||
| safe_jsonb_set_test.exs | ||
| scheduled_activity_test.exs | ||
| signature_test.exs | ||
| stats_test.exs | ||
| upload_test.exs | ||
| user_invite_token_test.exs | ||
| user_relationship_test.exs | ||
| user_search_test.exs | ||
| user_test.exs | ||
| utils_test.exs | ||
| xml_builder_test.exs | ||