From 9723264fe53e15bfef9b830249e8e390fbec0d84 Mon Sep 17 00:00:00 2001
From: FloatingGhost <hannah@coffee-and-dreams.uk>
Date: Sun, 6 Aug 2023 15:51:21 +0100
Subject: [PATCH] Add URI matchers

---
 lib/pleroma/web/plugs/o_auth_scopes_plug.ex |  4 ++-
 test/pleroma/mfa/totp_test.exs              |  9 +++--
 test/support/uri_helpers.ex                 | 37 +++++++++++++++++++++
 3 files changed, 46 insertions(+), 4 deletions(-)
 create mode 100644 test/support/uri_helpers.ex

diff --git a/lib/pleroma/web/plugs/o_auth_scopes_plug.ex b/lib/pleroma/web/plugs/o_auth_scopes_plug.ex
index f017c8bc7..e4d098a7d 100644
--- a/lib/pleroma/web/plugs/o_auth_scopes_plug.ex
+++ b/lib/pleroma/web/plugs/o_auth_scopes_plug.ex
@@ -34,7 +34,9 @@ def perform(%Plug.Conn{assigns: assigns} = conn, %{scopes: scopes} = options) do
         permissions = Enum.join(missing_scopes, " #{op} ")
 
         error_message =
-          dgettext("errors", "Insufficient permissions: %{permissions}.", permissions: permissions)
+          dgettext("errors", "Insufficient permissions: %{permissions}.",
+            permissions: permissions
+          )
 
         conn
         |> put_resp_content_type("application/json")
diff --git a/test/pleroma/mfa/totp_test.exs b/test/pleroma/mfa/totp_test.exs
index 828993866..392f9d02d 100644
--- a/test/pleroma/mfa/totp_test.exs
+++ b/test/pleroma/mfa/totp_test.exs
@@ -6,16 +6,19 @@ defmodule Pleroma.MFA.TOTPTest do
   use Pleroma.DataCase, async: true
 
   alias Pleroma.MFA.TOTP
+  import Pleroma.Test.URIHelpers
 
   test "create provisioning_uri to generate qrcode" do
     uri =
-      TOTP.provisioning_uri("test-secrcet", "test@example.com",
+      TOTP.provisioning_uri("test-secret", "test@example.com",
         issuer: "Plerome-42",
         digits: 8,
         period: 60
       )
 
-    assert uri ==
-             "otpauth://totp/test@example.com?digits=8&issuer=Plerome-42&period=60&secret=test-secrcet"
+    assert_uri_equals(
+      uri,
+      "otpauth://totp/test@example.com?digits=8&issuer=Plerome-42&period=60&secret=test-secret"
+    )
   end
 end
diff --git a/test/support/uri_helpers.ex b/test/support/uri_helpers.ex
new file mode 100644
index 000000000..2fa93a38d
--- /dev/null
+++ b/test/support/uri_helpers.ex
@@ -0,0 +1,37 @@
+defmodule Pleroma.Test.URIHelpers do
+  import ExUnit.Assertions
+
+  def assert_uri_equals(%URI{} = uri_a, %URI{} = uri_b) do
+    [:scheme, :authority, :userinfo, :host, :port, :path, :fragment]
+    |> Enum.each(fn attribute ->
+      if Map.get(uri_a, attribute) == Map.get(uri_b, attribute) do
+        :ok
+      else
+        flunk("Expected #{uri_a} to match #{uri_b} - #{attribute} does not match")
+      end
+    end)
+
+    # And the query string
+    query_a = URI.decode_query(uri_a.query)
+    query_b = URI.decode_query(uri_b.query)
+
+    if query_a == query_b do
+      :ok
+    else
+      flunk(
+        "Expected #{uri_a} to match #{uri_b} - query parameters #{inspect(query_a)} do not match #{inspect(query_b)}"
+      )
+    end
+  end
+
+  def assert_uri_equals(uri_a, uri_b) when is_binary(uri_a) do
+    uri_a
+    |> URI.parse()
+    |> assert_uri_equals(uri_b)
+  end
+
+  def assert_uri_equals(%URI{} = uri_a, uri_b) when is_binary(uri_b) do
+    uri_b = URI.parse(uri_b)
+    assert_uri_equals(uri_a, uri_b)
+  end
+end