From 111cdb0d86f51d0a3f10b77d3f785f68fc9681d4 Mon Sep 17 00:00:00 2001
From: Oneric <oneric@oneric.stub>
Date: Thu, 7 Mar 2024 13:07:02 +0100
Subject: [PATCH] Split steal_emoji function for better readability

---
 .../activity_pub/mrf/steal_emoji_policy.ex    | 44 ++++++++++---------
 1 file changed, 24 insertions(+), 20 deletions(-)

diff --git a/lib/pleroma/web/activity_pub/mrf/steal_emoji_policy.ex b/lib/pleroma/web/activity_pub/mrf/steal_emoji_policy.ex
index 456fe88c5..c743ac3a2 100644
--- a/lib/pleroma/web/activity_pub/mrf/steal_emoji_policy.ex
+++ b/lib/pleroma/web/activity_pub/mrf/steal_emoji_policy.ex
@@ -33,31 +33,35 @@ defp reject_emoji?({shortcode, _url}, installed_emoji) do
     !valid_shortcode? or rejected_shortcode? or emoji_installed?
   end
 
-  defp steal_emoji({shortcode, url}, emoji_dir_path) do
+  defp steal_emoji(%{} = response, {shortcode, url}, emoji_dir_path) do
+    extension =
+      url
+      |> URI.parse()
+      |> Map.get(:path)
+      |> Path.basename()
+      |> Path.extname()
+
+    shortcode = Path.basename(shortcode)
+    file_path = Path.join(emoji_dir_path, shortcode <> (extension || ".png"))
+
+    case File.write(file_path, response.body) do
+      :ok ->
+        shortcode
+
+      e ->
+        Logger.warning("MRF.StealEmojiPolicy: Failed to write to #{file_path}: #{inspect(e)}")
+        nil
+    end
+  end
+
+  defp maybe_steal_emoji({shortcode, url}, emoji_dir_path) do
     url = Pleroma.Web.MediaProxy.url(url)
 
     with {:ok, %{status: status} = response} when status in 200..299 <- Pleroma.HTTP.get(url) do
       size_limit = Config.get([:mrf_steal_emoji, :size_limit], 50_000)
 
       if byte_size(response.body) <= size_limit do
-        extension =
-          url
-          |> URI.parse()
-          |> Map.get(:path)
-          |> Path.basename()
-          |> Path.extname()
-
-        shortcode = Path.basename(shortcode)
-        file_path = Path.join(emoji_dir_path, shortcode <> (extension || ".png"))
-
-        case File.write(file_path, response.body) do
-          :ok ->
-            shortcode
-
-          e ->
-            Logger.warning("MRF.StealEmojiPolicy: Failed to write to #{file_path}: #{inspect(e)}")
-            nil
-        end
+        steal_emoji(response, {shortcode, url}, emoji_dir_path)
       else
         Logger.debug(
           "MRF.StealEmojiPolicy: :#{shortcode}: at #{url} (#{byte_size(response.body)} B) over size limit (#{size_limit} B)"
@@ -90,7 +94,7 @@ def filter(%{"object" => %{"emoji" => foreign_emojis, "actor" => actor}} = messa
       new_emojis =
         foreign_emojis
         |> Enum.reject(&reject_emoji?(&1, installed_emoji))
-        |> Enum.map(&steal_emoji(&1, emoji_dir_path))
+        |> Enum.map(&maybe_steal_emoji(&1, emoji_dir_path))
         |> Enum.filter(& &1)
 
       if !Enum.empty?(new_emojis) do