cosmetic: fix concurrent index creation warnings

Since those old migrations will now most likely only run during db init,
there’s not much point in running them in the background concurrently
anyway, so just drop the cncurrent setting rather than disabling
migration locks.
This commit is contained in:
Oneric 2024-06-19 02:05:38 +02:00
parent c3069b9478
commit 1a4238bf98
17 changed files with 14 additions and 58 deletions

View file

@ -1,12 +1,10 @@
defmodule Pleroma.Repo.Migrations.AddContextIndex do defmodule Pleroma.Repo.Migrations.AddContextIndex do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create( create(
index(:activities, ["(data->>'type')", "(data->>'context')"], index(:activities, ["(data->>'type')", "(data->>'context')"],
name: :activities_context_index, name: :activities_context_index
concurrently: true
) )
) )
end end

View file

@ -1,11 +1,9 @@
defmodule Pleroma.Repo.Migrations.AddFTSIndexToActivities do defmodule Pleroma.Repo.Migrations.AddFTSIndexToActivities do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create( create(
index(:activities, ["(to_tsvector('english', data->'object'->>'content'))"], index(:activities, ["(to_tsvector('english', data->'object'->>'content'))"],
concurrently: true,
using: :gin, using: :gin,
name: :activities_fts name: :activities_fts
) )

View file

@ -1,12 +1,9 @@
defmodule Pleroma.Repo.Migrations.AddTagIndex do defmodule Pleroma.Repo.Migrations.AddTagIndex do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create( create(
index(:activities, ["(data #> '{\"object\",\"tag\"}')"], index(:activities, ["(data #> '{\"object\",\"tag\"}')"],
concurrently: true,
using: :gin, using: :gin,
name: :activities_tags name: :activities_tags
) )

View file

@ -1,8 +1,6 @@
defmodule Pleroma.Repo.Migrations.AddSecondObjectIndexToActivty do defmodule Pleroma.Repo.Migrations.AddSecondObjectIndexToActivty do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
drop_if_exists( drop_if_exists(
index(:activities, ["(data->'object'->>'id')", "(data->>'type')"], index(:activities, ["(data->'object'->>'id')", "(data->>'type')"],
@ -12,8 +10,7 @@ def change do
create( create(
index(:activities, ["(coalesce(data->'object'->>'id', data->>'object'))"], index(:activities, ["(coalesce(data->'object'->>'id', data->>'object'))"],
name: :activities_create_objects_index, name: :activities_create_objects_index
concurrently: true
) )
) )
end end

View file

@ -1,14 +1,7 @@
defmodule Pleroma.Repo.Migrations.AddObjectActorIndex do defmodule Pleroma.Repo.Migrations.AddObjectActorIndex do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create( create(index(:objects, ["(data->>'actor')", "(data->>'type')"], name: :objects_actor_type))
index(:objects, ["(data->>'actor')", "(data->>'type')"],
concurrently: true,
name: :objects_actor_type
)
)
end end
end end

View file

@ -1,14 +1,12 @@
defmodule Pleroma.Repo.Migrations.AddActorToActivity do defmodule Pleroma.Repo.Migrations.AddActorToActivity do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def up do def up do
alter table(:activities) do alter table(:activities) do
add(:actor, :string) add(:actor, :string)
end end
create(index(:activities, [:actor, "id DESC NULLS LAST"], concurrently: true)) create(index(:activities, [:actor, "id DESC NULLS LAST"]))
end end
def down do def down do

View file

@ -1,8 +1,7 @@
defmodule Pleroma.Repo.Migrations.AddSortIndexToActivities do defmodule Pleroma.Repo.Migrations.AddSortIndexToActivities do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create(index(:activities, ["id desc nulls last"], concurrently: true)) create(index(:activities, ["id desc nulls last"]))
end end
end end

View file

@ -1,9 +1,8 @@
defmodule Pleroma.Repo.Migrations.AddFollowerAddressIndexToUsers do defmodule Pleroma.Repo.Migrations.AddFollowerAddressIndexToUsers do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create(index(:users, [:follower_address], concurrently: true)) create(index(:users, [:follower_address]))
create(index(:users, [:following], concurrently: true, using: :gin)) create(index(:users, [:following], using: :gin))
end end
end end

View file

@ -1,9 +1,8 @@
defmodule Pleroma.Repo.Migrations.ModifyActivityIndex do defmodule Pleroma.Repo.Migrations.ModifyActivityIndex do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create(index(:activities, ["id desc nulls last", "local"], concurrently: true)) create(index(:activities, ["id desc nulls last", "local"]))
drop_if_exists(index(:activities, ["id desc nulls last"])) drop_if_exists(index(:activities, ["id desc nulls last"]))
end end
end end

View file

@ -1,13 +1,7 @@
defmodule Pleroma.Repo.Migrations.CreateApidHostExtractionIndex do defmodule Pleroma.Repo.Migrations.CreateApidHostExtractionIndex do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create( create(index(:activities, ["(split_part(actor, '/', 3))"], name: :activities_hosts))
index(:activities, ["(split_part(actor, '/', 3))"],
concurrently: true,
name: :activities_hosts
)
)
end end
end end

View file

@ -1,13 +1,7 @@
defmodule Pleroma.Repo.Migrations.CreateActivitiesInReplyToIndex do defmodule Pleroma.Repo.Migrations.CreateActivitiesInReplyToIndex do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create( create(index(:activities, ["(data->'object'->>'inReplyTo')"], name: :activities_in_reply_to))
index(:activities, ["(data->'object'->>'inReplyTo')"],
concurrently: true,
name: :activities_in_reply_to
)
)
end end
end end

View file

@ -1,6 +1,5 @@
defmodule Pleroma.Repo.Migrations.AddVisibilityFunction do defmodule Pleroma.Repo.Migrations.AddVisibilityFunction do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def up do def up do
definition = """ definition = """
@ -30,8 +29,7 @@ def up do
create( create(
index(:activities, ["activity_visibility(actor, recipients, data)"], index(:activities, ["activity_visibility(actor, recipients, data)"],
name: :activities_visibility_index, name: :activities_visibility_index
concurrently: true
) )
) )
end end

View file

@ -1,11 +1,9 @@
defmodule Pleroma.Repo.Migrations.AddActivitiesLikesIndex do defmodule Pleroma.Repo.Migrations.AddActivitiesLikesIndex do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create( create(
index(:activities, ["((data #> '{\"object\",\"likes\"}'))"], index(:activities, ["((data #> '{\"object\",\"likes\"}'))"],
concurrently: true,
name: :activities_likes, name: :activities_likes,
using: :gin using: :gin
) )

View file

@ -1,6 +1,5 @@
defmodule Pleroma.Repo.Migrations.AddCorrectDMIndex do defmodule Pleroma.Repo.Migrations.AddCorrectDMIndex do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def up do def up do
drop_if_exists( drop_if_exists(
@ -12,7 +11,6 @@ def up do
create( create(
index(:activities, ["activity_visibility(actor, recipients, data)", "id DESC NULLS LAST"], index(:activities, ["activity_visibility(actor, recipients, data)", "id DESC NULLS LAST"],
name: :activities_visibility_index, name: :activities_visibility_index,
concurrently: true,
where: "data->>'type' = 'Create'" where: "data->>'type' = 'Create'"
) )
) )
@ -22,7 +20,6 @@ def down do
drop_if_exists( drop_if_exists(
index(:activities, ["activity_visibility(actor, recipients, data)", "id DESC"], index(:activities, ["activity_visibility(actor, recipients, data)", "id DESC"],
name: :activities_visibility_index, name: :activities_visibility_index,
concurrently: true,
where: "data->>'type' = 'Create'" where: "data->>'type' = 'Create'"
) )
) )

View file

@ -1,13 +1,11 @@
defmodule Pleroma.Repo.Migrations.AddIndexOnSubscribers do defmodule Pleroma.Repo.Migrations.AddIndexOnSubscribers do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create( create(
index(:users, ["(info->'subscribers')"], index(:users, ["(info->'subscribers')"],
name: :users_subscribers_index, name: :users_subscribers_index,
using: :gin, using: :gin
concurrently: true
) )
) )
end end

View file

@ -1,8 +1,7 @@
defmodule Pleroma.Repo.Migrations.AddFollowingAddressIndexToUser do defmodule Pleroma.Repo.Migrations.AddFollowingAddressIndexToUser do
use Ecto.Migration use Ecto.Migration
@disable_ddl_transaction true
def change do def change do
create(index(:users, [:following_address], concurrently: true)) create(index(:users, [:following_address]))
end end
end end

View file

@ -100,7 +100,7 @@ def update_follower_count(%{id: user_id} = user) do
"users" "users"
|> where(id: ^user_id) |> where(id: ^user_id)
|> join(:inner, [u], s in subquery(follower_count_query)) |> join(:inner, [u], s in subquery(follower_count_query), on: true)
|> update([u, s], |> update([u, s],
set: [follower_count: s.count] set: [follower_count: s.count]
) )