Separated tab-switcher into a reusable component. This depends on JSX addition

src/components/tab_switcher/tab_switcher.jsx

@@ -0,0 +1,44 @@
+import Vue from 'vue'
+
+import './tab_switcher.scss'
+
+export default Vue.component('tab-switcher', {
+  name: 'TabSwitcher',
+  data () {
+    return {
+      active: 0
+    }
+  },
+  methods: {
+    activateTab(index) {
+      return () => this.active = index;
+    }
+  },
+  render(h) {
+    const tabs = this.$slots.default
+          .filter(slot => slot.data)
+          .map((slot, index) => {
+            const classes = ['tab']
+
+            if (index === this.active) {
+              classes.push('active')
+            }
+            return (<button onClick={this.activateTab(index)} class={ classes.join(' ') }>{slot.data.attrs.title}</button>)
+          });
+    const contents = (
+      <div>
+        {this.$slots.default.filter(slot => slot.data)[this.active]}
+      </div>
+    );
+    return (
+      <div class="tab-switcher">
+        <div class="tabs">
+          {tabs}
+        </div>
+        <div class="contents">
+          {contents}
+        </div>
+      </div>
+    )
+  }
+})

src/components/tab_switcher/tab_switcher.scss

@@ -0,0 +1,47 @@
+@import '../../_variables.scss';
+
+.tab-switcher {
+  .tabs {
+    display: flex;
+    position: relative;
+    justify-content: center;
+    width: 100%;
+    overflow: hidden;
+    padding-top: 5px;
+
+    &::after, &::before {
+      display: block;
+      content: '';
+      flex: 1 1 auto;
+    }
+
+    .tab, &::after, &::before {
+      border-bottom: 1px solid;
+      border-bottom-color: $fallback--btn;
+      border-bottom-color: var(--btn, $fallback--btn);
+    }
+
+    .tab {
+      border-bottom-left-radius: 0;
+      border-bottom-right-radius: 0;
+      padding: .3em 1em;
+
+      &::-moz-focus-inner {
+        border: none;
+      }
+
+      &:not(.active) {
+        border-bottom: 1px solid;
+        border-bottom-color: $fallback--btn;
+        border-bottom-color: var(--btn, $fallback--btn);
+        z-index: 4;
+      }
+
+      &.active {
+        background: transparent;
+        border-bottom: none;
+        z-index: 5;
+      }
+    }
+  }
+}

src/components/user_settings/user_settings.js

@@ -1,3 +1,4 @@
+import TabSwitcher from '../tab_switcher/tab_switcher.jsx'
 import StyleSwitcher from '../style_switcher/style_switcher.vue'
 
 const UserSettings = {
@@ -23,7 +24,8 @@ const UserSettings = {
     }
   },
   components: {
-    StyleSwitcher
+    StyleSwitcher,
+    TabSwitcher
   },
   computed: {
     user () {

src/components/user_settings/user_settings.vue

@@ -4,12 +4,9 @@
       {{$t('settings.user_settings')}}
     </div>
     <div class="panel-body profile-edit">
-      <div class="tab-switcher">
+      <tab-switcher>
-        <button class="btn btn-default" @click="activateTab('profile')">{{$t('settings.profile_tab')}}</button>
+        <div :title="$t('settings.profile_tab')">
-        <button class="btn btn-default" @click="activateTab('security')">{{$t('settings.security_tab')}}</button>
+          <div class="setting-item" >
-        <button class="btn btn-default" @click="activateTab('data_import_export')" v-if="pleromaBackend">{{$t('settings.data_import_export_tab')}}</button>
-      </div>
-      <div class="setting-item" v-if="activeTab == 'profile'">
             <h2>{{$t('settings.name_bio')}}</h2>
             <p>{{$t('settings.name')}}</p>
             <input class='name-changer' id='username' v-model="newname"></input>
@@ -30,7 +27,7 @@
             </div>
             <button :disabled='newname.length <= 0' class="btn btn-default" @click="updateProfile">{{$t('general.submit')}}</button>
           </div>
-      <div class="setting-item" v-if="activeTab == 'profile'">
+          <div class="setting-item">
             <h2>{{$t('settings.avatar')}}</h2>
             <p>{{$t('settings.current_avatar')}}</p>
             <img :src="user.profile_image_url_original" class="old-avatar"></img>
@@ -43,7 +40,7 @@
             <i class="icon-spin4 animate-spin" v-if="uploading[0]"></i>
             <button class="btn btn-default" v-else-if="previews[0]" @click="submitAvatar">{{$t('general.submit')}}</button>
           </div>
-      <div class="setting-item" v-if="activeTab == 'profile'">
+          <div class="setting-item">
             <h2>{{$t('settings.profile_banner')}}</h2>
             <p>{{$t('settings.current_profile_banner')}}</p>
             <img :src="user.cover_photo" class="banner"></img>
@@ -56,7 +53,7 @@
             <i class=" icon-spin4 animate-spin uploading" v-if="uploading[1]"></i>
             <button class="btn btn-default" v-else-if="previews[1]" @click="submitBanner">{{$t('general.submit')}}</button>
           </div>
-      <div class="setting-item" v-if="activeTab == 'profile'">
+          <div class="setting-item">
             <h2>{{$t('settings.profile_background')}}</h2>
             <p>{{$t('settings.set_new_profile_background')}}</p>
             <img class="bg" v-bind:src="previews[2]" v-if="previews[2]">
@@ -67,7 +64,10 @@
             <i class=" icon-spin4 animate-spin uploading" v-if="uploading[2]"></i>
             <button class="btn btn-default" v-else-if="previews[2]" @click="submitBg">{{$t('general.submit')}}</button>
           </div>
-      <div class="setting-item" v-if="activeTab == 'security'">
+        </div>
+
+        <div :title="$t('settings.security_tab')">
+          <div class="setting-item">
             <h2>{{$t('settings.change_password')}}</h2>
             <div>
               <p>{{$t('settings.current_password')}}</p>
@@ -86,7 +86,24 @@
             <p v-else-if="changePasswordError !== false">{{$t('settings.change_password_error')}}</p>
             <p v-if="changePasswordError">{{changePasswordError}}</p>
           </div>
-      <div class="setting-item" v-if="pleromaBackend && activeTab == 'data_import_export'">
+
+          <div class="setting-item">
+            <h2>{{$t('settings.delete_account')}}</h2>
+            <p v-if="!deletingAccount">{{$t('settings.delete_account_description')}}</p>
+            <div v-if="deletingAccount">
+              <p>{{$t('settings.delete_account_instructions')}}</p>
+              <p>{{$t('login.password')}}</p>
+              <input type="password" v-model="deleteAccountConfirmPasswordInput">
+              <button class="btn btn-default" @click="deleteAccount">{{$t('settings.delete_account')}}</button>
+            </div>
+            <p v-if="deleteAccountError !== false">{{$t('settings.delete_account_error')}}</p>
+            <p v-if="deleteAccountError">{{deleteAccountError}}</p>
+            <button class="btn btn-default" v-if="!deletingAccount" @click="confirmDelete">{{$t('general.submit')}}</button>
+          </div>
+        </div>
+
+        <div :title="$t('settings.data_import_export_tab')" v-if="pleromaBackend">
+          <div class="setting-item">
             <h2>{{$t('settings.follow_import')}}</h2>
             <p>{{$t('settings.import_followers_from_a_csv_file')}}</p>
             <form v-model="followImportForm">
@@ -103,27 +120,15 @@
               <p>{{$t('settings.follow_import_error')}}</p>
             </div>
           </div>
-      <div class="setting-item" v-if="enableFollowsExport && activeTab == 'data_import_export'">
+          <div class="setting-item" v-if="enableFollowsExport">
             <h2>{{$t('settings.follow_export')}}</h2>
             <button class="btn btn-default" @click="exportFollows">{{$t('settings.follow_export_button')}}</button>
           </div>
-      <div class="setting-item" v-else-if="activeTab == 'data_import_export'">
+          <div class="setting-item" v-else>
             <h2>{{$t('settings.follow_export_processing')}}</h2>
           </div>
-      <hr>
-      <div class="setting-item" v-if="activeTab == 'security'">
-        <h2>{{$t('settings.delete_account')}}</h2>
-        <p v-if="!deletingAccount">{{$t('settings.delete_account_description')}}</p>
-        <div v-if="deletingAccount">
-          <p>{{$t('settings.delete_account_instructions')}}</p>
-          <p>{{$t('login.password')}}</p>
-          <input type="password" v-model="deleteAccountConfirmPasswordInput">
-          <button class="btn btn-default" @click="deleteAccount">{{$t('settings.delete_account')}}</button>
-        </div>
-        <p v-if="deleteAccountError !== false">{{$t('settings.delete_account_error')}}</p>
-        <p v-if="deleteAccountError">{{deleteAccountError}}</p>
-        <button class="btn btn-default" v-if="!deletingAccount" @click="confirmDelete">{{$t('general.submit')}}</button>
         </div>
+      </tab-switcher>
     </div>
   </div>
 </template>
@@ -151,13 +156,4 @@
     margin: 0.25em;
   }
 }
-
-.tab-switcher {
-  margin: 7px 7px;
-  display: inline-block;
-
-  button {
-    height: 30px;
-  }
-}
 </style>