From ca7f24064304945587fc232325dce4b834ff6c94 Mon Sep 17 00:00:00 2001
From: Ivan Tashkinov <ivantashkinov@gmail.com>
Date: Thu, 21 Jan 2021 20:50:06 +0300
Subject: [PATCH] [#3213] Ignoring of blank elements from objects.data->tag.

---
 lib/pleroma/object.ex         |  2 ++
 test/pleroma/hashtag_test.exs | 17 +++++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 test/pleroma/hashtag_test.exs

diff --git a/lib/pleroma/object.ex b/lib/pleroma/object.ex
index 5102be1de..9b5c1bec1 100644
--- a/lib/pleroma/object.ex
+++ b/lib/pleroma/object.ex
@@ -420,6 +420,8 @@ def object_data_hashtags(%{"tag" => tags}) when is_list(tags) do
       hashtag when is_bitstring(hashtag) -> String.downcase(hashtag)
     end)
     |> Enum.uniq()
+    # Note: "" elements (plain text) might occur in `data.tag` for incoming objects
+    |> Enum.filter(&(&1 not in [nil, ""]))
   end
 
   def object_data_hashtags(_), do: []
diff --git a/test/pleroma/hashtag_test.exs b/test/pleroma/hashtag_test.exs
new file mode 100644
index 000000000..0264dea0b
--- /dev/null
+++ b/test/pleroma/hashtag_test.exs
@@ -0,0 +1,17 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.HashtagTest do
+  use Pleroma.DataCase
+
+  alias Pleroma.Hashtag
+
+  describe "changeset validations" do
+    test "ensure non-blank :name" do
+      changeset = Hashtag.changeset(%Hashtag{}, %{name: ""})
+
+      assert {:name, {"can't be blank", [validation: :required]}} in changeset.errors
+    end
+  end
+end