804fa33535
refactor: improve code quality ( #8751 )
...
* remove unnecessary if
`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.
* perf: use count instead of find
When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.
* remove duplicate null check
The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.
* simplify `getJsonSchema`
Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.
Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.
* remove duplicate condition
The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.
To make this more obvious the `return` is removed in favour of using
an if...else construct.
* remove impossible "unknown" time
The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
tamaina
f1d2398eac
fix(client): Vite related boot mechanism revision ( #8753 )
...
* preload app css
* remove salt
* APP_FETCH_FAILED error
* set max-age to 15s
2022-05-29 10:58:54 +09:00
tamaina
4917961736
preload app css ( #8752 )
2022-05-29 10:57:06 +09:00
e54aa56ee1
chore: remove unused imports
2022-05-28 21:17:23 +02:00
21d54f2758
fix: validate text is not empty
...
fix #8747
2022-05-28 17:26:17 +02:00
161659de5c
enhance: replace signin CAPTCHA with rate limit ( #8740 )
...
* enhance: rate limit works without signed in user
* fix: make limit key required for limiter
As before the fallback limiter key will be set from the endpoint name.
* enhance: use limiter for signin
* Revert "CAPTCHA求めるのは2fa認証が無効になっているときだけにした"
This reverts commit 02a43a310fb21b058005
2022-05-28 12:06:47 +09:00
63a814c70e
fix(docs): correct information for drive upload ( #8736 )
2022-05-27 22:03:25 +09:00
9c80403072
use http-signature module that supports hs2019 ( #8635 )
2022-05-26 09:12:17 +09:00
syuilo
b3ad04fcb0
update deps
2022-05-25 23:28:56 +09:00
syuilo
3c3140a100
refactor: use ===
2022-05-25 23:19:39 +09:00
8d5c9e96e4
fix: assume remote users are following each other ( #8734 )
...
Misskey does not know if two remote users are following each other.
Because ActivityPub actions would otherwise fail on followers only
notes, we have to assume that two remote users are following each other
when an interaction about a remote note occurs.
2022-05-25 23:17:00 +09:00
e27c6abaea
refactor: temporary files ( #8713 )
...
* simplify temporary files for thumbnails
Because only a single file will be written to the directory, creating a
separate directory seems unnecessary. If only a temporary file is created,
the code from `createTemp` can be reused here as well.
* refactor: deduplicate code for temporary files/directories
To follow the DRY principle, the same code should not be duplicated
across different files. Instead an already existing function is used.
Because temporary directories are also create in multiple locations,
a function for this is also newly added to reduce duplication.
* fix: clean up identicon temp files
The temporary files for identicons are not reused and can be deleted
after they are fully read. This condition is met when the stream is closed
and so the file can be cleaned up using the events API of the stream.
* fix: ensure cleanup is called when download fails
* fix: ensure cleanup is called in error conditions
This covers import/export queue jobs and is mostly just wrapping all
code in a try...finally statement where the finally runs the cleanup.
* fix: use correct type instead of `any`
2022-05-25 16:50:22 +09:00
MeiMei
6b44fe165b
Supports Unicode Emoji 14.0 ( #8699 )
...
* Unicode 14.0 Emoji
* mfm-js@0.22.0
* CHANGELOG
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2022-05-25 16:35:30 +09:00
6b109c7b0f
fix: wrong type for isVisibleForMe
2022-05-24 10:12:42 +02:00
syuilo
53fc1235d7
Update .mocharc.json
2022-05-21 22:24:57 +09:00
syuilo
b8544814ec
lint
2022-05-21 22:21:41 +09:00
syuilo
05c4d6b11e
refactor
2022-05-21 22:07:11 +09:00
syuilo
425084b596
Update utils.ts
2022-05-21 22:07:01 +09:00
syuilo
2205c61edf
Update utils.ts
2022-05-21 17:40:43 +09:00
68f9341e95
hotfix: uniform color migration fix
2022-05-19 15:42:55 +02:00
edfded7fb7
fix(activitypub): add authorization checks ( #8534 )
...
* fix spelling
* fix(activitypub): add authorization checks
2022-05-19 20:40:16 +09:00
aaf5bb62ab
enhance: uniform theme color ( #8702 )
...
* enhance: make theme color format uniform
All newly fetched instance theme colors will be uniformely formatted
as hashtag followed by 6 hexadecimal digits.
Colors are checked for validity and invalid colors are not handled.
* better input validation for own theme color
* migration to unify theme color formats
Fixes theme colors of other instances as well as the local instance.
* add changelog entry
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2022-05-19 09:54:45 +02:00
MeiMei
55a578a8df
fix: Unable to generate video thumbnails ( #8696 )
...
* fix: Unable to generate video thumbnails
* CHANGELOG
2022-05-19 16:19:23 +09:00
syuilo
4fc2058745
chore(client): tweak loading spinner design
2022-05-19 15:24:35 +09:00
dependabot[bot]
13b275773b
chore(deps): bump async from 3.2.0 to 3.2.3 in /packages/backend ( #8706 )
...
Bumps [async](https://github.com/caolan/async ) from 3.2.0 to 3.2.3.
- [Release notes](https://github.com/caolan/async/releases )
- [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md )
- [Commits](https://github.com/caolan/async/compare/v3.2.0...v3.2.3 )
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-19 11:49:59 +09:00
MeiMei
b6794b614b
enhance: Perform port diagnosis at startup only when Listen fails ( #8698 )
...
* Change port check
* Comment: disableClustering
* CHANGELOG
* Smart message
2022-05-19 11:49:07 +09:00
037ca92275
fix: postgres type error
...
Fix a bug introduced in #8659 . Solution was already tested there.
2022-05-15 11:32:00 +02:00
syuilo
02a43a310f
CAPTCHA求めるのは2fa認証が無効になっているときだけにした
...
2faのトークンは期限付きだから、CAPTCHA解いてる間に期限切れになる
2022-05-15 16:47:14 +09:00
syuilo
b21b058005
feat: make captcha required when signin to improve security
2022-05-15 12:18:46 +09:00
syuilo
6de40cf789
fix(server): prevent crash when processing certain PNGs
...
Fix #8605
2022-05-15 01:16:12 +09:00
iwata
67e1ee41c9
test: Nodeのカスタムローダーを直してテストが動くように ( #8625 )
...
* test: Nodeのカスタムローダーを直してテストが動くように
* dev: mochaを呼ぶコマンドにNODE_ENV=testを追加
* Update packages/backend/test/loader.js
Co-authored-by: Johann150 <johann@qwertqwefsday.eu>
* chore: change export style in loader.js
Co-authored-by: Johann150 <johann@qwertqwefsday.eu>
2022-05-14 16:10:20 +09:00
iwata
ebb4308a5c
test: __dirnameはESModuleでは使えないので置き換えた ( #8626 )
2022-05-14 16:09:47 +09:00
tamaina
b2a5076d14
fix: ユーザー検索で、クエリがusernameの条件を満たす場合はusernameもLIKE検索するように ( #8644 )
...
* Fix #8643
* 部分一致にする
2022-05-14 15:24:44 +09:00
iwata
22bb1a1793
test: e2eテストがCIで失敗していた問題をいくつか修正 ( #8642 )
...
* test: indexeddbをテスト毎に初期化するように
* fix: metaが無いときにfetch-metaを同時に呼ぶと死ぬことがある問題を修正
* test: ログイン後のクライアント側処理を待たずにリロードされてログイン出来ないことがあったのを修正
2022-05-14 15:16:45 +09:00
4b872856c2
fix: keep file order ( #8659 )
2022-05-14 15:09:10 +09:00
syuilo
98e42ec6ff
enhance: Display TOTP Register URL
...
Close #7261
Co-Authored-By: tamaina <tamaina@hotmail.co.jp>
2022-05-14 15:00:15 +09:00
syuilo
e161b71651
update deps
2022-05-14 14:57:51 +09:00
89c5fd0931
perf: fix caching ( #8660 )
...
The cache implementation did previously not store the results of the
computation and was thus not a cache at all. This can cause a significant
number of database queries each time someone with a large number of
followers does something that causes an activity to be federated.
2022-05-14 13:28:27 +09:00
31c73fdfa2
chore: synchronize code and database schema ( #8577 )
...
* chore: remove default null
null is always the default value if a table column is nullable, and typeorm's
@Column only accepts strings for default.
* chore: synchronize code with database schema
* chore: sync generated migrations with code
2022-05-05 22:45:22 +09:00
tamaina
a89003b57a
refactor: use Vite to build instead of webpack ( #8575 )
...
* update stream.ts
* https://github.com/misskey-dev/misskey/pull/7769#issuecomment-917542339
* fix lint
* clean up?
* add app
* fix
* nanka iroiro
* wip
* wip
* fix lint
* fix loginId
* fix
* refactor
* refactor
* remove follow action
* clean up
* Revert "remove follow action"
This reverts commit defbb416480905af2150d1c92f10d8e1d1288c0a.
* Revert "clean up"
This reverts commit f94919cb9cff41e274044fc69c56ad36a33974f2.
* remove fetch specification
* renoteの条件追加
* apiFetch => cli
* bypass fetch?
* fix
* refactor: use path alias
* temp: add submodule
* remove submodule
* enhane: unison-reloadに指定したパスに移動できるように
* null
* null
* feat: ログインするアカウントのIDをクエリ文字列で指定する機能
* null
* await?
* rename
* rename
* Update read.ts
* merge
* get-note-summary
* fix
* swパッケージに
* add missing packages
* fix getNoteSummary
* add webpack-cli
* ✌️
* remove plugins
* sw-inject分離したがテストしてない
* fix notification.vue
* remove a blank line
* disconnect intersection observer
* disconnect2
* fix notification.vue
* remove a blank line
* disconnect intersection observer
* disconnect2
* fix
* ✌️
* clean up config
* typesを戻した
* Update packages/client/src/components/notification.vue
Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
* disconnect
* oops
* Failed to load the script unexpectedly回避
sw.jsとlib.tsを分離してみた
* truncate notification
* Update packages/client/src/ui/_common_/common.vue
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
* clean up
* clean up
* キャッシュ対策
* Truncate push notification message
* クライアントがあったらストリームに接続しているということなので通知しない判定の位置を修正
* components/drive-file-thumbnail.vue
* components/drive-select-dialog.vue
* components/drive-window.vue
* merge
* fix
* Service Workerのビルドにesbuildを使うようにする
* return createEmptyNotification()
* fix
* i18n.ts
* update
* ✌️
* remove ts-loader
* fix
* fix
* enhance: Service Workerを常に登録するように
* pollEnded
* URLをsw.jsに戻す
* clean up
* wip
* wip
* wip
* wip
* wip
* wip
* ✌️
* use import
* fix
* install rollup
* use defineAsyncComponent.
* fix emojilist
* wip use defineAsyncComponent
* popup(import -> popup(defineAsyncComponent(() => import
* draggable?
* fix init import
* clean up
* fix router
* add comment
* ✌️
* ✌️
* ✌️
* remove webpack
* update vite
* fix boot sequence
* Revert "fix boot sequence"
This reverts commit e893dbf37aed83bf9f12e427d98c78a7065b4a39.
* revert boot import
* never make two app div
* ;
* remove console.log
* change clientEntry sequence
* fix
* Revert "fix"
This reverts commit 12741b3d89950a31dbb1bb81477ddb27b0e9951a.
* fix
* add comment https://github.com/misskey-dev/misskey/pull/8575#issuecomment-1114239210
* add log
* add comment
Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2022-05-01 22:51:07 +09:00
6ed010b192
fix _misskey_content of quote renotes ( #8533 )
2022-05-01 19:23:34 +09:00
MeiMei
60391ff37e
fix: Add rel attribute to host-meta ( #8583 )
...
* Add rel attribute to host-meta
* CHANGELOG
2022-05-01 19:14:14 +09:00
tamaina
766559c6e9
feat: Improve Push Notification ( #7667 )
...
* clean up
* ev => data
* refactor
* clean up
* add type
* antenna
* channel
* fix
* add Packed type
* add PackedRef
* fix lint
* add emoji schema
* add reversiGame
* add reversiMatching
* remove signin schema (use Signin entity)
* add schemas refs, fix Packed type
* wip PackedHoge => Packed<'Hoge'>
* add Packed type
* note-reaction
* user
* user-group
* user-list
* note
* app, messaging-message
* notification
* drive-file
* drive-folder
* following
* muting
* blocking
* hashtag
* page
* app (with modifying schema)
* import user?
* channel
* antenna
* clip
* gallery-post
* emoji
* Packed
* reversi-matching
* update stream.ts
* https://github.com/misskey-dev/misskey/pull/7769#issuecomment-917542339
* fix lint
* clean up?
* add app
* fix
* nanka iroiro
* wip
* wip
* fix lint
* fix loginId
* fix
* refactor
* refactor
* remove follow action
* clean up
* Revert "remove follow action"
This reverts commit defbb416480905af2150d1c92f10d8e1d1288c0a.
* Revert "clean up"
This reverts commit f94919cb9cff41e274044fc69c56ad36a33974f2.
* remove fetch specification
* renoteの条件追加
* apiFetch => cli
* bypass fetch?
* fix
* refactor: use path alias
* temp: add submodule
* remove submodule
* enhane: unison-reloadに指定したパスに移動できるように
* null
* null
* feat: ログインするアカウントのIDをクエリ文字列で指定する機能
* null
* await?
* rename
* rename
* Update read.ts
* merge
* get-note-summary
* fix
* swパッケージに
* add missing packages
* fix getNoteSummary
* add webpack-cli
* ✌️
* remove plugins
* sw-inject分離したがテストしてない
* fix notification.vue
* remove a blank line
* disconnect intersection observer
* disconnect2
* fix notification.vue
* remove a blank line
* disconnect intersection observer
* disconnect2
* fix
* ✌️
* clean up config
* typesを戻した
* Update packages/client/src/components/notification.vue
Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
* disconnect
* oops
* Failed to load the script unexpectedly回避
sw.jsとlib.tsを分離してみた
* truncate notification
* Update packages/client/src/ui/_common_/common.vue
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
* clean up
* clean up
* キャッシュ対策
* Truncate push notification message
* クライアントがあったらストリームに接続しているということなので通知しない判定の位置を修正
* components/drive-file-thumbnail.vue
* components/drive-select-dialog.vue
* components/drive-window.vue
* merge
* fix
* Service Workerのビルドにesbuildを使うようにする
* return createEmptyNotification()
* fix
* i18n.ts
* update
* ✌️
* remove ts-loader
* fix
* fix
* enhance: Service Workerを常に登録するように
* pollEnded
* URLをsw.jsに戻す
* clean up
Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
2022-04-30 21:52:07 +09:00
dependabot[bot]
1c6d5ddf81
chore(deps): bump ejs from 3.1.6 to 3.1.7 in /packages/backend ( #8560 )
...
Bumps [ejs](https://github.com/mde/ejs ) from 3.1.6 to 3.1.7.
- [Release notes](https://github.com/mde/ejs/releases )
- [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mde/ejs/compare/v3.1.6...v3.1.7 )
---
updated-dependencies:
- dependency-name: ejs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-30 00:16:40 +09:00
tamaina
12a3c6872f
enhance: ドライブに画像ファイルをアップロードするときオリジナル画像を破棄してwebpublicのみ保持するオプション ( #8216 )
...
* wip
* Update packages/client/src/os.ts
Co-authored-by: tamaina <tamaina@hotmail.co.jp>
* メニューをComposition API化、switchアイテム追加
クライアントサイド画像圧縮の準備
* メニュー型定義を分離 (TypeScriptの型支援が効かないので)
* disabled
* make keepOriginal to follow setting value
* ✌️
* fix
* fix
* ✌️
* WEBP
* aaa
* ✌️
* webp
* lazy load browser-image-resizer
* rename
* rename 2
* Fix
* clean up
* add comment
* clean up
* jpeg, pngにもどす
* fix
* fix name
* webpでなくする ただしサムネやプレビューはwebpのまま (テスト)
* 動画サムネイルはjpegに
* エラーハンドリング
* ✌️
* v2.2.1-misskey-beta.2
* browser-image-resizer#v2.2.1-misskey.1
* ✌️
* fix alert
* update browser-image-resizer to v2.2.1-misskey.2
* lockfile
Co-authored-by: mei23 <m@m544.net>
Co-authored-by: MeiMei <30769358+mei23@users.noreply.github.com>
2022-04-28 11:14:03 +09:00
tamaina
065324d30b
Fix #8535 Excessive stack ... 'SchemaTypeDef<?>' ( #8547 )
...
* Fix #8535 Excessive stack ... 'SchemaTypeDef<?>'
Co-authored-by: acid-chicken <root@acid-chicken.com>
* add comment
* clean up
Co-authored-by: acid-chicken <root@acid-chicken.com>
2022-04-27 10:49:00 +09:00
b9e3267198
fix: Promises -> Promise ( #8545 )
2022-04-25 15:14:13 +09:00
7e28c396b9
enhance: only render public notes in HTML template ( #8527 )
...
* only render public notes in HTML template
* fix missing import
2022-04-24 14:17:09 +09:00
tamaina
1b2ba09be0
fix: Fix schema key type error #8517 ( #8538 )
2022-04-24 11:43:15 +09:00
syuilo
fd13173eaf
bump jsrsasign
2022-04-23 12:48:26 +09:00
