AkkomaGang/akkoma-fe
4
13
Fork 56
Code Issues 74 Pull requests 14 Projects Releases 1 Wiki Activity

[feat] Support prefers-reduced-motion disabling auto-play of animated images (#324) #325

Merged
floatingghost merged 3 commits from Mergan/pleroma-fe:support-prefers-reduced-motion into develop 2023-07-21 19:37:44 +00:00
Conversation 7 Commits 3 Files changed 1 +2 -2
Mergan commented 2023-07-20 23:27:31 +00:00
Member
Copy link

Tested on Google Chrome/Windows 10

Tested on Google Chrome/Windows 10
Mergan added 2 commits 2023-07-20 23:27:32 +00:00
Turn on by default
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
e2125c57d6
Mergan changed title from [feat] Support prefers-reduced-motion disabling auto-play of animated images #324 to [feat] Support prefers-reduced-motion disabling auto-play of animated images (#324) 2023-07-20 23:27:48 +00:00
Mergan added the
a11y
 label 2023-07-20 23:28:28 +00:00
floatingghost commented 2023-07-20 23:45:39 +00:00
Owner
Copy link

oh this is cool! thanks!

I do have one question - maybe prefers-reduced should create the initial value of stopGifs rather than interacting with it? the && chain worries me a little, maybe it should just set stopGifs to (server stopGifs || prefers reduced)?

what do you think?

oh this is cool! thanks! I do have one question - maybe prefers-reduced should create the initial value of stopGifs rather than interacting with it? the && chain worries me a little, maybe it should just set stopGifs to (server stopGifs || prefers reduced)? what do you think?
Mergan commented 2023-07-20 23:53:18 +00:00
Author
Member
Copy link

Something like
stopGifs = window.matchMedia('(prefers-reduced-motion: reduce)').matches || this.$store.getters.mergedConfig.stopGifs?

Something like `stopGifs = window.matchMedia('(prefers-reduced-motion: reduce)').matches || this.$store.getters.mergedConfig.stopGifs`?
floatingghost commented 2023-07-20 23:55:59 +00:00
Owner
Copy link

yeah something like that maybe? at least that makes sense to me

I'm assuming anyone with the browser setting on wouldn't bother toggling it off so I think that logically works? feel free to say I'm silly though I'm not au fait with accessibility optiond

yeah something like that maybe? at least that makes sense to me I'm assuming anyone with the browser setting on wouldn't bother toggling it off so I think that logically works? feel free to say I'm silly though I'm not au fait with accessibility optiond
Mergan commented 2023-07-21 00:00:37 +00:00
Author
Member
Copy link

Makes sense to me as well, aye-- I'll push the change in a bit.

Discovered that emoji reactions don't follow the StillImage thingy, so they're animated regardless of any option; I'm seeing if I can make it so that it follows the rule as well :cat_si:

Makes sense to me as well, aye-- I'll push the change in a bit. Discovered that emoji reactions don't follow the StillImage thingy, so they're animated regardless of any option; I'm seeing if I can make it so that it follows the rule as well :cat_si:
floatingghost commented 2023-07-21 00:02:17 +00:00
Owner
Copy link

there's also mfm animations in there somewhere as well :hehe:

there's also mfm animations in there somewhere as well :hehe:
👍 1
Mergan added 1 commit 2023-07-21 00:19:04 +00:00
Simplified and fixed and/or oopsie
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
91eab22d77
Mergan commented 2023-07-21 00:19:32 +00:00
Author
Member
Copy link

It is done :acat_joy: (I wish we had emojis here :( )

It is done :acat_joy: (I wish we had emojis here :( )
floatingghost commented 2023-07-21 19:37:40 +00:00
Owner
Copy link

thanks! i'll use this as a reference implementation to extend across anything that uses it

thanks! i'll use this as a reference implementation to extend across anything that uses it
floatingghost merged commit a4e82f7886 into develop 2023-07-21 19:37:44 +00:00
floatingghost deleted branch support-prefers-reduced-motion 2023-07-21 19:37:44 +00:00
mel referenced this pull request from a commit 2024-05-15 22:36:01 +00:00
Squashed commit of the following:
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#325
No description provided.
Delete branch "Mergan/pleroma-fe:support-prefers-reduced-motion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?