Remove descriptions in timeline menu, change to titles and aria-labels #74

Merged

floatingghost merged 2 commits from eris/pleroma-fe:timeline-text-as-titles into develop

2022-08-02 09:18:59 +00:00

eris commented

2022-07-29 00:06:44 +00:00

Contributor

Strips the text and adds it as alt-text / popover title as well as aria-label for screenreaders

This lets you close #47

Strips the text and adds it as alt-text / popover title as well as aria-label for screenreaders This lets you close #47

eris added 1 commit 2022-07-29 00:06:44 +00:00

Remove descriptions in timeline menu, change to title

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

c74e939a82

floatingghost commented

2022-07-31 22:06:05 +00:00

Owner

hm, whilst this works, apparently title isn't recommended for this per accessibility guidelines

i'm gonna play around with aria- attributes and see if i can get a working setup that way

hm, whilst this works, apparently `title` isn't recommended for this per [accessibility guidelines](https://www.a11yproject.com/posts/title-attributes/) i'm gonna play around with `aria-` attributes and see if i can get a working setup that way

eris commented

2022-08-01 17:28:45 +00:00

Author

Contributor

hm, whilst this works, apparently title isn't recommended for this per accessibility guidelines

i'm gonna play around with aria- attributes and see if i can get a working setup that way

There's some debate about that article here:

https://stackoverflow.com/questions/27953425/what-is-the-difference-between-aria-label-and-title-attributes

The most preferred solution seemed to have been using both title and aria-label, I'll add that into the PR

> hm, whilst this works, apparently `title` isn't recommended for this per [accessibility guidelines](https://www.a11yproject.com/posts/title-attributes/) > > i'm gonna play around with `aria-` attributes and see if i can get a working setup that way There's some debate about that article here: https://stackoverflow.com/questions/27953425/what-is-the-difference-between-aria-label-and-title-attributes The most preferred solution seemed to have been using both `title` and `aria-label`, I'll add that into the PR

eris added 1 commit 2022-08-01 17:47:57 +00:00

Update timeline menu content with screenreader accessible labels

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

df031449ca

eris changed title from ~~Remove descriptions in timeline menu, change to title~~ to Remove descriptions in timeline menu, change to titles and aria-labels

2022-08-01 17:48:27 +00:00

eris commented

2022-08-01 17:49:27 +00:00

Author

Contributor

Okay @floatingghost all ready for review and this should make everynyan happy~

eris added the

a11y

label 2022-08-01 18:00:11 +00:00

floatingghost commented

2022-08-02 09:18:48 +00:00

Owner