AkkomaGang
/
akkoma-fe
4
13
Fork 56
Code Issues 71 Pull Requests 16 Projects Releases 1 Wiki Activity

Separated Posts & Replies (#145) #148

Merged
floatingghost merged 2 commits from Mergan/pleroma-fe:pleroma-fe#145 into develop 2022-08-31 15:28:09 +00:00
Conversation 4 Commits 2 Files Changed 5 +26 -3
Mergan commented 2022-08-30 20:22:13 +00:00
Member
Copy Link
No description provided.
Mergan added 1 commit 2022-08-30 20:22:14 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
c0fa9c2f4c Separated Posts & Replies (#145)
eris commented 2022-08-30 21:06:29 +00:00
Contributor
Copy Link

That was fast lol. I'll test in a bit

That was fast lol. I'll test in a bit
eris commented 2022-08-31 01:30:58 +00:00
Contributor
Copy Link

I'm running into this issue with it where randomly, like 2/3rds of the time, when I switch tabs it won't load the posts with replies and the link to show more does nothing. But when I refresh the page, it works. No console error.

I'm running into this issue with it where randomly, like 2/3rds of the time, when I switch tabs it won't load the posts with replies and the link to show more does nothing. But when I refresh the page, it works. No console error.
Screen Shot 2022-08-30 at 6.32.15 PM.png
1.4 MiB
Screen Shot 2022-08-30 at 6.29.16 PM.png
1.1 MiB
Screen Shot 2022-08-30 at 6.32.15 PM.png Screen Shot 2022-08-30 at 6.29.16 PM.png
eris requested changes 2022-08-31 01:49:07 +00:00
eris left a comment
Contributor
Copy Link

c0fa9c2f4c/src/components/user_profile/user_profile.js (L144)

Needs this.$store.dispatch('stopFetchingTimeline', 'replies')

and then it will work

https://akkoma.dev/AkkomaGang/pleroma-fe/src/commit/c0fa9c2f4cfac3151811b9185b7db069b52b4c70/src/components/user_profile/user_profile.js#L144 Needs `this.$store.dispatch('stopFetchingTimeline', 'replies')` and then it will work
❤️ 1
Mergan commented 2022-08-31 03:04:16 +00:00
Author
Member
Copy Link

Thank ye

Thank ye
Mergan added 1 commit 2022-08-31 03:08:04 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
86f83682c1 Stop Fetching 
oops
Mergan requested review from eris 2022-08-31 03:08:20 +00:00
eris approved these changes 2022-08-31 04:09:54 +00:00
floatingghost commented 2022-08-31 15:28:03 +00:00
Owner
Copy Link

mildly worried about the load this might place on the DB with double-fetching statuses here

putting together a quick patch for that, but the implementation works! thanks

mildly worried about the load this might place on the DB with double-fetching statuses here putting together a quick patch for that, but the implementation works! thanks
floatingghost merged commit 48826ede36 into develop 2022-08-31 15:28:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
eris
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No Label
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#148
No description provided.
Delete Branch "Mergan/pleroma-fe:pleroma-fe#145"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?