AkkomaGang/akkoma-fe
4
13
Fork 70
Code Issues 84 Pull requests 17 Projects Releases 1 Wiki Activity

Emoji reactions: Make keep open button work #241

Closed
sam wants to merge 1 commit from sam/pleroma-fe:emoji-react-keep-open into develop
pull from: sam/pleroma-fe:emoji-react-keep-open
merge into: AkkomaGang:develop
Conversation 3 Commits 1 Files changed 1 +2 -1
sam commented 2022-12-01 22:53:50 +00:00
First-time contributor
Copy link

This PR fixes the "keep picker open" button on the emoji reaction menu, previously it was ignored and the menu would always close.

Feel free to lint it however, this is just the concept for the fix

This PR fixes the "keep picker open" button on the emoji reaction menu, previously it was ignored and the menu would always close. Feel free to lint it however, this is just the concept for the fix
sam added 1 commit 2022-12-01 22:53:50 +00:00
emoji react: make keep picker button do something
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
5bd436892b 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
Mergan commented 2022-12-02 10:19:29 +00:00
Member
Copy link

I thought it was "keep open" for multiple emojis? Attached video of current behavior

I thought it was "keep open" for multiple emojis? Attached video of current behavior
2022-12-02 02-18-06.mp4
613 KiB
Ghost commented 2022-12-02 10:39:13 +00:00
First-time contributor
Copy link

yeah, the reaction picker used to be a different slower picker and floaty just changed it to be the post picker instead
the keep picker open option was meant for the post form, never for the reaction

another way to solve this issue would be to hide the checkbox if reacting? but this pr adds neat functionality

yeah, the reaction picker used to be a different slower picker and floaty just changed it to be the post picker instead the keep picker open option was meant for the post form, never for the reaction another way to solve this issue would be to hide the checkbox if reacting? but this pr adds neat functionality
floatingghost commented 2022-12-02 11:14:02 +00:00
Owner
Copy link

hiding is probably the best behaviour here, we don't want to encourage spamming reactions

hiding is probably the best behaviour here, we don't want to encourage spamming reactions
sam closed this pull request 2022-12-02 16:32:23 +00:00
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#241
No description provided.
Delete branch "sam/pleroma-fe:emoji-react-keep-open"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?