AkkomaGang
/
akkoma-fe
4
13
Fork 56
Code Issues 72 Pull Requests 16 Projects Releases 1 Wiki Activity

WIP: feat: account switching #279

Draft
nbsp wants to merge 1 commits from nbsp/pleroma-fe:feat/account-switching into develop
pull from: nbsp/pleroma-fe:feat/account-switching
merge into: AkkomaGang:develop
Conversation 8 Commits 1 Files Changed 12 +195 -19
nbsp commented 2023-02-07 16:43:37 +00:00
Contributor
Copy Link

disclaimer this is ass

this is just a proof of concept and it sucks and is garbage and very much a wip with broken parts literally everywhere i'll get to that

this PR implements multiple account support in the frontend, and account switching. for people who have two accounts on the same instance but don't want to use two firefox containers.

  • store keys of multiple accounts
  • clear notifs/timelines/friends when logging in to a new user or switching users
  • log back to the other account if logging out with 2+ accounts
  • replace every instance of getToken to expect an object, and not just a string
  • load the friends timeline when switching to an account
  • deal with the switcher erroring if not every user is loaded
  • get rid of the 2s where it looks like you're logged out
  • implement the register button
  • make this work without erasing cookies
  • make the code not FLAMING HOT ASS GARBAGE
# disclaimer this is ass this is just a proof of concept and it sucks and is garbage and very much a wip with broken parts literally everywhere i'll get to that <hr /> this PR implements multiple account support in the frontend, and account switching. for people who have two accounts on the same instance but don't want to use two firefox containers. - [x] store keys of multiple accounts - [x] clear notifs/timelines/friends when logging in to a new user or switching users - [x] log back to the other account if logging out with 2+ accounts - [ ] replace every instance of getToken to expect an object, and not just a string - [ ] load the friends timeline when switching to an account - [ ] deal with the switcher erroring if not every user is loaded - [ ] get rid of the 2s where it looks like you're logged out - [ ] implement the register button - [ ] make this work without erasing cookies - [ ] make the code not *FLAMING HOT ASS GARBAGE*
23-02-07-184520.png
413 KiB
23-02-07-184520.png
nbsp added 1 commit 2023-02-07 16:43:38 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
22fdb50d88
feat: account switching
floatingghost commented 2023-02-07 16:44:52 +00:00
Owner
Copy Link

ok yeah but like find and deal with it automatically instead of asking everyone to clear cookies when updating to this version

ok yeah but like find and deal with it automatically instead of asking everyone to clear cookies when updating to this version
nbsp commented 2023-02-07 16:47:34 +00:00
Author
Contributor
Copy Link

ok yeah but like find and deal with it automatically instead of asking everyone to clear cookies when updating to this version

ok yeah but like find and deal with it automatically instead of asking everyone to clear cookies when updating to this version
nbsp commented 2023-02-07 16:48:08 +00:00
Author
Contributor
Copy Link

what the fuck did i do with that comment im dumb im gonna have cofe

what the fuck did i do with that comment im dumb im gonna have cofe
floatingghost commented 2023-02-07 16:48:41 +00:00
Owner
Copy Link

i would advise against doing this as a whole

pleroma-fe was built as a single-account client and does not even use oauth most of the time

i would advise against doing this as a whole pleroma-fe was built as a single-account client and does not even use oauth most of the time
floatingghost commented 2023-02-07 16:49:06 +00:00
Owner
Copy Link

additionally, the content security policy disallows it connecting to remote instances, massively limiting the usefulness even if this did work

additionally, the content security policy disallows it connecting to remote instances, massively limiting the usefulness even if this did work
nbsp commented 2023-02-07 16:52:46 +00:00
Author
Contributor
Copy Link

does not even use oauth most of the time

it doesn't, no, but that only makes the implementation easier, it seems
as long as you store all of the keys you can act as all accounts without constantly needing to figure out which account you are

additionally, the content security policy disallows it connecting to remote instances, massively limiting the usefulness even if this did work

meh, misskey has this and it's been a genuinely useful feature for bots and such

> does not even use oauth most of the time it doesn't, no, but that only makes the implementation easier, it seems as long as you store all of the keys you can act as all accounts without constantly needing to figure out which account you are > additionally, the content security policy disallows it connecting to remote instances, massively limiting the usefulness even if this did work meh, misskey has this and it's been a genuinely useful feature for bots and such
nbsp commented 2023-02-07 16:54:53 +00:00
Author
Contributor
Copy Link

i mean i'm fine with not doing this it's a niche and it does add a lot of complexity

i mean i'm fine with not doing this it's a niche and it does add a lot of complexity
foxing commented 2023-03-11 03:53:55 +00:00
First-time contributor
Copy Link

@sfr I think this would be a good change even if just for an instance admin, or you want to manage a few accounts like a bot account, a main, a close friends only vent account etc in a convenient manner. It doesn't have to support external accounts, even just as something for only local accounts it's a good change.

Currently I do it with firefox containers (one for each account) but it's honestly really inconvenient.

@sfr I think this would be a good change even if just for an instance admin, or you want to manage a few accounts like a bot account, a main, a close friends only vent account etc in a convenient manner. It doesn't have to support external accounts, even just as something for only local accounts it's a good change. Currently I do it with firefox containers (one for each account) but it's honestly really inconvenient.
Mergan added the
WIP
Feature
 labels 2023-03-15 21:15:19 +00:00
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No Label
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#279
No description provided.
Delete Branch "nbsp/pleroma-fe:feat/account-switching"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?