AkkomaGang/akkoma-fe
4
15
Fork 73
Code Issues 70 Pull requests 14 Projects Releases 1 Wiki Activity

request relationships when fetching blocks & mutes #319

Closed
flisk wants to merge 1 commit from flisk/akkoma-fe:fix-mute-block-button-states into develop
pull from: flisk/akkoma-fe:fix-mute-block-button-states
merge into: AkkomaGang:develop
Conversation 2 Commits 1 Files changed 1 +2 -2
flisk commented 2023-05-30 10:11:36 +00:00
Contributor
Copy link

mute/block buttons in the settings modal don't currently reflect the actual relationship with listed users due to a missing request parameter.

this change adds the missing parameter to both relevant URLs. it fixes button state for mutes, but in order for blocks to be displayed correctly, a backend change is required as well. pleroma has already implemented this change: pleroma/-@d83f16fe44

mute/block buttons in the settings modal don't currently reflect the actual relationship with listed users due to a missing request parameter. this change adds the missing parameter to both relevant URLs. it fixes button state for mutes, but in order for blocks to be displayed correctly, a backend change is required as well. pleroma has already implemented this change: https://git.pleroma.social/pleroma/pleroma/-/commit/d83f16fe44210517ceec7bc7786728c1f4d81627
request relationships when fetching blocks & mutes
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
982c5eaf8d
flisk commented 2023-05-30 10:16:59 +00:00
Author
Contributor
Copy link

in fact, it might be worth pulling this from pleroma wholesale, because someone fixed this problem as part of a related feature that seems desirable: https://git.pleroma.social/pleroma/pleroma-fe/-/merge_requests/1790

in fact, it might be worth pulling this from pleroma wholesale, because someone fixed this problem as part of a related feature that seems desirable: https://git.pleroma.social/pleroma/pleroma-fe/-/merge_requests/1790
floatingghost commented 2023-08-04 14:55:05 +00:00
Owner
Copy link

as suggested, pulled that PR

included via 29cfdcbbcd

as suggested, pulled that PR included via 29cfdcbbcdb5076e9b2d17c11184c5c59d9fc024
floatingghost closed this pull request 2023-08-04 14:55:05 +00:00
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
cannot reproduce

   
CSS

Related to CSS styling

  
Documentation

  
enhancement

Improving existing stuff

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
Minor change

For minor changes, ie CSS alignment changes

  
performance

Poor performance or too high resource usage

  
priority: critical

   
priority: high

   
priority: low

   
priority: medium

   
priority: patch welcome

   
regression

   
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
cannot reproduce
CSS
Documentation
enhancement
Feature
Feature request
Held for next release cycle
Minor change
performance
priority: critical
priority: high
priority: low
priority: medium
priority: patch welcome
regression
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AkkomaGang/akkoma-fe!319
No description provided.