AkkomaGang/akkoma-fe

Fork 64

[feat] Support prefers-reduced-motion disabling auto-play of animated images (#324) #325

Merged

floatingghost merged 3 commits from Mergan/pleroma-fe:support-prefers-reduced-motion into develop

2023-07-21 19:37:44 +00:00

Mergan commented

2023-07-20 23:27:31 +00:00

Member

Tested on Google Chrome/Windows 10

Mergan added 2 commits 2023-07-20 23:27:32 +00:00

Add prefers-reduced-motion support e0a6418e91

Turn on by default

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

e2125c57d6

Mergan changed title from ~~[feat] Support prefers-reduced-motion disabling auto-play of animated images #324~~ to [feat] Support prefers-reduced-motion disabling auto-play of animated images (#324)

2023-07-20 23:27:48 +00:00

Mergan added the

a11y

label 2023-07-20 23:28:28 +00:00

floatingghost commented

2023-07-20 23:45:39 +00:00

Owner

oh this is cool! thanks!

I do have one question - maybe prefers-reduced should create the initial value of stopGifs rather than interacting with it? the && chain worries me a little, maybe it should just set stopGifs to (server stopGifs || prefers reduced)?

what do you think?

oh this is cool! thanks! I do have one question - maybe prefers-reduced should create the initial value of stopGifs rather than interacting with it? the && chain worries me a little, maybe it should just set stopGifs to (server stopGifs || prefers reduced)? what do you think?

Mergan commented

2023-07-20 23:53:18 +00:00

Author

Member

Something like
stopGifs = window.matchMedia('(prefers-reduced-motion: reduce)').matches || this.$store.getters.mergedConfig.stopGifs?

Something like `stopGifs = window.matchMedia('(prefers-reduced-motion: reduce)').matches || this.$store.getters.mergedConfig.stopGifs`?

floatingghost commented

2023-07-20 23:55:59 +00:00

Owner

yeah something like that maybe? at least that makes sense to me

I'm assuming anyone with the browser setting on wouldn't bother toggling it off so I think that logically works? feel free to say I'm silly though I'm not au fait with accessibility optiond

yeah something like that maybe? at least that makes sense to me I'm assuming anyone with the browser setting on wouldn't bother toggling it off so I think that logically works? feel free to say I'm silly though I'm not au fait with accessibility optiond

Mergan commented

2023-07-21 00:00:37 +00:00

Author

Member

Makes sense to me as well, aye-- I'll push the change in a bit.

Discovered that emoji reactions don't follow the StillImage thingy, so they're animated regardless of any option; I'm seeing if I can make it so that it follows the rule as well :cat_si:

Makes sense to me as well, aye-- I'll push the change in a bit. Discovered that emoji reactions don't follow the StillImage thingy, so they're animated regardless of any option; I'm seeing if I can make it so that it follows the rule as well :cat_si:

floatingghost commented

2023-07-21 00:02:17 +00:00

Owner

there's also mfm animations in there somewhere as well :hehe:

👍 1

Mergan added 1 commit 2023-07-21 00:19:04 +00:00

Simplified and fixed and/or oopsie

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

91eab22d77

Mergan commented

2023-07-21 00:19:32 +00:00