Allow webp/apng detection to work if media proxy is off and domain is the same #328

Closed

Mergan wants to merge 1 commits from Mergan/pleroma-fe:still-image-allow-same-host into develop

Mergan commented

2023-07-24 08:27:04 +00:00

Member

No description provided.

Mergan added 1 commit 2023-07-24 08:27:05 +00:00

ci/woodpecker/pr/woodpecker Pipeline was successful Details

94cec3c1ee Allow webp/apng detection to work if media proxy is off and domain is the same

floatingghost commented

2023-07-24 09:46:42 +00:00

Owner

it's me here with the "what about"s

a lot of people run mediaproxy on a subdomain these days, i think cors should be happy with that?

so i reckon we might want to allow for subdomain usage as well as same-domain usage as it is here

then again maybe cors doesn't work i'm not actually certain about that

it's me here with the "what about"s a lot of people run mediaproxy on a subdomain these days, i think cors should be happy with that? so i reckon we might want to allow for subdomain usage as well as same-domain usage as it is here then again maybe cors doesn't work i'm not actually certain about that

Mergan commented

2023-07-24 19:40:04 +00:00

Author

Member

Makes sense to me I think-- trying to think of mediaproxy on a different domain though... Maybe it should only check for same domain? Hmmm