AkkomaGang
/
akkoma-fe
4
13
Fork 56
Code Issues 71 Pull Requests 16 Projects Releases 1 Wiki Activity

Add support selectable visibility of repeat #345

Open
jadiunr wants to merge 1 commits from jadiunr/akkoma-fe:add-support-selectable-visibility-of-repeat into develop
pull from: jadiunr/akkoma-fe:add-support-selectable-visibility-of-repeat
merge into: AkkomaGang:develop
Conversation 1 Commits 1 Files Changed 4 +20 -6
jadiunr commented 2023-10-02 01:34:49 +00:00
First-time contributor
Copy Link

This PR adds the feature to make visibility selectable in the confirmation dialog when executing repeat.

  • current mastodon implementation

  • akkoma-fe (before)

akkoma_before

  • akkoma-fe (after)

akkoma_after

This PR adds the feature to make visibility selectable in the confirmation dialog when executing repeat. - current mastodon implementation ![](/attachments/0e1c2a33-b94c-4e35-9d98-478ec3d4b992) - akkoma-fe (before) ![akkoma_before](/attachments/5634003b-7a95-4e43-a307-7483e26df642) - akkoma-fe (after) ![akkoma_after](/attachments/f8c5d81d-09f4-4f9b-9d6d-3542b5fc570e)
akkoma_before.png
12 KiB
akkoma_after.png
14 KiB
jadiunr force-pushed add-support-selectable-visibility-of-repeat from dc94116a5e to 5c1173818b 2023-10-02 01:35:25 +00:00 Compare
jadiunr force-pushed add-support-selectable-visibility-of-repeat from 5c1173818b to 4313b386f0 2023-10-02 01:52:35 +00:00 Compare
Mergan added the
Feature
 label 2023-10-02 22:32:13 +00:00
floatingghost commented 2023-12-15 12:03:09 +00:00
Owner
Copy Link

hm, i'm not overly sure this is totally complete

the current UI will allow you to select a "public" scope on one of your own posts that is "private", which errors!

the valid scopes should be limited to be equal to or less broad than the original post

hm, i'm not overly sure this is totally complete the current UI will allow you to select a "public" scope on one of your own posts that is "private", which errors! the valid scopes should be limited to be equal to or less broad than the original post
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No Label
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#345
No description provided.
Delete Branch "jadiunr/akkoma-fe:add-support-selectable-visibility-of-repeat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?