AkkomaGang
/
akkoma-fe
4
13
Fork 56
Code Issues 71 Pull Requests 16 Projects Releases 1 Wiki Activity

Display profile background of other users #371

Merged
floatingghost merged 1 commits from Oneric/akkoma-fe:profile-backgrounds into develop 2024-02-20 16:20:15 +00:00
Conversation 1 Commits 1 Files Changed 6 +28 -2
Oneric commented 2024-02-14 17:46:20 +00:00
Member
Copy Link

And add a new frontend setting to hide other people's background.

To repeat what I already wrote in AkkomaGang/akkoma#682, the backgrounds are already (and probably always were) publicly readable via API, so this does not expose previously private info. Presumably displaying them was the original intent.

By itself this will only work for local users, but together with AkkomaGang/akkoma#682 remote backgrounds from other Akkoma or Sharkey instances will work too.

I was on the fence whether to make the default for the new setting false or true. For now I went with true to let people discover the new feature, but I don’t feel strongly about this. If you’d prefer false just let me know (or feel free to directly amend the commit on your own).

And add a new frontend setting to hide other people's background. To repeat what I already wrote in https://akkoma.dev/AkkomaGang/akkoma/pulls/682, the backgrounds are already (and probably always were) publicly readable via API, so this does not expose previously private info. Presumably displaying them was the original intent. By itself this will only work for local users, but together with https://akkoma.dev/AkkomaGang/akkoma/pulls/682 remote backgrounds from other Akkoma or Sharkey instances will work too. I was on the fence whether to make the default for the new setting `false` or `true`. For now I went with `true` to let people discover the new feature, but I don’t feel strongly about this. If you’d prefer `false` just let me know (or feel free to directly amend the commit on your own).
Oneric added 1 commit 2024-02-14 17:46:21 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
050c7df2e6 Display profile background of other users 
And add a new frontend setting to hide other people's background.
floatingghost commented 2024-02-20 16:20:11 +00:00
Owner
Copy Link

works, thanks!

works, thanks!
floatingghost merged commit 0f842b300b into develop 2024-02-20 16:20:15 +00:00
floatingghost deleted branch profile-backgrounds 2024-02-20 16:20:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No Label
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#371
No description provided.
Delete Branch "Oneric/akkoma-fe:profile-backgrounds"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?