feat: Add "Default post language" option #387

partizan · 2024-04-20T13:11:31Z

partizan commented

2024-04-20 13:11:31 +00:00

First-time contributor

I have added setting for default posting option.

I changed direct import of iso6391 into composable usePostLanguageOptions, to avoid duplicating code.

Please advise where to best put this composable, i put it into src/lib for now.

Refs #386

I have added setting for default posting option. I changed direct import of iso6391 into composable usePostLanguageOptions, to avoid duplicating code. Please advise where to best put this composable, i put it into src/lib for now. Refs #386

partizan added 1 commit 2024-04-20 13:11:31 +00:00

feat: Add "Default post language" option

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

042e8c78dc

Refs #386

partizan commented

2024-04-21 09:34:34 +00:00

First-time contributor

@floatingghost please take a look

Oneric reviewed 2024-05-13 01:33:04 +00:00

Oneric left a comment

sans one small nit, seems good afaict

this will introduce or be affected by a small merge conflict with #377, but should be easy to fix regardless of what is merged first

sans one small nit, seems good afaict this will introduce or be affected by a small merge conflict with #377, but should be easy to fix regardless of what is merged first

src/components/post_status_form/post_status_form.js

					
				@ -165,3 +174,3 @@

				        mediaDescriptions: this.statusMediaDescriptions || {},

				        visibility: this.statusScope || this.suggestedVisibility(),

				        language: this.statusLanguage || interfaceLanguage,

				        language: this.statusLanguage || postLanguage,

Oneric commented

2024-05-13 01:30:23 +00:00

note: this doesn’t actually work for edit dialogues (always falls back to interface/defaultPostLanguage), but that’s a pre-existing issue so no need to worry about for this patch

partizan marked this conversation as resolved

src/components/post_status_form/post_status_form.vue Outdated

					
				@ -214,2 +213,3 @@

				                :value="language.value"

				              >

				                {{ language }}

				                {{ language.value }}

Oneric commented

2024-05-13 00:43:03 +00:00

ig for consistency in case we ever tweak the human-readable labels, this should use language.key and langauge.label at the appropriate places

ig for consistency in case we ever tweak the human-readable labels, this should use `language.key` and `langauge.label` at the appropriate places

partizan marked this conversation as resolved

partizan added 1 commit 2024-05-13 13:14:21 +00:00

fix: Use label and key for options

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

57beea6a0d

partizan commented

2024-05-13 13:21:55 +00:00

First-time contributor

@Oneric maybe merge #377 first, so i can handle that change here.

And i can look into into edit dialog bug after we merge this.

@Oneric maybe merge #377 first, so i can handle that change here. And i can look into into edit dialog bug after we merge this.

Oneric approved these changes 2024-05-13 17:41:46 +00:00

floatingghost commented

2024-05-28 02:22:18 +00:00

behaves as i would expect, thanks! i've fixed the merge conflict that 377 introduced and merged this via 1adef56603

behaves as i would expect, thanks! i've fixed the merge conflict that 377 introduced and merged this via 1adef56603929997fb0108e92f6eb39ed88b30fb

floatingghost closed this pull request

2024-05-28 02:22:18 +00:00

Oneric commented

2024-05-28 02:46:20 +00:00

@floatingghost seems like an error slipped into the merge conflict resolution; postLanguages still uses interfaceLanguage before the ISO normalisation and isoLanguage is now unused (defined directly after postLangauge)

@floatingghost seems like an error slipped into the merge conflict resolution; `postLanguages` still uses `interfaceLanguage` before the ISO normalisation and `isoLanguage` is now unused (defined directly _after_ `postLangauge`)

floatingghost commented

2024-05-28 03:04:48 +00:00

i must be stupid :)

i'll fix it

i must be stupid :) i'll fix it

floatingghost commented

2024-05-28 03:17:19 +00:00

ok it should be good now (tm)

👍 2

Oneric referenced this pull request from AkkomaGang/akkoma

2024-05-28 03:58:24 +00:00

meta: closeable issues #758