make status form selectors justified properly #398

rat · 2024-06-11T00:43:37Z

rat commented

2024-06-11 00:43:37 +00:00

The language selector is sometimes in the middle of the post form, for example when you reply. I think this is unintended, so I made two changes.

This PR adds a div under the visibility tray which contains the language and format selectors, so that the language selector is justified to the right with the format selector.

I also made the visibility tray justify right in the edit form, because otherwise the language and format selectors are at the start of the flex because the scope selector is gone.

:)

before

after

The language selector is sometimes in the middle of the post form, for example when you reply. I think this is unintended, so I made two changes. This PR adds a div under the visibility tray which contains the language and format selectors, so that the language selector is justified to the right with the format selector. I also made the visibility tray justify right in the edit form, because otherwise the language and format selectors are at the start of the flex because the scope selector is gone. :) before ![g20240610171116.png](/attachments/eb0c6016-6aab-40db-ac07-c71498e88227) ![g20240610171137.png](/attachments/24f07443-336a-4fa8-a64a-a119ad98c26a) after ![g20240610171445.png](/attachments/2cbc5a36-0461-41c1-9101-9e7b55e62852) ![g20240610171455.png](/attachments/5b77bb3d-f236-4275-a3bd-4e2af0dd815f)

g20240610171116.png

19 KiB

g20240610171455.png

23 KiB

g20240610171137.png

26 KiB

g20240610171445.png

19 KiB

rat added 1 commit

2024-06-11 00:43:38 +00:00

make status form selectors justified properly

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

aad023c8a0

floatingghost commented

2024-06-15 12:33:32 +00:00

ah i had stopped noticing but you're quite right, that is weirdly aligned

thanks for fixing it!

ah i had stopped noticing but you're quite right, that is weirdly aligned thanks for fixing it!

floatingghost merged commit 97966045cb into develop

2024-06-15 12:33:39 +00:00

floatingghost deleted branch status-form-selector

2024-06-15 12:33:39 +00:00

floatingghost referenced this pull request from a commit

2024-06-15 12:33:40 +00:00

Merge pull request 'make status form selectors justified properly' (#398) from rat/akkoma-fe:status-form-selector into develop

Oneric reviewed

2024-06-15 23:55:16 +00:00

src/components/post_status_form/post_status_form.vue

					
				@ -213,1 +204,3 @@

				                :value="language.value"

				            class="format-selector-container">

				            <div

				              class="format-selector"

is removal of the language-selector class here intentional?

is removal of the `language-selector` class here intentional?

as far as I could tell, that class didn't actually do anything

👍 1

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

AkkomaGang/akkoma-fe!398

Rows
Columns